Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Apr 01 18:07
    sjsrey synchronize #171
  • Apr 01 17:58

    sjsrey on master

    blacken repo update CI envs -36 +39,310 update unittests worklfow and 9 more (compare)

  • Apr 01 17:58
    sjsrey closed #173
  • Apr 01 17:58
    sjsrey commented #173
  • Apr 01 17:47
    sjsrey synchronize #171
  • Apr 01 17:43
    sjsrey synchronize #171
  • Mar 23 08:50
    martinfleis commented #173
  • Mar 22 23:41
    jGaboardi commented #173
  • Mar 21 05:38
    weikang9009 commented #173
  • Mar 21 00:21
    jGaboardi commented #173
  • Mar 21 00:21
    jGaboardi synchronize #173
  • Mar 21 00:06
    jGaboardi synchronize #173
  • Mar 20 22:48
    jGaboardi synchronize #173
  • Mar 20 21:56
    jGaboardi commented #172
  • Mar 20 19:44
    jGaboardi closed #164
  • Mar 20 19:44
    jGaboardi commented #164
  • Mar 20 19:42
    jGaboardi labeled #173
  • Mar 20 19:41
    jGaboardi synchronize #173
  • Mar 20 19:38
    jGaboardi edited #173
  • Mar 20 19:38
    jGaboardi edited #173
Wei Kang
@weikang9009
OK! I'll create a notebook for applying rank based measures to US data. Can we also keep one for the application to Mexico as I have made a notebook for it?
Thanks!
Sergio Rey
@sjsrey
On mexico, there should be a shapefile in my repos for the paper: https://github.com/sjsrey/limaaag
Wei Kang
@weikang9009
Looks great! Do you think it would be good to include it in the example datasets of libpysal?
Sergio Rey
@sjsrey
sure
Wei Kang
@weikang9009
Just submitted a pull request for adding the Mexico shapefile to libpysal.
Wei Kang
@weikang9009
The notebook of applying rank measures to Mexico data is living in my giddy repo. I'll also start to construct another one using US data.
Wei Kang
@weikang9009
Some issues about the rank-based measures:
  • Should I add the code for local tau, LIMA and inter- and intra-regional decomposition of mobility association?
  • rank.py includes a class Theta , the regime mobility measure. Reference for this measure is "Rey, S. J. (2004). Spatial dependence in the evolution of regional income distributions. In Getis, A., Múr, J., and Zoeller, H., editors, Spatial econometrics and spatial statistics, pages 193–213. Palgrave, Hampshire.", but I could not find it in the paper. Could you please refer me to the right paper?
Sergio Rey
@sjsrey
Yes on the LIMA/tau code. And for the reference on Theta, see equation (8) here
Wei Kang
@weikang9009
OK!
Sergio Rey
@sjsrey
I think the pysal/giddy#16 now conflicts with your corrections, but you can see the fix for links and just add them to a new pr (you can close but not merge my conflicting PR)
Wei Kang
@weikang9009
Right. I'll submit a pr shortly.
Sergio Rey
@sjsrey
also note there were other changes in the README beside the links
Wei Kang
@weikang9009
I can see the "Note" on pypi and some format issue. Is that all?
Sergio Rey
@sjsrey
yup
Wei Kang
@weikang9009
Just submitted a pr to update README.md
Sergio Rey
@sjsrey
hey Wei i’m seeing errors in giddy when i test: as components.py is using pysal. did you change this?
Wei Kang
@weikang9009
Do you refer to line 1080 in markov.py?
I think we might have missed it and the unit tests did not catch it as there is not one for the method "spillover". The error was caught by doctest. I've corrected in the newly submitted PR.
Sergio Rey
@sjsrey
I fixed it, just wanted to make sure you didn’t have changes before.
Wei Kang
@weikang9009
I've included the change in the PR. Should I revert it?
Sergio Rey
@sjsrey
just close (don’t merge the pr)
hang on. i have one error left in markov.py due to using pysal.region
is that the one you fixed
Wei Kang
@weikang9009
Yes. I think so.
Sergio Rey
@sjsrey
ok. I’ll just copy your changes over to what i have from today and make sure all the tests pass. just leave your pr open for now.
Wei Kang
@weikang9009
OK!
Wei Kang
@weikang9009
Very slow right now!
Sergio Rey
@sjsrey
Pr is being updated for the description
Wei Kang
@weikang9009

There seems to be a problem with the notebook "Rose". When I try to open it locally, the following message shows:

Unreadable Notebook: /Users/weikang/Dropbox (ASU)/python_repos/pysal-refactor/giddy/notebooks/Rose.ipynb NotJSONError('Notebook does not appear to be JSON: u\'{\\n "cells": [\\n {\\n "cell_type": "...',)

It also won't be loaded in your github repo

Sergio Rey
@sjsrey
Rose can be deleted as the functionality is in the directional notebook
Wei Kang
@weikang9009
OK
Wei Kang
@weikang9009
Hi Serge, I was trying to test the release of giddy on the testing site, but was constantly running into the error:
Collecting esda (from giddy) Could not find a version that satisfies the requirement esda (from giddy) (from versions: ) No matching distribution found for esda (from giddy)
though the other dependency mapclassify can be successfully installed.
I wonder whether you had this issue when you released esda (libpysal is a dependency and I imagine the situation should be similar).
Sergio Rey
@sjsrey
@weikang9009 when you tested the installer for giddy did you test on python 2 and python 3?
Wei Kang
@weikang9009
I only tested on python 2. Sorry. Is there a problem on python 3?
Sergio Rey
@sjsrey
If the setup file says it runs on 3, it should be tested for that.
Wei Kang
@weikang9009
OK. Will do!
Wei Kang
@weikang9009
I found some within-package import problems of giddy when testing it on python 3. pysal/giddy#21 resolves the problems.
Sergio Rey
@sjsrey
great. will get to it after i finish a release of libpysal
Wei Kang
@weikang9009
Hi @sjsrey, I've just noticed that you released libpysal 3.0.1. Installing and importing the current released version of giddy (1.0.0) in python 2.7 turns out successful even if shapely is not pre-installed. Thanks! However, this version of giddy has import issues (these issues were resolved in pysal/giddy#21) in python 3x. I am wondering how to proceed next. Release another version of giddy with the import issues resolved?
Sergio Rey
@sjsrey
@weikang9009 release early and release often ;->
Wei Kang
@weikang9009

Hi @sjsrey , I did some testing on the 2to3 conversion issue of print(we talked about it yesterday). For the distribution giddy-1.0.1.tar.gz with the python2 print statement print warn, the following error popped up when I tried to import giddy after pip install giddy-1.0.1.tar.gz in a python 3.6 environment:

In [1]: import giddy
  File "/Users/weikang/anaconda/envs/py3/lib/python3.6/site-packages/giddy/components.py", line 126
    print warn
             ^
SyntaxError: Missing parentheses in call to 'print'

I also tested on whether build_py_2to3 can be successfully imported as you suggested. As is shown below, build_py_2to3 could be successfully imported in the current python 3.6 environment:

In [2]: from distutils.command.build_py import build_py_2to3 as build_py

In [3]: from distutils.command.build_py import build_py_2to3

In [4]: build_py == build_py_2to3
Out[4]: True

It appears that build_py_2to3 failed to work on the print statement. However, I am not sure whether it was just me not operating in the right way, or it was my computer's problem because I could not find any complaints about this issue on the Internet.

Wei Kang
@weikang9009
Hi Serge, I've just uploaded the latest version of pysal website to the github repo.
Levi John Wolf
@ljwolf
Levi John Wolf
@ljwolf
didn't expect this to be the "right" instance of the nonlocal statement
Levi John Wolf
@ljwolf
Wei Kang
@weikang9009
Sergio Rey
@sjsrey
@weikang9009 nicely done on giddy
Levi John Wolf
@ljwolf
great!