Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 09 14:18
    weikang9009 closed #175
  • Sep 09 03:59
    romass12 commented #175
  • Sep 07 14:27
    weikang9009 commented #175
  • Sep 07 14:27
    weikang9009 commented #175
  • Sep 07 14:26
    weikang9009 commented #175
  • Sep 07 06:47
    romass12 commented #175
  • Sep 07 03:43
    romass12 commented #175
  • Sep 06 15:31
    weikang9009 commented #175
  • Sep 06 05:52
    romass12 edited #175
  • Sep 06 05:51
    romass12 edited #175
  • Sep 06 05:51
    romass12 edited #175
  • Sep 06 05:51
    romass12 edited #175
  • Sep 06 05:51
    romass12 opened #175
  • Apr 01 18:07
    sjsrey synchronize #171
  • Apr 01 17:58

    sjsrey on master

    blacken repo update CI envs -36 +39,310 update unittests worklfow and 9 more (compare)

  • Apr 01 17:58
    sjsrey closed #173
  • Apr 01 17:58
    sjsrey commented #173
  • Apr 01 17:47
    sjsrey synchronize #171
  • Apr 01 17:43
    sjsrey synchronize #171
  • Mar 23 08:50
    martinfleis commented #173
Sergio Rey
@sjsrey
ok. I’ll just copy your changes over to what i have from today and make sure all the tests pass. just leave your pr open for now.
Wei Kang
@weikang9009
OK!
Wei Kang
@weikang9009
Very slow right now!
Sergio Rey
@sjsrey
Pr is being updated for the description
Wei Kang
@weikang9009

There seems to be a problem with the notebook "Rose". When I try to open it locally, the following message shows:

Unreadable Notebook: /Users/weikang/Dropbox (ASU)/python_repos/pysal-refactor/giddy/notebooks/Rose.ipynb NotJSONError('Notebook does not appear to be JSON: u\'{\\n "cells": [\\n {\\n "cell_type": "...',)

It also won't be loaded in your github repo

Sergio Rey
@sjsrey
Rose can be deleted as the functionality is in the directional notebook
Wei Kang
@weikang9009
OK
Wei Kang
@weikang9009
Hi Serge, I was trying to test the release of giddy on the testing site, but was constantly running into the error:
Collecting esda (from giddy) Could not find a version that satisfies the requirement esda (from giddy) (from versions: ) No matching distribution found for esda (from giddy)
though the other dependency mapclassify can be successfully installed.
I wonder whether you had this issue when you released esda (libpysal is a dependency and I imagine the situation should be similar).
Sergio Rey
@sjsrey
@weikang9009 when you tested the installer for giddy did you test on python 2 and python 3?
Wei Kang
@weikang9009
I only tested on python 2. Sorry. Is there a problem on python 3?
Sergio Rey
@sjsrey
If the setup file says it runs on 3, it should be tested for that.
Wei Kang
@weikang9009
OK. Will do!
Wei Kang
@weikang9009
I found some within-package import problems of giddy when testing it on python 3. pysal/giddy#21 resolves the problems.
Sergio Rey
@sjsrey
great. will get to it after i finish a release of libpysal
Wei Kang
@weikang9009
Hi @sjsrey, I've just noticed that you released libpysal 3.0.1. Installing and importing the current released version of giddy (1.0.0) in python 2.7 turns out successful even if shapely is not pre-installed. Thanks! However, this version of giddy has import issues (these issues were resolved in pysal/giddy#21) in python 3x. I am wondering how to proceed next. Release another version of giddy with the import issues resolved?
Sergio Rey
@sjsrey
@weikang9009 release early and release often ;->
Wei Kang
@weikang9009

Hi @sjsrey , I did some testing on the 2to3 conversion issue of print(we talked about it yesterday). For the distribution giddy-1.0.1.tar.gz with the python2 print statement print warn, the following error popped up when I tried to import giddy after pip install giddy-1.0.1.tar.gz in a python 3.6 environment:

In [1]: import giddy
  File "/Users/weikang/anaconda/envs/py3/lib/python3.6/site-packages/giddy/components.py", line 126
    print warn
             ^
SyntaxError: Missing parentheses in call to 'print'

I also tested on whether build_py_2to3 can be successfully imported as you suggested. As is shown below, build_py_2to3 could be successfully imported in the current python 3.6 environment:

In [2]: from distutils.command.build_py import build_py_2to3 as build_py

In [3]: from distutils.command.build_py import build_py_2to3

In [4]: build_py == build_py_2to3
Out[4]: True

It appears that build_py_2to3 failed to work on the print statement. However, I am not sure whether it was just me not operating in the right way, or it was my computer's problem because I could not find any complaints about this issue on the Internet.

Wei Kang
@weikang9009
Hi Serge, I've just uploaded the latest version of pysal website to the github repo.
Levi John Wolf
@ljwolf
Levi John Wolf
@ljwolf
didn't expect this to be the "right" instance of the nonlocal statement
Levi John Wolf
@ljwolf
Wei Kang
@weikang9009
Sergio Rey
@sjsrey
@weikang9009 nicely done on giddy
Levi John Wolf
@ljwolf
great!