Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 16 11:15
    martinfleis commented #138
  • Nov 16 11:11
    martinfleis commented #146
  • Nov 15 18:14
    ivandorte opened #146
  • Oct 01 16:13
    martinfleis commented #142
  • Sep 27 08:59
    martinfleis closed #139
  • Sep 27 08:58

    martinfleis on main

    [BUG] set viz defaults for Line… (compare)

  • Sep 27 08:58
    martinfleis closed #140
  • Sep 27 08:58
    martinfleis commented #140
  • Sep 27 08:58
    slumnitz labeled #145
  • Sep 27 08:58
    slumnitz labeled #145
  • Sep 27 08:58
    slumnitz labeled #145
  • Sep 27 08:57
    slumnitz opened #145
  • Sep 27 08:55
    martinfleis commented #142
  • Sep 27 08:54
    slumnitz commented #140
  • Sep 27 08:51
    slumnitz commented #142
  • Sep 12 15:39
    jGaboardi commented #142
  • Sep 12 14:30
    martinfleis commented #142
  • Sep 12 14:10
    martinfleis commented #142
  • Sep 12 14:09
    jGaboardi closed #144
  • Sep 12 14:09
    jGaboardi commented #144
Sergio Rey
@sjsrey
I got a stub of splot up and working https://github.com/pysal/splot
Need to work on infrastructure (testing, travis) but the notebooks are working for now.
Levi John Wolf
@ljwolf
sweet! did we ever get notebook unittesting working?
Sergio Rey
@sjsrey
don't think so. we do have the poor man's https://github.com/pysal/splot/blob/dev/notebooks/Makefile
Wei Kang
@weikang9009
I am wondering if it is possible to add a legend for a map from plot_choropleth with unique_values specified. It could be more informative to visualize regional schemes with legends indicating the names (or indices) of regions.
Dani Arribas-Bel
@darribas
I'm looking into an issue in the bokeh backend where the columns end up with different lengths (suspect has to do with multipart polygons. If I manage to make any progress, where/how should I push changes back?
this is all in geoplot(backend='bk')
Dani Arribas-Bel
@darribas
Screen Shot 2017-06-01 at 13.38.26.png
this is one problem with holes
that's the polygon for future reference
Sergio Rey
@sjsrey
@darribas any changes you make on this should probably go in splot and libpysal - we can back port them to legacy pysal if needed.
Dani Arribas-Bel
@darribas
OK cool... excuse my complete ignorance: then I issue a PR into splot right? OK, now complete ignorance: a) is splot Python 3 first? b) how can I get a working version of the new modular pysal? Is is documented somewhere or pip will just do it?
Sergio Rey
@sjsrey
Yes on the PR. We were going to discuss Python 3 only tomorrow at the dev meeting but the devs I’ve talked with so far are leaning tht way. As for the modular PySAL, give pip a try and it should pull down any packages you need for splot. We are working on the meta package to pull everything down (ala the old pysal api) but that isn’t ready for prime time yet.
Dani Arribas-Bel
@darribas
OK cool, while doing this I've run into a Python 2to3 difference (iteritems Vs items in ordereddict's) but it's not a big deal, that can wait
I'll try to put in the PR
Sergio Rey
@sjsrey
An alternative setup I use for dev on the new pysal is to just clone each of the packages at the same level. Then a simple bash script to amend the PYTHONPATH to point to those directories and I’m good to go.
Dani Arribas-Bel
@darribas
right, I was thinking something along those lines
Sergio Rey
@sjsrey
bashscript looks something like:
export PYTHONPATH=$PYTHONPATH:$PWD/libpysal
export PYTHONPATH=$PYTHONPATH:$PWD/mapclassify
export PYTHONPATH=$PYTHONPATH:$PWD/esda
export PYTHONPATH=$PYTHONPATH:$PWD/giddy
export PYTHONPATH=$PYTHONPATH:$PWD/splot
export PYTHONPATH=$PYTHONPATH:$PWD/pointpats
for now all of those are python 2 so i don’t run 2to3 locally.
no doubt there is a cleaner way to build up PYTHONPATH ;->
Sergio Rey
@sjsrey
@weikang9009 i think a pr to add a legend to plot_choropleth would be most certainly welcomed.
Dani Arribas-Bel
@darribas
PR into splot/dev or open a new branch there?
Sergio Rey
@sjsrey
Dev
Dani Arribas-Bel
@darribas
RnR! pysal/splot#3