this is the core core of it
but they're called in LIFO order iirc
it's in the docs i think
we've talked about an iterator style caller
there's an issue i think with a draft PR
might be near what you're after
that needs some effort / push from others i think
ahh that's what it is
an instance doesn't have a
.__name__
so it's
id() is used
we could change this if you really want it
err wait
no then you couldn't have multiple instances
so i think the key would be that you have to not pass an instance for that to work
i'm not sure multiple instances is a good thing anyway
but that's a deeper discussion to have
if you don't pass an instance, and define your methods as
staticmethods or classmethod i think it should work the way you want
oh, is that a supported thing? (you're saying
plugin_manager.register(MyPlugin) instead of plugin_manager.register(MyPlugin())?)
1 reply
heh, inteeresting
bc instances can't share the same name or you'd have plugin collisions per name obvs
instances are kind of wacky for this use case to some degree anyway
how often are you really making a plugin that get's instantiated with diff seed data or wtv
i've always thought that support is a little, superfluous
it's been there from the beginning though
i guess the idea is supportingn meta-classes for that case is worse
so yeah, i'd say if you want what you're asking you probably should already have to have a name registry going on for your instances
if you want the class name, then just
`.register(obj, name=obj.__class__.__name__)
gack
frickin md
.register(obj, obj.__class__.__name__)
and / or make your own name mapping func for your input object set
with that there should def be no causality dilemma
but yeah the way it is by default makes sense, since ow you get collisions / over-writes per object instance
at least hopefully i'm not confabulating
hmm maybe we removed that actually?
either way as long as your instances are singletons you should be able to do what i showed ^
ya... i dont have a registry w names but i kinda just realized that i may want one (because it would allow me to prevent one plugin from raising another plugin's registered check). not too sure about how i'm doing it now anyways because it's in a arbitrary class (as opposed to something aware of the plugin system)
class Check:
IDs: Dict[str, List[Any]]
def __init__(self, *ids: str):
for id_ in ids:
if id_ not in self.IDs:
raise Exception("not registered")
...
@classmethod
def register(cls, registrant: Any, ids: List[str]):
for id_ in ids:
if id_ in cls.IDs:
raise Exception("already registered")
else:
cls.IDs[id_] = registrantthinking i might move this to my config object (which has the plugin_manager as an attr) so as to be more plugin-aware
yeah so i can't find any examples of non-instances in tests:
https://github.com/pytest-dev/pluggy/search?q=.register%28
https://github.com/pytest-dev/pluggy/search?q=.register%28
but i do recall having used it, and eyeballing the code there's no reason it won't work.
i'm pretty sure methods should just work as well you'll just get the
self being a class ref
but i think that's just python types
that is the symmetry of the
self stuff iirc
[nav] In [7]: class C:
...: @classmethod
...: def meth(cls):
...: print(cls)
[nav] In [8]: C.meth()
<class '__main__.C'>