so it's tricky to change it
I'm thinking something like:
def decode_raw(self, data: bytes) -> List[HeaderTuple]:
...
if not typing.TYPE_CHECKING:
def decode(self, data, bytes):
return [_unicode_if_needed(h, raw) for h in self.decode_raw()]
`
then everyone can use .decode_raw and always get bytesy HeaderTuples
inside hpack it's always bytes
then if you don't use type checking you can do .decode(raw=False) and get back a HeaderTuple with str's in
Ideally it would be
@attr.frozen but it needs to subclass tuple
@sethmlarson would you mind adding me on pypi to https://pypi.org/project/rfc3986/ ?
I'd like to help out https://github.com/python-hyper/rfc3986/pull/75#issuecomment-833468087 and cut a release.
I'd like to help out https://github.com/python-hyper/rfc3986/pull/75#issuecomment-833468087 and cut a release.
Thanks for the ping
Hi everyone.
FYI this is unfinished, but I wrote hpack implementation using nghttp2: https://github.com/dalf/hpack_nghttp2
It uses cython because the nghttp2 API has issue (it doesn't support the sensitive flag for example).
FYI this is unfinished, but I wrote hpack implementation using nghttp2: https://github.com/dalf/hpack_nghttp2
It uses cython because the nghttp2 API has issue (it doesn't support the sensitive flag for example).
I'm planning to cut a major release of https://github.com/python-hyper/priority in the next weeks - and since the last release is over 4 years ago, I'm wondering if anyone is actively using it or knows of major dependents that we should talk to before bumping from v1 to v2? No major API changes, mostly Python versions, typing with mypy, and minor bugfixes.
https://gitlab.com/pgjones/hypercorn/-/blob/master/pyproject.toml#L35 missing filterwarnings=error and pytest-asyncio doesn't set the asyncio exception_handler pytest-dev/pytest-asyncio#205
@Kriechi
anyio's pytest plugin does set this hook so you'll get test failures if you leak exceptions
@graingert:matrix.org are you good with python-hyper/priority#145 ?
this should give full type hinting for the priority package - and I can cut a release in the next days.
this should give full type hinting for the priority package - and I can cut a release in the next days.
You should install pytest in the mypy virtual environment
Typing for h11 python-hyper/h11#135
Can allow for some mypyc testing :).
Any better ideas for the Sentinels? I'd like to switch to Enums, but I there is a comment for the sentinels that
Can allow for some mypyc testing :).
Any better ideas for the Sentinels? I'd like to switch to Enums, but I there is a comment for the sentinels that
type(NEED_DATA) is NEED_DATA which I don't think is possible for Enum values.
1 reply
that seems like an odd property to require - is that really just used for
isinstance(v, NEED_DATA) ?
I had a mess around in sourcegraph but it didn't help :( https://sourcegraph.com/github.com/python-hyper/h11@f643a8e6e6a3e69ff803048e6fb33dfcdc244ac3/-/blob/h11/_state.py?L146:1#tab=references
Like put an enum in
if TYPE_CHECKING and the current code in the else?
It's definitely a wild bit of code, but it is part of the documented public API, and it's totally fine and legal python code – the only problem is a limitation in the type checkers
So my impulse is to restrict any compatibility breakage to folks using type checkers
Eg you could use @override and NewType to make a new type for each literal to make_sentinel
And then assign the module fields with
_SentinelClient = NewType("_SentinelClient", Sentinel)
CLIENT: Final[_SentinelClient] = create_sentinel("CLIENT")
But swapping them for auto() Enum members in a breaking release seems prudent
Actually yeah scratch that, why not build all the sentinels as class declaration literals?
class CLIENT(Sentinel):
pass
CLIENT.__class__ = CLIENT
@njsmith: @pgjones this seems like what you want: https://mypy-play.net/?mypy=latest&python=3.10&gist=3d5776059296c949ab88b948daa1115d
from typing import TypeVar, Type, Tuple, Any, Dict
_T_Sentinel = TypeVar("_T_Sentinel", bound="Sentinel")
class Sentinel(type):
def __new__(
cls: Type[_T_Sentinel],
name: str,
bases: Tuple[type, ...],
namespace: Dict[str, Any],
**kwds: Any
) -> _T_Sentinel:
assert bases == (Sentinel, )
return super().__new__(cls, name, bases, namespace, **kwds)
def __repr__(self) -> str:
return self.__name__
def __init_subclass__(cls: "Type[Sentinel]", **kwargs: Dict[str, Any]) -> None:
super().__init_subclass__(**kwargs) # type: ignore
cls.__class__ = cls # type: ignore
class CLIENT(Sentinel, metaclass=Sentinel):
pass
I think that works the best - it enforces that you write
class CLIENT(Sentinel, metaclass=Sentinel): ...
from typing import TypeVar, Type, Tuple, Any, Dict
_T_Sentinel = TypeVar("_T_Sentinel", bound="Sentinel")
class Sentinel(type):
def __new__(
cls: Type[_T_Sentinel],
name: str,
bases: Tuple[type, ...],
namespace: Dict[str, Any],
**kwds: Any
) -> _T_Sentinel:
assert bases == (Sentinel, )
v = super().__new__(cls, name, bases, namespace, **kwds)
v.__class__ = v # type: ignore
return v
def __repr__(self) -> str:
return self.__name__
class CLIENT(Sentinel, metaclass=Sentinel):
pass
Hello,
I'd like to merge python-hyper/h11#135 (typing) and python-hyper/h11#138 (python version support) early this week in preparation for a release later this week. Could you comment/review as desired?
I'd like to merge python-hyper/h11#135 (typing) and python-hyper/h11#138 (python version support) early this week in preparation for a release later this week. Could you comment/review as desired?