by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Phil Jones
    @pgjones
    Not sure they all need to do the same thing, but I thought it would be good to check views.
    Thomas Kriechbaumer
    @Kriechi
    yeah - its 2020 - about time to get rid of py2 :D
    Nathaniel J. Smith
    @njsmith
    I guess the reasons h11 hasn't decided about dropping py2 yet are in this thread: https://github.com/python-trio/hip/issues/147#issuecomment-555705601
    Thomas Kriechbaumer
    @Kriechi
    :point_up: February 15, 2020 4:54 PM @pgjones ping?
    Phil Jones
    @pgjones
    I think we go for it. Unlike h11 I don't think h2 has any Py2 legacy needs - also unlike h11 I don't think we want to maintain Py2
    Thomas Kriechbaumer
    @Kriechi
    @Lukasa would you mind giving me and @pgjones ReadTheDocs for hyper-h2 access?
    I'm trying to troubleshoot python-hyper/hyper-h2#1216 but don't have access to the project admin page on RTD.
    Thomas Kriechbaumer
    @Kriechi
    @pgjones @Lukasa looks like https://python-hyper.org/ is broken
    Phil Jones
    @pgjones
    Don't think I have access to that
    Phil Jones
    @pgjones
    Might be slightly easier to decide here, but I think we should switch to src/package_name for all the projects. As prompted by the proposed wsproto change to swtich from src/wsproto to wsproto.
    I think this is a good argument for src.
    @Kriechi
    Also thanks for the unification effort :D
    Thomas Kriechbaumer
    @Kriechi
    I have no strong opinion either way :D
    I just took a majority decision from what we had in the python-hyper org so far (and personal projects)
    @pgjones whats weird though, the post you mentioned: out of the 4 random projects they give as example, none of them use a src folder (any more?)
    django, pandas, aiohttp, requests
    did they revert back? now I'm curios what is going on here
    Thomas Kriechbaumer
    @Kriechi
    @pgjones either way: I'll back-out the wsproto directory change of my PR so we can get it merged.
    Nathaniel J. Smith
    @njsmith
    I'm not a big fan of src/ layout just because it makes navigating the code more cumbersome
    It does give a workaround for some annoyances in other tools like pytest though, so I generally don't make a fuss about it either way
    And realistically I don't have time and focus to spend on the hyper projects so you shouldn't worry about my preferences anyway :-)
    Mostly just mentioning it to explain why not everyone agrees with Hynek's post
    Phil Jones
    @pgjones
    This, python-hyper/h11#99, looks good to me. I'll merge this evening/weekend unless anyone already has plans
    Thomas Kriechbaumer
    @Kriechi
    +1
    Thomas Kriechbaumer
    @Kriechi
    @pgjones do you want me to continue my unification efforts on the h11 project?
    Phil Jones
    @pgjones
    I'm for that, but I'll defer to @njsmith's view
    Thomas Kriechbaumer
    @Kriechi
    we are back in business! https://python-hyper.org/
    Phil Jones
    @pgjones
    :+1:
    Thomas Kriechbaumer
    @Kriechi
    ok - now we are looking real good! made a few updates, rectified a few broken links, integrated wsproto docs, bump sphinx, set up github push hook.
    Thomas Kriechbaumer
    @Kriechi
    @njsmith https://github.com/python-hyper/h11 in the right menu bar shows "v0.6.0" as latest release, even though there are more recent git tags. I think we are just mussing the GitHub release thingy: https://github.com/python-hyper/h11/releases
    ... I don't have rights to create them though...
    Nathaniel J. Smith
    @njsmith
    Huh, that's weird
    Apparently that release even has an sdist and wheel attached? I have no memory of making this, and it seems rather uncharacteristic
    Normally I don't do any of that stuff, because it seems like pointless busywork
    It's annoying that GitHub is posting wrong info though
    Thomas Kriechbaumer
    @Kriechi
    true - for the hyper project I just created a few of the missing ones.
    none of the other python-hyper org projects make use of the github projects (only plain git tags)
    I would recommend deleting all existing github release and just using git tags
    Nathaniel J. Smith
    @njsmith
    Maybe we can delete the special release metadata from that tag so GitHub won't show the misleading info
    Nathaniel J. Smith
    @njsmith
    I see a gui button labeled "delete" but I'm a bit nervous it might delete the underlying tag as well
    Thomas Kriechbaumer
    @Kriechi
    I have a local git copy - worst-case I just push again
    Thomas Kriechbaumer
    @Kriechi
    or you add the missing releases - also fine.
    Nathaniel J. Smith
    @njsmith
    Fair point :-)
    Ok I hit the button
    And the tag seems to have survived
    Thomas Kriechbaumer
    @Kriechi
    perfect - thanks!
    @njsmith any thoughts on the hyper-unification changes I have been pushing to almost all projects in the last days?
    h11 would also be on the list - if you think its a good effort?
    Nathaniel J. Smith
    @njsmith
    I haven't been following tbh
    What's involved?
    Thomas Kriechbaumer
    @Kriechi
    GitHub Actions instead of Travis
    dropping py27, only py36+
    general unification of various config files: tox.ini, setup.py, etc. to all be close to identical across python-hyper projects
    @njsmith python-hyper/hpack#259
    python-hyper/hyperframe#149
    python-hyper/hyper-h2#1232
    python-hyper/wsproto#145
    some things might be a bit opinionated - I fully admit that :D