if you look at the downloaded coverage files you can see that the line 30 of urllib3/init.py is actually not listed as covered.
Connection broken: IncompleteRead(0 bytes read)', IncompleteRead(0 bytes read)error from
requestswhich calls to urllib3. A crashlog can be found at https://pastebin.com/zXfGQc4S
requestsas a git submodule. Recently we had to update it and, since
requestsisn't vendoring its dependencies any more we had to include
idnaand one more thing in our submodules.
*pycfiles and we had to rearrange submodules to make sure that when a user runs
git pullit invalidates python's
requestswanted to be "clever".
requestsemits a warning when sourcing its
__init__.py, creating a terrible trace back that explodes in user's face, because the
chardetare newer than
requestsand just using
urllib3would be nice for the following reasons:
apt install python-pipis necessary for
pip, but then it also doesn't install
pipruns into some weird errors and users also need
apt install python-wheel. In general, linux distros ship
pipas a separate package and we were flooded with issue reports when users didn't have a working
@@ -212,11 +212,12 @@ def _Request( self, method, handler, data = None, params = None ): headers = self._ExtraHeaders( method, request_uri, data ) - response = requests.request( method, - request_uri, - headers = headers, - data = data, - params = params ) + if not PY2: + request_uri = ToUnicode( request_uri ) + response = urllib3.PoolManager().request( method, + request_uri, + headers = headers, + fields = data if data else params ) return response