Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 18:16

    hkollmann on cboulanger-patch-1

    (compare)

  • 18:16

    hkollmann on cboulanger-patch-2

    (compare)

  • 15:41
    johnspackman review_requested #9779
  • 15:41
    johnspackman review_requested #9779
  • 15:41
    johnspackman review_requested #9779
  • 15:41
    johnspackman review_requested #9779
  • 15:41
    johnspackman review_requested #9779
  • 15:41
    johnspackman opened #9779
  • 15:39
    johnspackman review_requested #9778
  • 15:39
    johnspackman review_requested #9778
  • 15:39
    johnspackman review_requested #9778
  • 15:39
    johnspackman review_requested #9778
  • 15:39
    johnspackman review_requested #9778
  • 15:39
    johnspackman opened #9778
  • Aug 21 19:53
    cboulanger commented #9709
  • Aug 21 19:53
    lucapivato commented #9709
  • Aug 21 19:49
    oetiker commented #9709
  • Aug 21 19:38

    hkollmann on master

    Json to ast (#552) * integrate… (compare)

  • Aug 21 19:38
    hkollmann closed #552
  • Aug 21 19:27
    johnspackman synchronize #552
Christian Boulanger
@cboulanger
Don't trust me on any of this, I am a complete Windows ignorant
Just guessing here...
rommni
@rommni
hum... same error
Christian Boulanger
@cboulanger
Our Windows expert is on his well-deserved holiday
rommni
@rommni
can't really help you i'm far to be an expert on Windows, i'm using it at work but i don't know how all things are going

the node_modules/.bin/qx.cmd contains:

@IF EXIST "%~dp0\bash.exe" (
  "%~dp0\bash.exe"  "%~dp0\..\@qooxdoo\compiler\qx" %*
) ELSE (
  @SETLOCAL
  @SET PATHEXT=%PATHEXT:;.JS;=;%
  bash  "%~dp0\..\@qooxdoo\compiler\qx" %*
)

Maybe it's this one which raise an error, but i don't know how it is generated, however in the old working version it's:

@IF EXIST "%~dp0\node.exe" (
  "%~dp0\node.exe"  "%~dp0\..\@qooxdoo\compiler\qx" %*
) ELSE (
  @SETLOCAL
  @SET PATHEXT=%PATHEXT:;.JS;=;%
  node  "%~dp0\..\@qooxdoo\compiler\qx" %*
)
rommni
@rommni
@cboulanger it works with you're previous change to node_modules/ @qooxdoo/compiler/qx, and copying the old version of node_modules/.bin/qx.cmd
Christian Boulanger
@cboulanger
maybe after replacing the first one, you need to npm install again?
I think the second one is auto-generated.
It that snippet works, I'll have a fix ready pretty quickly.
rommni
@rommni
i think too it's auto-generated, however i don't know how to test it, if i make a npm install just after modify the qx file nothing happened, even after deleted the .bin folder, if i make a npm install @qooxdoo/compiler, it creates again the .bin folder however it's installing qooxdoo again before and so overriding the change
maybe i will need to clone the compiler do the edit of qx localy, then pack the module in .tar and then load the module localy with npm... not even sure it will work, have you a better idea before i try this one?
hum you're way is working fine too ^^
Christian Boulanger
@cboulanger
just I moment, I hope I have an update to the compiler in minute which, if the solution given above works, should fix the issue.
rommni
@rommni
@cboulanger I tested locally with the branch you just push on the compiler and it seems to work great ;) thank you for the fix ;)
Christian Boulanger
@cboulanger
@rommni Thank you so much for doing this!
rommni
@rommni
np
Christian Boulanger
@cboulanger
@rommni NPM version is updated, can you try?
rommni
@rommni
@cboulanger seems to work without problem ;) thank you ;)
@adax thank you for reporting the problem on Windows first, this is solved in last version of compiler ;)
John Spackman
@johnspackman
@Tamerlanchiques I think so - it was written on v6, but I don’t think that there have been any major changes to tables between 5 and 6
Benjamin Fine
@jaminfine

Hey @cboulanger , I was wondering if you could help me out with trying to add eventrecorder to my app. I cloned the repo into my library folder, where my other libraries live. I also cloned in the qookery library for the qookery.ace dependency. I edited compile.json for my app to look similar to the example you gave. The relevant piece of compile.json:

"applications": [
    {
      "class": "guestnic.Application",
      "theme": "guestnic.theme.Theme",
      "name": "script",
      "bootPath": "./boot",
      "include": [
        "cboulanger.eventrecorder.UiController",
        "cboulanger.eventrecorder.ObjectIdGenerator",
        "cboulanger.eventrecorder.ObjectIdTooltip",
        "qookery.ace.*" // required for the UIController
      ],
      "environment": {
        "module.objectId": true, // required, the event recorder won't work without this setting
        "eventrecorder.enabled": true,
        "eventrecorder.mode": "presentation",
        "eventrecorder.autoplay": false
      }
    }
  ],
  "libraries": [
    "../library/qooxdoo.git/framework",
    "../library/uploadmgr.git",
    "../library/mlaif.git",
    "../library/eventrecorder.git",
    "../library/qookery.git/qookeryace",
    "."
  ],

On compilation attempt, I am seeing this message:

Cannot find path source/resource required by library qookery.ace
Error: Added missing library information from Manifest. Please restart the compilation.

Any ideas or help would be appreciated. Thanks in advance

Christian Boulanger
@cboulanger
You can ignore the first message. As to the seconde: doesn't it go away if you restart the compilation?
Benjamin Fine
@jaminfine
It doesn't. I've tried to compile several times
Christian Boulanger
@cboulanger
BTW no need to clone anything. You should let the compiler install the dependencies.
We actually discourage manually adding dependencies in compile.json, because they are much more difficult to maintain
Again:
You just need to execute qx pkg install cboulanger/eventrecorder, that will install all needed libraries automatically.
Benjamin Fine
@jaminfine
That's a good point. I will remove the cloned repos and try this the proper way
Christian Boulanger
@cboulanger
just to make your life easier...
the dependencies are then saved to qx-lock.json and to Manifest.json. If you do qx pkg install --save=0 cboulanger/eventrecorder, they will only be installed to qx-lock.json, which might be what you want, since the eventrecorder is not a real dependency of your app - think of it as a "devDependency" in the npm world.
Great to hear that you want to try out the evenrecorder. Once it runs, let me know if it is useful for you and what should be changed to make it even more useful. There's still a lot of room for improvement, to put it in mild terms :-)
Benjamin Fine
@jaminfine
I like that idea. The other option I was considering is to keep one branch as a testing branch and have it be a dependency there
Benjamin Fine
@jaminfine
Absolutely! I will make sure to give you feedback after playing around with it and doing some testing. Thank you for your help
Benjamin Fine
@jaminfine
@cboulanger To get things working properly, @derrell and I needed to create a 'window' decoration in our decoration theme file. It also automatically installed the apiviewer, widgetbrowser, and dialog libraries, which we manually removed. It seems these are for use with the demo, but not for use with existing applications.
Christian Boulanger
@cboulanger
"dialog" might be needed, I think, for some features of the eventrecorder to work… all others are just for the demo apps.
Derrell Lipman
@derrell
Recall that we have our own fork of dialog. Can't depend on upstream's one, as it overwrites the top-level namespace... But what is required from it?
All of those are in the eventrecorder Manifest.json, and shouldn't be I think. They should only be in the eventrecorder's demo's Manifest.json.
Christian Boulanger
@cboulanger
ah, here's a case where top-level namespaces become a problem - I need to move it to qxl.dialog, but that's another story entirely.
Derrell Lipman
@derrell
lol. Yup. But still, are you sure it's required of eventrecorder, and not just in the demo of eventrecorder?
Christian Boulanger
@cboulanger
It may work mostly without the dialog, but I remember there are some parts where the apps asks you to enter something - maybe your fork is a drop-in replacement here?
It's not using any forms, just prompt and confirm.
Derrell Lipman
@derrell
We haven't yet encountered any area where it's required. But yes, for prompt and confirm, maybe ours will drop in just fine. We've mostly modified Form.
But I do think that "contrib" dialog should have namespace qxl-dialog as we've discussed before.
Christian Boulanger
@cboulanger
But it's true that Iframe would be better in that case since namespaces wouldn't conflict
or rather than iframe: a separate native window, running the event recorder and passing messages to the application
Derrell Lipman
@derrell
Yeah, we'll see if we can make that work. It would be really cool to work it that way. Apparently, that's what TestCafe does.
Off for the night. Thanks again for the help!
Christian Boulanger
@cboulanger
true, Testcafe just has this bar on the bottom and the rest is in an iframe
You're welcome!