Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 14:01

    hkollmann on master

    Provision for updating a single… (compare)

  • 14:01
    hkollmann closed #10052
  • 13:11
    rad-pat synchronize #10052
  • 12:12
    level420 synchronize #9836
  • 10:07
    level420 commented #10052
  • 10:06

    level420 on master

    Increase performance of Boolean… (compare)

  • 10:06
    level420 closed #10051
  • 10:06
    level420 commented #10051
  • 09:26
    level420 commented #10051
  • 09:05
    hkollmann commented #10051
  • 08:45
    rad-pat review_requested #10052
  • 08:45
    rad-pat synchronize #10052
  • 08:28
    rad-pat commented #10051
  • 08:14
    hkollmann commented #10051
  • Sep 30 15:05
    rad-pat synchronize #10051
  • Sep 30 15:02
    cboulanger commented #10048
  • Sep 30 15:01
    derrell commented #10048
  • Sep 30 14:57
    alex5555 commented #10048
  • Sep 30 14:57
    alex5555 commented #10048
  • Sep 30 14:56
    alex5555 commented #10048
Henner Kollmann
@hkollmann
No ie11 is fully supported. Pr is welcome
Andriy Syrovenko
@andriy-s
OK, I already have a patch, will submit PR in a couple of minutes.
Andriy Syrovenko
@andriy-s
Done
Oleg Philippov
@ofilippov
Hi, looks like current version of qx compiler doesn't fully support svg images from resources. As far as I see if we add ".svg" in line 31 of ImageLoader class (https://github.com/qooxdoo/qooxdoo-compiler/blob/master/source/class/qx/tool/compiler/resources/ImageLoader.js) then everything starts to work - svg images will have width and height. I found an old bug (https://github.com/qooxdoo/qooxdoo-compiler/issues/117) which was strangely closed without any explanation. So, may be I am missing something.
Christian Boulanger
@cboulanger
@ofilippov Can you reopen the issue, adding the above? (The issue was closed since the original author did not answer our request for feedback).
Oleg Philippov
@ofilippov
@cboulanger I've added my comment there, but I cannot re-open it as I'm not the one who created it and I'm not a collaborator :)
Thanks!
Christian Boulanger
@cboulanger
@ofilippov Would you create a Pull Request that references the issue -should be an easy fix!
Derrell Lipman
@derrell
@ofilippov It looks like @cboulanger beat me to it, reopening that issue. It's reopened now.
Oleg Philippov
@ofilippov
@cboulanger here it is qooxdoo/qooxdoo-compiler#684
Christian Boulanger
@cboulanger
@ofilippov Thank you - looks good to me, let's see what @johnspackman says!
Oleg Philippov
@ofilippov
Thanks a lot!
Aleksandar Josipovic
@nanexo

hi, I'm having a bit of a problem with source maps in combination with the build target source and bundles.
config for the target:

"type": "source",
"outputPath": "compiled/source",
"bundle": {
    "include": "qx.*"
}

The problem I'm running into is that the sources in the source maps are absolute. Are they supposed to be absolute? And can I change that (via path-mappings perhaps)? There is a similar issue qooxdoo/qooxdoo-compiler#669 that got fixed recently, but I think that one only affected deploy builds..

Aleksandar Josipovic
@nanexo
I should add the the sources of the bundles (in this case the qx library) have absolute paths
Henner Kollmann
@hkollmann
Which compiler version do you use? This should be changed with qooxdoo/qooxdoo-compiler#672
Aleksandar Josipovic
@nanexo
I'm on 1.0.0-beta.20200512-2000
Dietrich Streifert
@level420
I'm currently investigating on how translation is handled with the compiler. I have the translation files under myapp/source/translation named de.po and en.poand have defined "locales": ["en","de"] in compile.json. I 've tried qx compile --locale=en or qx compile --locale=de but this doesn't seem to work.
Christian Boulanger
@cboulanger
@level420 It is not automatic. You need to add --update-po-files / -u
Dietrich Streifert
@level420
@cboulanger will try that. thank you.
Christian Boulanger
@cboulanger
There are two bugs open concerning this: qooxdoo/qooxdoo-compiler#618 and qooxdoo/qooxdoo-compiler#158
If I remember our discussions correctly, we haven't come to a conclusion what the default behavior should be because the specs for .po files make a sensible solution difficult - following the specs results in many useless source code changes because of the changing line numbers.
Dietrich Streifert
@level420

How are libraries handled? I've defined in compile.json:

  "libraries": [ 
    "../mylibrary", 
    "." ]

where classes exist which also have this.trentries. should those entries also appear in the *.po files of the app?

Christian Boulanger
@cboulanger
This is another open bug :smile: qooxdoo/qooxdoo-compiler#175
Dietrich Streifert
@level420
:bug:
Christian Boulanger
@cboulanger
Please add your voice there and, if possible, provide a solution :smirk:
Christian Boulanger
@cboulanger
@/all :exclamation: :exclamation: :exclamation: Please do not update the NPM packages for a moment, we have a regression. We'll fix it ASAP and let you know when it is safe to update again.
Christian Boulanger
@cboulanger
We're back! http://qooxdoo.org/status/ It should be safe to upgrade now. If you experience anything out of the ordinary, let us know.
Pat Buxton
@rad-pat
Is there a place to provide feedback about the new website? I had a quick search in here but only found an github issue to provide feedback on the docs.
Tobias Oetiker
@oetiker
you can open an issue here https://github.com/qooxdoo/qooxdoo.github.io/ as this is where the website lives ... or you can discuss here if it is not just a bug ... you can also create a PR if you have something to fix (outside of the documentation)
Pat Buxton
@rad-pat
I'm happy to discuss it here. I just found it a little annoying to have to scroll to the bottom of the home page to get to the links for demo / playground / widget browser. There are drop down menus for the Documentation and the Community an the top of the page so it would seem sense to add some menu/links to get to these other resources without having to scroll to the bottom
John Spackman
@johnspackman
:+1:
please can issues for the website go here: https://github.com/qooxdoo/website
tat’s the source which is compiled into the qooxdoo.github.io repo
Pat Buxton
@rad-pat
I'll add my comment as an issue there
Oleg Philippov
@ofilippov
Hi,
As far as I can see qooxdoo now replace native Array methods with polyfills. It happens cause qx.lang.normalize.Array defer function is executed before qx.bom.client.EcmaScript - and even before environment properties initiation.
It can make a problem cause some methods from qx.lang.normalize.Array have different behavior from native ones (for example "forEach" method skips undefined values from array while native forEach processes it)
We don't have this problem in 5.0.2 qooxdoo
Just open https://qooxdoo.org/qxl.apiviewer/ and type in devtools console something like [].forEach to see that the native method was replaced with polyfill
Derrell Lipman
@derrell
@ofilippov Would you please create an issue on http://github.com/qooxdoo/qooxdoo-compiler ? That sounds like the order of processing is incorrect. Polyfills shouldn't be used if not needed.
Oleg Philippov
@ofilippov
shawnli88
@shawnli88
@cboulanger thanks a lot for you, the qxl.demobrowser can be compiled normally . 👍
Derrell Lipman
@derrell
Thanks @ofilippov
Christian Boulanger
@cboulanger
@shawnli88 credit where credit is due: @hkollmann has been the main force behind porting the demobrowser and other qooxdoo apps to the new compiler infrastructure.... :-)
Dietrich Streifert
@level420
when running the compiler with qx compile --watch --write-all-translations is it supposed to detect changes in the *.po files?
John Spackman
@johnspackman
yes, i would have said so … please can you add an issue for it
Oleg Philippov
@ofilippov
When I run "qx test" it writes at the end "writing coverage information ..." Do you know where I can get this data? Thanks.
As far as I see testtapper sends it to puppeteer-to-istanbul... But what happens after that?
Oleg Philippov
@ofilippov
found :)
npx nyc report --reporter=cobertura
hcarsten
@hcarsten
I am looking to have a button with rounded borders. So I created a decorator, set the borderRadius and background (to "transparent"). After assigning the decorator the button does not have the hover handling anymore ?
Tobias Oetiker
@oetiker
this is because the decorators normally get switched dynamically based on the appearance