Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 26 13:49
    hkollmann commented #10407
  • May 25 15:17
    oetiker edited #10407
  • May 25 15:14
    oetiker edited #10407
  • May 25 15:14
    oetiker edited #10407
  • May 25 15:14
    oetiker opened #10407
  • May 25 14:06
    hkollmann review_requested #10406
  • May 25 14:06
    hkollmann review_requested #10406
  • May 25 14:06
    hkollmann review_requested #10406
  • May 25 14:06
    hkollmann review_requested #10406
  • May 25 14:06
    hkollmann review_requested #10406
  • May 25 14:06
    hkollmann review_requested #10406
  • May 25 14:06
    hkollmann opened #10406
  • May 25 14:06

    hkollmann on es6ify

    run es6ify again with latest bu… (compare)

  • May 25 14:04

    hkollmann on master

    fix: tangible theme table-edito… (compare)

  • May 25 14:04
    hkollmann closed #10403
  • May 25 14:04
    hkollmann commented #10403
  • May 25 12:35
    hkollmann review_requested #10405
  • May 25 12:35
    hkollmann review_requested #10405
  • May 25 12:35
    hkollmann review_requested #10405
  • May 25 12:35
    hkollmann review_requested #10405
Derrell Lipman
@derrell
test my changes
or validate the schema?
John Spackman
@johnspackman
i think just running the compiler, when it loads the schema it will validate the schema changes
Derrell Lipman
@derrell
ok, I'll test and then push if no errors detected. Thanks
although it never flagged an error when I had localModules in the compile.json without changing the schema...
Derrell Lipman
@derrell
pushed. No errors.
Tobias Oetiker
@oetiker
i think schema validation is probably not active
or the property banning extra keys is missing
Derrell Lipman
@derrell

I've followed up a bit on why schema validation wasn't working. There are a few issues. Firstly, the correct property banning extra keys was missing, and an obsolete one was in its place. Secondly, with the correct property there, it tries to use better-ajv-errors but it was not properly required, so crashed when trying to generate the error. Those two problems are fixed with this patch:

Unstaged changes (2)
modified   source/class/qx/tool/utils/Json.js
@@ -23,7 +23,7 @@
  * *********************************************************************** */

 const Ajv = require("ajv");
-const betterAjvErrors = require("better-ajv-errors");
+const betterAjvErrors = require("better-ajv-errors").default;
 const fs = qx.tool.utils.Promisify.fs;

 qx.Class.define("qx.tool.utils.Json", {
modified   source/resource/qx/tool/schema/compile-1-0-0.json
@@ -53,7 +53,7 @@
       "minItems": 1,
       "items": {
         "type": "object",
-        "additionalItems": false,
+        "additionalProperties": false,
         "required": [
           "class",
           "name"

The third problem is that validation is being done when running qx clean but not when running qx compile. I'm not sure where to look to fix that problem. I also know little about schema validation, so someone with more knowledge of it should check my work and apply a PR if appropriate.

Christian Boulanger
@cboulanger
If I remember correctly, I implemented the schema validation for config files, but it would take some time, which unfortunately I don't currently have, to look at it and reconstruct what I was trying to accomplish. I though it was a good idea back then but we've been disabling it (or not changing the schema version) because it had too many side effects. It could probably be fixed and used to good effect but I cannot do it right now, sorry ...
Derrell Lipman
@derrell
@johnspackman Do you know where in the compiler the validation gets invoked, i.e., it's invoked in qx clean but how do we invoke it in qx compile?
Derrell Lipman
@derrell
Disregard. See #10396
Pat Buxton
@rad-pat

With Qooxdoo 7, should image resources in a combined png/meta be retrieved from that combined image resource? I can some entries in the resource-db.json, but looking at qx.$$resources at runtime there isn't a reference to the combined image.

Here's a cut down version of the resource-db.json for the gb flag which is contained in a flags_combined.png

{  
  "resources": {  
    "plaid": {  
      "plaid/flags_combined.meta": {  
        "resourcePath": "resourcePath",  
        "meta": {  
          "plaid/icons/flags/gb.png": [  
            16,  
            11,  
            "png",  
            "plaid/flags_combined.png",  
            -1163,  
            0  
          ]  
        }  
      },  
      "plaid/flags_combined.png": {  
        "resourcePath": "resourcePath",  
        "width": 3748,  
        "height": 11  
      },  
      "plaid/icons/flags/gb.png": {  
        "resourcePath": "resourcePath",  
        "width": 16,  
        "height": 11  
      }  
    }  
  }  
}
1 reply
The images are loading, it's just that they don't appear to be coming from the combined image which they used to originally (qx 5)
NW Group
@nwgroup

I, we are using the last version of qooxdoo to migrate from 5.0.0 version. For now we are fine, but we find a problem with the translations of our main library. We use it in the next way:

"libraries": [
        "./qxnw.6.0/trunk",
        "."
    ],

In the compile.json and in that library we have the .po translations file. The problem is that we can't see that translations in our application as we have in the older version. Please help!!!!

NW Group
@nwgroup
The same happend with the translations in qooxdoo
Scott Knick
@sknick
Did you follow the guidance here?
Scott Knick
@sknick
Hmmm... Did a require("joe") but I'm getting: ERROR: could not locate require()d module: "jose"
Derrell Lipman
@derrell
@sknick What is your directory structure? Is node_modules at the same level as compile.json?
And is jose installed in node_modules?
The compiler doesn't install packages. They must already be npm installed
Scott Knick
@sknick
Ah.
Bizarre. Did npm install jose and then qx compile gave me this:
Failed: Error: Parsing file /home/sknick/<snipped>/node_modules/jose/dist/browser/index.js: 'import' and 'export' may only appear at the top level (2:0)
/home/sknick/<snipped>/node_modules/@qooxdoo/framework/lib/compiler/index.js:55029
              throw e;
This is the content of that index.js file:
export { compactDecrypt } from './jwe/compact/decrypt.js';
export { flattenedDecrypt } from './jwe/flattened/decrypt.js';
export { generalDecrypt } from './jwe/general/decrypt.js';
export { GeneralEncrypt } from './jwe/general/encrypt.js';
export { compactVerify } from './jws/compact/verify.js';
export { flattenedVerify } from './jws/flattened/verify.js';
export { generalVerify } from './jws/general/verify.js';
export { jwtVerify } from './jwt/verify.js';
export { jwtDecrypt } from './jwt/decrypt.js';
export { CompactEncrypt } from './jwe/compact/encrypt.js';
export { FlattenedEncrypt } from './jwe/flattened/encrypt.js';
export { CompactSign } from './jws/compact/sign.js';
export { FlattenedSign } from './jws/flattened/sign.js';
export { GeneralSign } from './jws/general/sign.js';
export { SignJWT } from './jwt/sign.js';
export { EncryptJWT } from './jwt/encrypt.js';
export { calculateJwkThumbprint } from './jwk/thumbprint.js';
export { EmbeddedJWK } from './jwk/embedded.js';
export { createLocalJWKSet } from './jwks/local.js';
export { createRemoteJWKSet } from './jwks/remote.js';
export { UnsecuredJWT } from './jwt/unsecured.js';
export { exportPKCS8, exportSPKI, exportJWK } from './key/export.js';
export { importSPKI, importPKCS8, importX509, importJWK } from './key/import.js';
export { decodeProtectedHeader } from './util/decode_protected_header.js';
export { decodeJwt } from './util/decode_jwt.js';
import * as errors_1 from './util/errors.js';
export { errors_1 as errors };
export { generateKeyPair } from './key/generate_key_pair.js';
export { generateSecret } from './key/generate_secret.js';
import * as base64url_1 from './util/base64url.js';
export { base64url_1 as base64url };
Scott Knick
@sknick
Decided to go with another library I didn't have to require(), but that error is weird.
Derrell Lipman
@derrell
I suspect there's a browserify option that would fix it. I'll look into it. It's bundling the required file and its imports. That may be the first time an ES6 module has been included. If I can figure anything out I'll let you know (even though you won't care since you're not using that library)
Scott Knick
@sknick
Thanks, Derrell.
Pat Buxton
@rad-pat
Does anyone know the history behind why source scripts are not loaded in parallel for Firefox? Source Link
If our app is compiled to source, Firefox can take minutes to load all the scripts, whereas Chrome will load the same in several seconds. The parallel load in Firefox can be forced with a query string param and the app seems to load fine, perhaps there was a problem with older versions of Firefox that maybe isn't the case now?
?qooxdoo:load-parallel=true
John Spackman
@johnspackman
Wow that’s old :) AFAICR, the problem is (or was?) that when you set scripts to load asynchronously, the code within them could be executed in a random order - ie if you load script A.js, B.js, and C.js, Firefox could execute the code as B, then C, then A, whereas Chrome will load everything and wait so that the code is A, then B, then C.
I think that it was considered a bug in Firefox at the time? It looks like IE11 was also affected.
Pat Buxton
@rad-pat
It seems that the Firefox & IE part were added only to the new compiler template. The old python generator just checked for the async attribute. QX6
I can't find any specific bug report about scripts loaded out of order in FF.
Should I file an issue for it? I guess if scripts could be loaded in parallel in FF then it would be preferred.
John Spackman
@johnspackman
it was in the generator too; I’ve found the original bug report: qooxdoo/qooxdoo#8946
the bug only happened in the debugger, and apparently was fixed in FF v43 ...
that was 7 years (!) ago so I’d say, yes - please file an issue (or a PR) to remove the test for firefox
Pat Buxton
@rad-pat
Sure, I'll make a PR
John Spackman
@johnspackman
:+1:
Henner Kollmann
@hkollmann
I just published @qooxdoo/framework 7.1.1 with the last fixes!
Tobias Oetiker
@oetiker
great!
Adrian Haarbach
@adrelino
Thanks! Another small issue I have now with the Tangible theme, when I double-click on a cell in a table http://qooxdoo.org/qxl.demobrowser/#table~Table.html using tangible Theme, the cell editor displays the content of the cell to be edited on top of the old value of the cell, which looks confusing. This does not happen in Modern theme. Anyone knows how to fix this quickly?
editor.png
Dmitry Zolotov
@goldim
Good evening qx team. I use qooxdoo v6.0.4 and found an annoying bug described here and solved for qooxdoo version 7: qooxdoo/qooxdoo#10365 . (removeRows doesn't work for prelast index). What should I do? Could you backport changes of this PR to 6 version too?
Derrell Lipman
@derrell
@goldim I'm not sure that we'll backport to an older version of qooxdoo, but you can apply the patch that fixed this problem: https://github.com/qooxdoo/qooxdoo/pull/10366/commits/1c1e2e560f3d469f02e8c37f261ac08032a1fa62
Dmitry Zolotov
@goldim
@derrell manually applied changes for 6.0.4 and problem gone. Not sure about full functionality. Probably tests could detect if something goes wrong. Maybe create new issue and tag it somehow for 6?
Dmitry Zolotov
@goldim
@derrell thx for the advice. Will create patch as short-term decision before fully going to version 7.
Derrell Lipman
@derrell
Sounds like a good plan @goldim.
Adrian Haarbach
@adrelino
editor.png
I just created a pull request #10403 which fixes this issue.
di
@dinislam1
I added a new file(class) in qooxdoo 5.0.2 but after source, source-all build I didn't see it. I typed that class in browser and it doesn't exist