Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 13 20:41
  • Aug 09 06:22

    ericblade on npm_and_yarn

    (compare)

  • Aug 09 06:22

    ericblade on master

    build(deps): bump terser from 4… Merge pull request #428 from er… (compare)

  • Aug 09 06:22
    ericblade closed #428
  • Jul 22 18:29
    ericblade commented #426
  • Jul 22 14:18
    Eric-Kosovec commented #426
  • Jul 22 03:02
    ericblade commented #426
  • Jul 21 01:46
    rollingversions[bot] commented #428
  • Jul 21 01:46
    dependabot[bot] labeled #428
  • Jul 21 01:46
    dependabot[bot] opened #428
  • Jul 21 01:46

    dependabot[bot] on npm_and_yarn

    build(deps): bump terser from 4… (compare)

  • Jul 21 00:18
    rollingversions[bot] commented #154
  • Jul 21 00:18
    dependabot[bot] labeled #154
  • Jul 21 00:18
    dependabot[bot] opened #154
  • Jul 21 00:18

    dependabot[bot] on npm_and_yarn

    build(deps): bump terser from 4… (compare)

  • Jul 20 15:02
    rollingversions[bot] commented #153
  • Jul 20 15:02
    dependabot[bot] labeled #153
Dushko Stanoeski
@dushkostanoeski
Hey @ericblade I'm one of those 42 :D and I'm having an issue with the scanner... I have the scanner in a reusable dialog box (I'm using angular btw) that I call from anywhere in the app. The thing is that the very first scan is OK, but when I call it for a second time, it throws an undefined error and I do not know why.
Dushko Stanoeski
@dushkostanoeski
Turns out this happens only in a dialog, if I put the scanner on the page, it works fine... It probably has something to do with how angular loads the dialogs, but should that make no differece for the scanner?
romanseki
@romanseki
Hello I've incorporated Quaggajs successfully into my project however on iphone after init quagga open stream on whole screen and after the scan is complete and Quagga.stop() is called a black screen fills whole screen and doesn't close out. Any idea why please?
Eric Blade
@ericblade
i'd like to apologize to @dushkostanoeski and @romanseki .. i've been away from gitter for quite a while, and it doesn't look like we've reached a critical mass of traffic yet.
@dushkostanoeski I'm not familiar with Angular, but I highly suspect that it might be changing some things in the DOM, perhaps? would need more info about where and what the error is to try to better throw some ideas
@romanseki I think that's going to be all up to your code -- if you create a space for Quagga, you need to remove that space when you're not using it. Difficult to say without seeing the relevant HTML / JS ..
Eric Blade
@ericblade
typescript conversion of readers is still ongoing. still slow. still painful. will be worth it in the end. whenever that may be. :-D
Eric Blade
@ericblade
readers are mostly done. finally working on the main module now :-D
Eric Blade
@ericblade
boo-yah, parallel decoding finally working
Eric Blade
@ericblade
boo yah, 1.0.0. ::champagne::
Greg Morgan
@hype-armor
🍾
Eric Blade
@ericblade
@hype-armor yeah, that's what i was looking for. :-)
since we forked, we've got a major new feature (still not completely tested, not sure if adding new readers as plugin modules works with LiveStream mode), and a really major bug fix, and most of the code is now in typescript.
Eric Blade
@ericblade
If there is anyone @/all here who is really into developing tests, i've finally started to make the move on that that i've wanted to. I'd appreciate any feedback on the direction that i decided to try out, before it becomes too big of a project to change the direction
Eric Blade
@ericblade
the first commit is ericblade/quagga2#186
Eric Blade
@ericblade
holy cow, this is brilliant. the old tests for the most part just straight up import right into a new test runner.
well the unit tests do. haven't tried end-to-end yet
Eric Blade
@ericblade
hmm. looks like it all works except for the 'integration' and the 'camera-access' tests.
Eric Blade
@ericblade
new tests are live. i've just now discovered that there is a discrepency in functionality between node and browser, in that one of the tests (code_39) fails in node, but not in browser. very curious.
Eric Blade
@ericblade
image.png
well, as they say, "it ain't pretty" .. but it isn't the worst i've ever seen.
Eric Blade
@ericblade
wooow almost 1800 installs this week. that's a record.
Eric Blade
@ericblade
2540 by the end of last week :O
Charles Gehring
@charlesgehring
@ericblade Awesome news!
Eric Blade
@ericblade
i'm hoping that since i've done major work on typescript and testing, that changes are much more stable than they were when the project started. also, hello @charlesgehring
vcrmdeveloper
@vcrmdeveloper
Hi @christop Oberhofer
I am using this, https://serratus.github.io/quaggaJS/v1.0.0-beta.1/examples/scan-to-input/ and it works fine in Web, in ios and android the video stream is not loading
2020-06-16 11_51_21.26.png
vcrmdeveloper
@vcrmdeveloper
Can anyone suggest
Eric Blade
@ericblade
are you using that url from your mobile browser?
if you're using Chrome on Android or Safari on iOS, and accessing that URL, it's probably lack of camera permissions
for the app
if you're hosting your own url, is it https ?
Eric Blade
@ericblade
woo hoo someone that isn't me just got a major piece of work in :-)
sergiuds
@sergiuds
hey guys, how do I change the video aspect ratio to 16:9 instead of 4:3?
whatever width/height/aspectRatio I set in constrains seems not to work
probably I did not found the right combination
sergiuds
@sergiuds
nvmd, contraints where not inside inputstream
Eric Blade
@ericblade
:-) hi!
@sergiuds that sounds like something we could put into the docs. i'm guessing useful for people using cameras in landscape mode? doesn't seem too useful for portrait mode
sergiuds
@sergiuds
@ericblade well, something like this, the phone will be use in portrait mode, but the video displayed should be in landscape, it seems a bit hard to achieve
Eric Blade
@ericblade
hmm. i'm.. not sure why i'd want that, but if it's useful, you're welcome to update the README and pull request, i'm always for improving the knowledge base
@stefanocali has significantly improved the new code32 reader and that was just merged .. very glad to get some progress on adding some real useful things
Eric Blade
@ericblade
@/all if anyone's paying attention here, i'm pushing up a change asap that corrects a flaw that was causing white screens in browser deployments from reasonably secure servers.
Eric Blade
@ericblade
this was completed as an urgent fix, there is some follow up to be done that will hopefully include some additional bundle size reduction. For now, I urge everyone to upgrade to 1.2.5 if possible.
Eric Blade
@ericblade
looking at another big drop in bundle size
:-D :-D :-D
well, weirdly, the node bundle is increasing in size but the browser bundles have dropped 1.3MB and 54K since my last change.. and I think there's more to be gained
Eric Blade
@ericblade
... except tests are failing utterly in node, so i may need to find a slightly different approach