Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jun 25 01:17
    rollingversions[bot] commented #150
  • Jun 25 01:17
    dependabot[bot] labeled #150
  • Jun 25 01:17
    dependabot[bot] opened #150
  • Jun 25 01:17

    dependabot[bot] on npm_and_yarn

    build(deps): bump jsdom from 16… (compare)

  • Jun 24 10:46
  • Jun 20 09:25

    ericblade on npm_and_yarn

    (compare)

  • Jun 20 09:25

    ericblade on master

    build(deps): bump jpeg-js from … Merge pull request #424 from er… (compare)

  • Jun 20 09:25
    ericblade closed #424
  • Jun 20 09:25
    ericblade commented #396
  • Jun 17 03:06
    rollingversions[bot] commented #149
  • Jun 17 03:06
    dependabot[bot] labeled #149
  • Jun 17 03:06
    dependabot[bot] opened #149
  • Jun 17 03:06

    dependabot[bot] on npm_and_yarn

    build(deps): bump jpeg-js from … (compare)

  • Jun 17 01:55
    rollingversions[bot] commented #148
  • Jun 17 01:54
    dependabot[bot] labeled #148
  • Jun 17 01:54
    dependabot[bot] opened #148
  • Jun 17 01:54

    dependabot[bot] on npm_and_yarn

    build(deps): bump jpeg-js from … (compare)

  • Jun 17 01:53
    rollingversions[bot] commented #424
  • Jun 17 01:53
    dependabot[bot] labeled #424
Greg Morgan
@hype-armor
🍾
Eric Blade
@ericblade
@hype-armor yeah, that's what i was looking for. :-)
since we forked, we've got a major new feature (still not completely tested, not sure if adding new readers as plugin modules works with LiveStream mode), and a really major bug fix, and most of the code is now in typescript.
Eric Blade
@ericblade
If there is anyone @/all here who is really into developing tests, i've finally started to make the move on that that i've wanted to. I'd appreciate any feedback on the direction that i decided to try out, before it becomes too big of a project to change the direction
Eric Blade
@ericblade
the first commit is ericblade/quagga2#186
Eric Blade
@ericblade
holy cow, this is brilliant. the old tests for the most part just straight up import right into a new test runner.
well the unit tests do. haven't tried end-to-end yet
Eric Blade
@ericblade
hmm. looks like it all works except for the 'integration' and the 'camera-access' tests.
Eric Blade
@ericblade
new tests are live. i've just now discovered that there is a discrepency in functionality between node and browser, in that one of the tests (code_39) fails in node, but not in browser. very curious.
Eric Blade
@ericblade
image.png
well, as they say, "it ain't pretty" .. but it isn't the worst i've ever seen.
Eric Blade
@ericblade
wooow almost 1800 installs this week. that's a record.
Eric Blade
@ericblade
2540 by the end of last week :O
Charles Gehring
@charlesgehring
@ericblade Awesome news!
Eric Blade
@ericblade
i'm hoping that since i've done major work on typescript and testing, that changes are much more stable than they were when the project started. also, hello @charlesgehring
vcrmdeveloper
@vcrmdeveloper
Hi @christop Oberhofer
I am using this, https://serratus.github.io/quaggaJS/v1.0.0-beta.1/examples/scan-to-input/ and it works fine in Web, in ios and android the video stream is not loading
2020-06-16 11_51_21.26.png
vcrmdeveloper
@vcrmdeveloper
Can anyone suggest
Eric Blade
@ericblade
are you using that url from your mobile browser?
if you're using Chrome on Android or Safari on iOS, and accessing that URL, it's probably lack of camera permissions
for the app
if you're hosting your own url, is it https ?
Eric Blade
@ericblade
woo hoo someone that isn't me just got a major piece of work in :-)
sergiuds
@sergiuds
hey guys, how do I change the video aspect ratio to 16:9 instead of 4:3?
whatever width/height/aspectRatio I set in constrains seems not to work
probably I did not found the right combination
sergiuds
@sergiuds
nvmd, contraints where not inside inputstream
Eric Blade
@ericblade
:-) hi!
@sergiuds that sounds like something we could put into the docs. i'm guessing useful for people using cameras in landscape mode? doesn't seem too useful for portrait mode
sergiuds
@sergiuds
@ericblade well, something like this, the phone will be use in portrait mode, but the video displayed should be in landscape, it seems a bit hard to achieve
Eric Blade
@ericblade
hmm. i'm.. not sure why i'd want that, but if it's useful, you're welcome to update the README and pull request, i'm always for improving the knowledge base
@stefanocali has significantly improved the new code32 reader and that was just merged .. very glad to get some progress on adding some real useful things
Eric Blade
@ericblade
@/all if anyone's paying attention here, i'm pushing up a change asap that corrects a flaw that was causing white screens in browser deployments from reasonably secure servers.
Eric Blade
@ericblade
this was completed as an urgent fix, there is some follow up to be done that will hopefully include some additional bundle size reduction. For now, I urge everyone to upgrade to 1.2.5 if possible.
Eric Blade
@ericblade
looking at another big drop in bundle size
:-D :-D :-D
well, weirdly, the node bundle is increasing in size but the browser bundles have dropped 1.3MB and 54K since my last change.. and I think there's more to be gained
Eric Blade
@ericblade
... except tests are failing utterly in node, so i may need to find a slightly different approach
Eric Blade
@ericblade
I have a drop to under 130KB for the browser minified bundle, and it still seems to work correctly :O :O
i've noticed an amazing improvement in speed of my application that uses quagga loading, since upgrading from 1.2.2 to 1.2.5 .. 1.2.6 should have as much of a gain there
we're about 33k larger than the bundle size from when we forked, and I don't expect to make a 1.x tree any less than that... however i do have some inklings for a 2.x tree someday that will eliminate a LOT of code from the main bundle, and offload it to separate pieces, so you're not saddled with having all the code for all the options you never use.
Eric Blade
@ericblade
ok, 128k looks to be the lower bound for right now
Eric Blade
@ericblade
1.2.6 is in the process of publishing right now, and has a 128k browser bundle size!!! only 30k up since the fork, and a better than 50% reduction since the first versions that used the new webpack!!!!!!!!!
Eric Blade
@ericblade
Happy holidays all!
Gabriel Balint
@zadof
Hello, anybody would be able to help with why some barcodes are hard to read? Seems pretty simple, but it takes a lot of time to read it
Eric Blade
@ericblade
hi there. my best advice is make sure you're using the best resolution you can, make sure you're not using a wide-angle camera lens, and make sure there's as much empty-space around the barcodes as possible... you can use something like the original repo's demonstration to try to adjust your quagga settings for the best results for your use case .. (i do hope to have time to get that demo up from my repo somewhere, or something similar, but haven't had time to even touch quagga in quite a while)
Gabriel Balint
@zadof
I did but it is scanning very slow, it does eventually, but it takes 5-10 seconds of adjusting the camera relative to the barcode
Eric Blade
@ericblade
what kind of a camera device @zadof ?
Gabriel Balint
@zadof
iphone 12 Pro, the problem is the blurry barcode, if it's a little too small it can't read it, whereas commercial libraries read it pretty fast, almost instant