Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
vrajat
@vrajat
ok
adeshr
@adeshr
@vrajat json catalog is also supported with server
vrajat
@vrajat
oh right
remove that sentence
adeshr
@adeshr
sure
adeshr
@adeshr
#32 is ready for merge.
adeshr
@adeshr
@vrajat @amoghmargoor need to understand how should I start #36 ?
vrajat
@vrajat
@amoghmargoor is your best bet @adeshr :)
adeshr
@adeshr
sure, will ask him
vrajat
@vrajat
@adeshr @amoghmargoor feed back on the current git flow of rebase and “merge” from PR ?
should we go back to squash merge ?
vrajat
@vrajat
@amoghmargoor #43 is finally ready for a merge
adeshr
@adeshr
:+1: for rebase, no need for command line
amoghmargoor
@amoghmargoor
@vrajat Will merge #43
+1 for merge using PR... That is easier
vrajat
@vrajat
ok. thx
vrajat
@vrajat
for e.g. dbCatalog.json is not maintained
adeshr
@adeshr
dbCatalog.json is not required. must have missed removing it.
Logback.xml can also be removed, the server will pick it from fatjdbc/main/resources
vrajat
@vrajat
ok. I’ll clean them up
adeshr
@adeshr
sure
adeshr
@adeshr

Context:
1) Created two tables warehouse (in defaultDataSource) and warehouse_partition (views) using tpcds.sql files.
2) Added different set of data in both tables.
3) started testing (with data-sources tables having 2 rows, one for default data-source and other for views, without empty views table)

Error:
Now I created a warehouse_partition view using DDL statement and then tried 'select count() from warehouse w_warehouse_sq_ft > 200'
but this failed with error:
java.sql.SQLException: Error while executing SQL "select count(
) from canonical.public.warehouse as wr where wr.w_warehouse_sq_ft > 200": null
at com.qubole.quark.planner.MetadataSchema$1.createTable(MetadataSchema.java:99)
at org.apache.calcite.materialize.MaterializationService.defineMaterialization(MaterializationService.java:138)
at com.qubole.quark.planner.MetadataSchema.initialize(MetadataSchema.java:122)
at com.qubole.quark.sql.QueryContext.<init>(QueryContext.java:111)

But the same query passes if the warehouse_partition view was added before starting the test (instead of using the DDL).
Not sure if I am setting up things wrong, or missing something, any suggestions?

amoghmargoor
@amoghmargoor
@adeshr will need to look at your changes ... what branch are you working on ??
adeshr
@adeshr
viewsupport (https://github.com/adeshr/quark/tree/viewsupport)
Filename: DDLViewTest.java
amoghmargoor
@amoghmargoor
@adeshr looking at it now .... was away yesterday
amoghmargoor
@amoghmargoor
@adeshr looks like the values entered via View DDL has extra quotations ...Can you check that ? may be thats the issue
adeshr
@adeshr
was away in morning...checking now
adeshr
@adeshr
this is weird!! I replaced ' with " and it is working now
amoghmargoor
@amoghmargoor
oh yeah ... thats because we use " as quotation instead of ' for Quark DDL while parsing I guess.... we would need to document this somewhere ... need to check if it's consistent with Select queries too
adeshr
@adeshr
oh..ok
I am running this query on Quark: select count(*) from customer_address as c where c.ca_street_name='commercialstreet' and it is working, so maybe select can work with both quotations?
amoghmargoor
@amoghmargoor
@adeshr hmmm ..interesting...raise an issue and assign it to me. I could not find out exactly why looking at Sql Parser. it' minor issue so lets not get blocked on it for your PR. I will try to look at it later.
adeshr
@adeshr
sure, will raise the issue.
vrajat
@vrajat
@amoghmargoor can you take a quick look at #53 ?
oops I meant #54
amoghmargoor
@amoghmargoor
@vrajat yeah done ...running Integration tests on it now.
vrajat
@vrajat
thx
amoghmargoor
@amoghmargoor
@vrajat PR for quark on upgrading to calcite-1.7.0 : qubole/quark#57
vrajat
@vrajat
lgtm
calcite jars need to be deployed ?
tests failed
amoghmargoor
@amoghmargoor
starting 5 commits is what got added after syncing from calcite branch
yeah ...that needs to be deployed
after creating qds-1.7 from it
vrajat
@vrajat
should you just create a branch from calcite branch-1.7 instead ?
they released it too
amoghmargoor
@amoghmargoor
yeah will do that ... that makes sense
vrajat
@vrajat
feel better that way
branch from branch-1.7, CP the commits
amoghmargoor
@amoghmargoor
sure will do that.