Krinkle on master
Build: Restore strict mode comp… (compare)
Error: No tests were run.
hooks.teardown, or were those only on module calls with an object argument rather than the callback function?
git grep qunitjsshould find any places that might need an update.
QUnitobject, which has not changed. and the CLI command is still called
qunit, same as before.
that makes sense, thanks.
i started implementing that, then realized that this is probably true of other browsers too. should we have a utility (maybe something near globals.js) to warn about certain deprecated browsers? we have a lot of scaffolding and fallthroughs for the older envs, so we could warn when we know we've had to gracefully degrade/polyfill.
i guess my point is, i assume we'd want to warn for each browser we want to drop in 3.0, but not produce too much noise for warning at every turn. if that outlook is agreeable, i can work on that and propose a PR
that sounds fair about the browser support - PhantomJS could surprise some folks, and I can issue a warning for that. I'll leave the broader "this browser will be deprecated" can-of-worms alone....
and thanks for touching up the coveralls. I loooooove a green coverage report :-)
does anyone have a go-to grunt task to run QUnit node tests?
i've found grunt-qunit-node, grunt-node-qunit (both very old), grunt-contrib-qunit (but that's just for HTML browser tests), and then there's https://github.com/qunitjs/node-qunit, which looks maintained, though still uses some 1.x globals in the readme, and I wasn't sure how easy it was to pull that into Grunt ecosystems...
npm testidiom and get it the same way as otherwise.
require("qunit")and run that, which is missing a lot of protections and debug utilities. I wouldn't recommend it personally
qunit ./test/*.jsor simply
qunitfrom the test command.