These are chat archives for quorrajs/quorrajs

31st
Oct 2017
Kevin Viglucci
@viglucci
Oct 31 2017 02:34
Hi all! Thought I would stop by as I was reading the contribution guide (https://quorrajs.org/docs/1.0.0/preface/contribution-guide.html) and it said to stop in here before making any pull requests.
I was looking at making a PR against Ouch, but I noticed that the tests do not seem to pass on node >=6. Because of this, I plan to first make a PR that updates the engines property in package.json, as well as add some additional node versions to the travis.yml to test node version support in CI moving forward.
Harish
@harishanchu
Oct 31 2017 03:38
Hi @viglucci , thanks for your interest in ouch module please proceed with the changes.
Harish
@harishanchu
Oct 31 2017 03:43
FYI ouch module is based on nodejs's deprecated domain api and we may rewrite it partially or entirely when a replacement for domain api is available.
Kevin Viglucci
@viglucci
Oct 31 2017 04:39
@harishanchu i've submitted my PR here (quorrajs/Ouch#12)
If this PR is accepted, I will likely make an additional PR to add support for quorrajs/Ouch#10, but I wanted to get those tests working on the later versions of node first so that I know I don't break anything :)