by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 04 18:57
    kaushik-work closed #95
  • Aug 04 18:57
    kaushik-work commented #95
  • Aug 04 18:26
    mr-c opened #95
  • Jul 30 17:21
    kaushik-work closed #94
  • Jul 30 17:21
    kaushik-work commented #94
  • Jul 30 01:13
    kaushik-work commented #94
  • Jul 30 01:07
    kaushik-work assigned #94
  • Jul 29 23:50
    stain opened #94
  • Jun 12 02:57
    kaushik-work edited #93
  • Jun 12 02:56
    kaushik-work labeled #93
  • Jun 12 02:56
    kaushik-work assigned #93
  • Jun 12 02:56
    kaushik-work labeled #93
  • Jun 12 02:56
    kaushik-work opened #93
  • Jun 10 17:46
    kaushik-work closed #89
  • Jun 10 17:46

    kaushik-work on master

    Handle hover content type in a … (compare)

  • Jun 04 15:22

    kaushik-work on master

    Move badges up top so links are… (compare)

  • Jun 03 21:03

    kaushik-work on 2020.06.03.1

    (compare)

  • Jun 03 21:02

    kaushik-work on master

    Update Benten version (compare)

  • Jun 03 20:56

    kaushik-work on 2020.06.03

    (compare)

  • Jun 03 20:47

    kaushik-work on master

    Resolve types/vscode and engine… Note how to inject package into… (compare)

Kaushik Ghose
@kaushik-work
Hi @manabuishii ! I created this room. I'd started an internal, nascent project in SBG called Benten but I like the name so much, I'd like to use it for our CWL language server. I started a bare bones repo here: https://github.com/rabix/benten
We can add more people as the project matures
My mentor at SBG pointed me to the emacs CWL integration (He's a big emacs user) https://github.com/tom-tan/cwl-mode
The idea for the project I initially started was to have a CWL language server (in Python, because that's what I know) and to have a lightweight tkinter app around it to do some things that a language server might not, say like scroll to particular parts of the document, or open a new editor tab etc. (I'm still familiarizing myself with the protocol)
Manabu ISHII
@manabuishii
hello
thank you create this room
Manabu ISHII
@manabuishii
I inform to tom-tan about this room.
In Japan currently midnight, so I think he will join here several hours later.
Michael R. Crusoe
@mr-c
What's a language server?
Kaushik Ghose
@kaushik-work
The core idea is that we write editor language support once and it uses a standardized API and any editor that supports that API will now have relevant language features, so people don't have to write language plugins for each editor separately
My boss/mentor remarked that in the initial incarnation it was slow and clunky but is probably more well developed now, and it's probably a good time to try one for CWL
Tomoya Tanjo
@tom-tan
Hi!
Once we have one CWL language server, we have rich language supports such as code completion and document lookup for many editors/IDEs that have a language client implementation.
Manabu ISHII
@manabuishii

Go (https://godoc.org/golang.org/x/tools/internal/lsp) and
Rust (https://github.com/rust-lang/rls)
has just started to support OFFICIAL Language server.

Language Server is good for CWL Community.
I think it is good that CWL Community also has OFFICIAL Language Server.

Michael R. Crusoe
@mr-c
Awesome, thanks for starting this @kaushik-work !
Shall we move this to the common-workflow-language GitHub organization?
Kaushik Ghose
@kaushik-work
Hi @mr-c my preference would be to keep it under Rabix, next to Composer. I know cwltool resides in common-workflow-language but I like tooling to be separate (and diverse) from the language spec itself. I don't think find-ability is going to be an issue.
Michael R. Crusoe
@mr-c
This was in response to @manabuishii 's request for Benten to be the official language server
Kaushik Ghose
@kaushik-work
I don't know about "official". I want to be able to make one and have a program people can use. Then we can see about the rest. I do hope there will be multiple language servers :)
Just like CWL has multiple interpreters, I like the idea of multiple tools that support workflow development, each with a niche, serving particular types of users.
Manabu ISHII
@manabuishii
Yes, not only one implementation , but also more implementations like CWL has multiple interpreters.
Kaushik Ghose
@kaushik-work
:thumbsup: I can see them catering to different styles of development, but my personal hope is we get a prototype out there for people to kick the tires on and then we can see whats next
Kaushik Ghose
@kaushik-work
Dear @manabuishii does the grammar for the ace editor (https://github.com/manabuishii/language-cwl/tree/master/grammars/auto-generated) work? I'm assuming I copy that under the source distribution and name it mode-cwl.jsis that correct? Thanks!
Kaushik Ghose
@kaushik-work
Hi @hmenager @stain Hope you are well. I'm developing a CWL editor that is code first - i.e. preserves the original code but still offers some assists. I've added you to the gitter room and you should be able to see the code. It's pretty early stages, but I'd appreciate feedback
Including what you expect in a code editor for CWL
Kaushik Ghose
@kaushik-work
Heh, inordinately satisfied with the ACE editor integration :D https://www.youtube.com/watch?v=gsSO55AWnOM
Michael R. Crusoe
@mr-c
@kaushik-work Super cool!
Kaushik Ghose
@kaushik-work
@mr-c :smiley:
Kaushik Ghose
@kaushik-work
Thanks for the PR @stain!
Kaushik Ghose
@kaushik-work
Hi @pvanheus many thanks for creating the Conda Forge release. I noticed that the distribution has become a bit out of date. The robots seem to be doing their job: https://github.com/conda-forge/benten-feedstock/pulls . Can I help in any way to bridge the last step to getting it pushed to Conda Forge? Thanks!
pvanheus
@pvanheus
thanks for the ping @kaushik-work - I've merged the latest robot PR.
Kaushik Ghose
@kaushik-work
:confetti_ball:
Thanks @pvanheus ! I made a new release yesterday, but the robots apparently only saw it just now.
pvanheus
@pvanheus
ok merged that one too
Kaushik Ghose
@kaushik-work
@pvanheus thanks so much!
pvanheus
@pvanheus
@kaushik-work I'm trying to package benten 2020.06.03.1 but getting an error
$ benten-ls -h
Traceback (most recent call last):
  File "/home/pvh/anaconda3/envs/benten_dev/bin/benten-ls", line 6, in <module>
    from benten.__main__ import main
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/benten/__main__.py", line 7, in <module>
    from .configuration import Configuration
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/benten/configuration.py", line 8, in <module>
    from .cwl.specification import parse_schema
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/benten/cwl/specification.py", line 8, in <module>
    from .alltypes import *
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/benten/cwl/alltypes.py", line 12, in <module>
    from .expressiontype import CWLExpressionType
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/benten/cwl/expressiontype.py", line 6, in <module>
    import dukpy
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/dukpy/__init__.py", line 1, in <module>
    from .evaljs import evaljs, JSInterpreter
  File "/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/dukpy/evaljs.py", line 7, in <module>
    from . import _dukpy
ImportError: cannot import name '_dukpy' from partially initialized module 'dukpy' (most likely due to a circular import) (/home/pvh/anaconda3/envs/benten_dev/lib/python3.8/site-packages/dukpy/__init__.py)
this is only happening with a conda install, I'm looking into the source
Kaushik Ghose
@kaushik-work
@pvanheus sorry you are running into that. This is happening from inside dukpy. I wonder, if this has to do with the recent release?
I see dukpy has a June 9th release, and it's great there is active work on it, but I have the 0.2.2 (2018) release on my machine. The Travis CI tests pass, which means the PyPi release on Linux is fine, so perhaps there is an issue with the latest DukPy Conda release. Could you try pinning it to 0.2.2 and see what happens?
Kaushik Ghose
@kaushik-work
pvanheus
@pvanheus
I'm pretty certain I'm using dukpy 0.2.2
so if I install the dependencies (cwlformat, ruamel.yaml and dukpy) in a conda environment and run the pip install step for benten it works fine
pvanheus
@pvanheus
I think I'll turn to the conda-forge channel for help
pvanheus
@pvanheus
@kaushik-work I decided to try and build the existing (working) benten package locally and that failed... so I (correctly it turns out) concluded that the problem was on my side. 2020.06.03.1 is now in conda-forge :)
Kaushik Ghose
@kaushik-work
@pvanheus very cool! Thank you so much!