These are chat archives for ractivejs/ractive

1st
Sep 2017
Cerem Cem ASLAN
@ceremcem
Sep 01 2017 13:02
@fskreuz shouldn't we create multiple branches before submitting a PR? I prefer that way because one commit might be mandatory (ie. to fix a bug) and the other is optional (ie. refactor a variable name or change a color)
Joseph
@fskreuz
Sep 01 2017 13:11
Well... Multiple branches is fine, but multiple PRs containing some commits of another PR can be confusing. :grin:
Cerem Cem ASLAN
@ceremcem
Sep 01 2017 13:11
yup, that was a mistake :smile:
Joseph
@fskreuz
Sep 01 2017 13:11
PRs are open for a while anyways, enough for people to comment on what needs changing.
I usually mutate my branches, rearrange commits, etc. etc. in response to comments while still a PR (unless someone also works on it, thus can't rebase/force push, all that jazz).