Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 01:28

    erwanp on develop

    (docs) remove gitter sidecar fr… (compare)

  • 00:49

    erwanp on develop

    (docs) updated custom searchbox… (compare)

  • 00:00

    erwanp on develop

    (docs) mention the New Feature … (compare)

  • Feb 20 23:35
    erwanp edited #79
  • Feb 20 23:35
    erwanp edited #79
  • Feb 20 23:34
    erwanp edited #79
  • Feb 20 23:34
    erwanp edited #79
  • Feb 20 23:34
    erwanp opened #79
  • Feb 20 23:32
    erwanp edited #53
  • Feb 20 22:58

    erwanp on develop

    (docs) reference the Github/Con… fix syntax of UnicodeDecodeErro… (docs) update (compare)

  • Feb 20 22:52
    erwanp edited #53
  • Feb 20 22:07
    erwanp edited #78
  • Feb 20 22:06
    erwanp edited #78
  • Feb 20 22:06
    erwanp labeled #78
  • Feb 20 22:06
    erwanp opened #78
  • Feb 20 18:52
    erwanp edited #53
  • Feb 20 18:51
    erwanp edited #53
  • Feb 20 18:41
    erwanp labeled #77
  • Feb 20 18:41
    erwanp labeled #77
  • Feb 20 18:41
    erwanp opened #77
Ritwik Saha
@ritzvik
@erwanp I think we can leave isort for now
Erwan Pannier
@erwanp
i found that: import module # isort:skip but that would have to be manually added for each import
Ritwik Saha
@ritzvik
yes!
that works
but I think applying isort module by module, and then see the problems
would be better
It would be labour intensive, but for long term, it can keep code clean
Erwan Pannier
@erwanp
could also be applied to ignore a module, for instance the __init__(which most developers wont touch anyway): https://github.com/timothycrosley/isort#skip-processing-of-imports-outside-of-configuration
Ritwik Saha
@ritzvik
yes, isort can be configured to ignore a files with certain patterns
Erwan Pannier
@erwanp
also you probably know about this: psf/black#333
discussions on black-compatible isorts, and isorts included in blacks
Ritwik Saha
@ritzvik
I didn't know
Erwan Pannier
@erwanp
we could also wait for that feature to be implemented. Seems they're working on it!
Ritwik Saha
@ritzvik
Yes, that seems like a nice idea.
Erwan Pannier
@erwanp
i'll open an Issue and summarize that.
Ritwik Saha
@ritzvik
:thumbsup:
Erwan Pannier
@erwanp
Does someone has experience with Jekyll for static-site generation? I'm trying to add a main site at https://radis.github.io/radis-radiation/ based on the template from https://einsteinpy.org/
Ritwik Saha
@ritzvik
I don’t maintain the website of EinsteinPy, however I can see that there is a link in the einsteinpy.org repo to set up GitHub pages using Jekyll
Shreyas Bapat
@shreyasbapat
Hello everyone!
I will work on the jekyll as soon as I am free from other tasks
I promise you, I will make it work. Its a minor bug
Erwan Pannier
@erwanp
Amazing, thanks a lot!! i've never used jekyll, just copied most of your template! :)
Shreyas Bapat
@shreyasbapat
Right. I am so busy for some days (~10 days). Have some conference deadlines
I'll get back and fix asap
Erwan Pannier
@erwanp
Good luck with the deadlines!!
Erwan Pannier
@erwanp
@minouHub your last commit failed because we're now using the Black coding formats, but the Developer Guide wasn't updated. That will be done in radis/radis#60
Erwan Pannier
@erwanp
@minouHub you will be spammed until fixed :)
Ritwik Saha
@ritzvik
😂
Minesi N
@minouHub
Omg I just wanted a quick fix for my problem. I'll have a look to this (obscure) Black coding thing in the following hours
Minesi N
@minouHub
Guys ... it was just a trailing space! Sorry, I didn't want to annoy anyone with this
I probably arrive after the fight but ... do we want commits to fail for a trailing space ? Maybe I don't get the importance of very correct formatting ?
Erwan Pannier
@erwanp
Agreed that it seems futile and cumbersome, but it will pay off in the long term. We will make it mandatory in the Developer Guide (radis/radis#60) to run Black before committing (it's just one command). It can be done by other developers, too, if submitting a Pull Request.
@ritzvik do you have a clear Developer Guide / How To Contribute template to suggest ?
@minouHub your tests are still crashing but it's not related to your changes anymore (Formats are fine). The formats in the Pandas line databases are not converted properly as before. Maybe a change in Pandas itself?
Ritwik Saha
@ritzvik
I’ll write one
Last night, I tried to work on isort but there are too many instances of circular imports
I guess even when the Black issue gets closed, we can’t lint the imports.... either we go with “don’t fix what’s not broken” policy
Or painstakingly fix the imports
Erwan Pannier
@erwanp
Too bad it didn't work. Let's drop that for the moment. I added a "fix circular import" to the Long Term Refactor list

@minouHub your tests are still crashing but it's not related to your changes anymore (Formats are fine). The formats in the Pandas line databases are not converted properly as before. Maybe a change in Pandas itself?

Created a radis/radis#65 issue for that!

Ritwik Saha
@ritzvik
👍🏾
Minesi N
@minouHub
Ok, I trust you on this one (and actually it's very easy to just do 'black mycode.py')
Erwan Pannier
@erwanp
or black radis for all files in the folder!
Erwan Pannier
@erwanp
@minouHub you may want to set up pre_commit too, so Black is run everytime you commit without having to do anything (see the last checkboxes in radis/radis#60)
Ritwik Saha
@ritzvik
Radis now in OpenAstronomy❤️
Congrats @erwanp
Erwan Pannier
@erwanp
Yes, good news there! We'll submit some projects for Google Summer of Code next!
Erwan Pannier
@erwanp
@ritzvik more people are starting to contribute, that's good news! From your own experience: how can we help a new developer on the project understand the code structure ? I'll improve the Developer Guide accordingly (currently: https://radis.readthedocs.io/en/latest/dev/developer.html)
Ritwik Saha
@ritzvik
Sure I’ll see what can be improved tomorrow. I can barely stand on my feet today as I went on a 20 km trek 😅
Ritwik Saha
@ritzvik
I think that the developer guide is adequate. A too long dev guide can overwhelm newcomers
Erwan Pannier
@erwanp
Vote for the syntax of the multi-molecule calculation:
radis/radis#63