that works
but I think applying
isort module by module, and then see the problems
would be better
It would be labour intensive, but for long term, it can keep code clean
could also be applied to ignore a module, for instance the
__init__(which most developers wont touch anyway): https://github.com/timothycrosley/isort#skip-processing-of-imports-outside-of-configuration
also you probably know about this: psf/black#333
discussions on black-compatible isorts, and isorts included in blacks
discussions on black-compatible isorts, and isorts included in blacks
Does someone has experience with Jekyll for static-site generation? I'm trying to add a main site at https://radis.github.io/radis-radiation/ based on the template from https://einsteinpy.org/
I will work on the jekyll as soon as I am free from other tasks
I promise you, I will make it work. Its a minor bug
I'll get back and fix asap
@minouHub your last commit failed because we're now using the Black coding formats, but the Developer Guide wasn't updated. That will be done in radis/radis#60
I probably arrive after the fight but ... do we want commits to fail for a trailing space ? Maybe I don't get the importance of very correct formatting ?
Agreed that it seems futile and cumbersome, but it will pay off in the long term. We will make it mandatory in the Developer Guide (radis/radis#60) to run Black before committing (it's just one command). It can be done by other developers, too, if submitting a Pull Request.
@ritzvik do you have a clear Developer Guide / How To Contribute template to suggest ?
@minouHub your tests are still crashing but it's not related to your changes anymore (Formats are fine). The formats in the Pandas line databases are not converted properly as before. Maybe a change in Pandas itself?
Last night, I tried to work on isort but there are too many instances of circular imports
I guess even when the Black issue gets closed, we can’t lint the imports.... either we go with “don’t fix what’s not broken” policy
Or painstakingly fix the imports
@minouHub your tests are still crashing but it's not related to your changes anymore (Formats are fine). The formats in the Pandas line databases are not converted properly as before. Maybe a change in Pandas itself?
Created a radis/radis#65 issue for that!
@minouHub you may want to set up pre_commit too, so Black is run everytime you commit without having to do anything (see the last checkboxes in radis/radis#60)
Congrats @erwanp
@ritzvik more people are starting to contribute, that's good news! From your own experience: how can we help a new developer on the project understand the code structure ? I'll improve the Developer Guide accordingly (currently: https://radis.readthedocs.io/en/latest/dev/developer.html)