These are chat archives for rails-sqlserver/activerecord-sqlserver-adapter

24th
Feb 2015
Rafael França
@rafaelfranca
Feb 24 2015 01:56
@metaskills commented there
BTW, can I notify you before new releases so we can make sure a new Rails version will not break this adapter?
Rafael França
@rafaelfranca
Feb 24 2015 02:03
(the notification looks like this plataformatec/devise#3398)
Ken Collins
@metaskills
Feb 24 2015 03:00
Hey….
Thanks @rafaelfranca for checking in.
I am looking at the issue closer now.
It is not a big show stopper… but I do appreciate it...
Ken Collins
@metaskills
Feb 24 2015 03:15
OK, the regression is not due to rails/rails#18407
Finding out what is. But I can be certain that attributes_for_update is not being used for DirtyTest#test_partial_update_with_optimistic_locking
In 4.2.1.rc1 but is for 4.2.0
Ken Collins
@metaskills
Feb 24 2015 03:23
OK, I think I got it.
It was a change to dirty.rb
Ken Collins
@metaskills
Feb 24 2015 04:19
FOUND IT
Ken Collins
@metaskills
Feb 24 2015 04:30
rails/rails#19057
Ken Collins
@metaskills
Feb 24 2015 12:46
Morning everyone.
Rafael França
@rafaelfranca
Feb 24 2015 14:37
morning
Ken Collins
@metaskills
Feb 24 2015 14:38
Yo yo.
Rafael França
@rafaelfranca
Feb 24 2015 14:39
Thank you for the issue. I don't have too much time to look this issue today but I'll do tomorrow. I'll make sure to not release another RC without fixing it.
Ken Collins
@metaskills
Feb 24 2015 14:42
No problem… I can work up a patch tonight too. It’s been a while since I got a commit in Rails core.