These are chat archives for rails-sqlserver/activerecord-sqlserver-adapter

27th
Feb 2015
Ken Collins
@metaskills
Feb 27 2015 12:40
Can I get a second set of eyes on this?
It might have been a regression in 4.2 in general.
Ken Collins
@metaskills
Feb 27 2015 13:07
(start from the bottom up)
Rafael França
@rafaelfranca
Feb 27 2015 14:06
:eyes:
Rafael França
@rafaelfranca
Feb 27 2015 14:12
the code that checks pk != 'id' is there since 2006
rails/rails@7e6d5b5
Ken Collins
@metaskills
Feb 27 2015 14:23
LOL
I’ll take another peak as @sgrif noted too.
Rafael França
@rafaelfranca
Feb 27 2015 14:23
yeah, that too
I remember merging some PRs to add support to string primary keys
Sean Griffin
@sgrif
Feb 27 2015 14:37
I'll give it a more in depth look in a bit
That comment was literally the first thing I did after waking up.
I need coffee
And bacon
Rafael França
@rafaelfranca
Feb 27 2015 14:47
bacon <3
Ken Collins
@metaskills
Feb 27 2015 14:48
Oh… I have both those things.