These are chat archives for rails-sqlserver/activerecord-sqlserver-adapter

29th
Jun 2017
Ken Collins
@metaskills
Jun 29 2017 00:26
Hello!
Joe Bauser
@coderjoe
Jun 29 2017 00:26
Hello!
Do you have a second? I'd like to catch you up to speed on where things stand and get your opinion on some build stuff.
Ken Collins
@metaskills
Jun 29 2017 00:32
I think so... I'm in DC with free time.
So plenty of time really... captive audience.
Want me to pull the branch or anything?
Joe Bauser
@coderjoe
Jun 29 2017 00:32
So I've pushed the changes you suggested, what's left is to make sure it solves your problems and figure out how to deal with a windows linker problem
So the windows problem is as follows, I can get the build chain to build the appropriate shared libraries and bundle them, but I keep running into the same error we're seeing in a few of the tintds_issues such as...
well I'm having trouble finding the issue, anyway for the 32 bit ruby installer (both ruby installer and rails installer) they both require devkit to be installed in order to link shared libraries.
that's resulting in errors at runtime which boil down to the necessary library being missing... unless devkit is installed
I'm not doing a very good job of describing this just now, but the question boils down to whether or not it is reasonable to presume people running on windows can be expected to install devkit in order to install the precompiled gems
Ken Collins
@metaskills
Jun 29 2017 00:36
Reading...
You are... this says it all...
library being missing... unless devkit is installed
So that is a great summary of those random issues... I know em well.
I just dont know what to do with em other than telling people to flex your build skills. :)
I just pulled the branch.. EPIC for me :)
Joe Bauser
@coderjoe
Jun 29 2017 00:38
Hah yeah, so what I've found so far is it's just an artifact of the rubyinstaller itself. I'm not sure we can get around it.
Ken Collins
@metaskills
Jun 29 2017 00:38
Builds and tests fine... love it.
Joe Bauser
@coderjoe
Jun 29 2017 00:38
wait really? it built on your machine? That's so fantastic
Ken Collins
@metaskills
Jun 29 2017 00:38
Do you think others that use our build style have the same issue?
It did!
Joe Bauser
@coderjoe
Jun 29 2017 00:39
I'm finding many references to this
so it's definitely not just us
Ken Collins
@metaskills
Jun 29 2017 00:39
So lets ignore it.
And live a little.
This PR is epic and a great 2.0 foundation.
Joe Bauser
@coderjoe
Jun 29 2017 00:39
Ok so the only change that really means is that devkit is a prereq for the gem on windows, even if using the binary gem
I'm pretty sure it also means that all I have to do is clean up docs and we're ready to give 2.0 a try
Ken Collins
@metaskills
Jun 29 2017 00:40
I wonder if I can help DOC that in the README?
Joe Bauser
@coderjoe
Jun 29 2017 00:40
or whatever we call this merge
Ken Collins
@metaskills
Jun 29 2017 00:40
Like real big... with links?
I can help with that after this.
Is merged in.
BTW... if I fall off for a bit it is because I am changing rooms/locations.
Joe Bauser
@coderjoe
Jun 29 2017 00:41
No worries.
I'm at this hackathon for the next 30 minutes then I need to commute home.
Hanging here like I understand what everyone is talking about :P
Joe Bauser
@coderjoe
Jun 29 2017 00:43
lol nice, I'm at a meetup as well. :)
commuting, back in 35
Joe Bauser
@coderjoe
Jun 29 2017 01:25
back online
Also I just checked out that meetup you linked. Raft is a really really interesting consensus algorithm. I hope you enjoy it. Personally I found the various youtube videos describing it to be very helpful in terms of understanding it
Out of curiosity, did you happen to test the windows gem build on your machine as well?
Ken Collins
@metaskills
Jun 29 2017 01:35
Oh... no... let me try.
Does this still use Docker?
Joe Bauser
@coderjoe
Jun 29 2017 01:39
yeppers
rake gem:windows is still almost the same, it just builds the ports (openssl, freetds, libiconv) first instead of doing it in extconf.
and all of it is still done in rake-compiler-dock
Ken Collins
@metaskills
Jun 29 2017 01:40
Ah... there we go.... I was using the wrong command.
Running now.
Joe Bauser
@coderjoe
Jun 29 2017 01:40
Thanks. :)
Ken Collins
@metaskills
Jun 29 2017 01:43
Ugh... hotel wifi... let me use my phone
Ken Collins
@metaskills
Jun 29 2017 02:08
I'll have to test it this weekend.
Joe Bauser
@coderjoe
Jun 29 2017 02:08
no worries. Let me know if you need anything, and I'll respond as soon as I can. :)
Ken Collins
@metaskills
Jun 29 2017 02:09
Will do Joe... cant wait... if that goes well, I think we should merge it in.
Maybe release a 2.0.0.rc1
Joe Bauser
@coderjoe
Jun 29 2017 02:11
Cool. I think I have the VERSION tagged as 2.0.0.pre1 as is just in case of accidental gem push.
Ken Collins
@metaskills
Jun 29 2017 02:11
Perfect!
Joe Bauser
@coderjoe
Jun 29 2017 02:11
Anyway, have fun in DC, it's a great town. I recommend the spy museum and the newseum. :)
Ken Collins
@metaskills
Jun 29 2017 02:12
Been there with CustomInk once.
Joe Bauser
@coderjoe
Jun 29 2017 02:12
Oh and the National Museum of the American Indian
;)
Ken Collins
@metaskills
Jun 29 2017 02:12
:thumbsup: