These are chat archives for ramda/ramda

11th
Dec 2015
Tobias Pflug
@gilligan
Dec 11 2015 09:25
hm, i am quite confused right now
R.equals(new Error('XXX'), new Error('XXX')) this evaluates to false - the tests in equals.js test for it to be true
if I run only the equals test it fails, if I run everything via npm run test it passes
?!?!
Scott Christopher
@scott-christopher
Dec 11 2015 09:49
@gilligan I'm guessing you're running the individual test on v0.18, which was tagged a couple of days before this commit landed ramda/ramda@ba70cc5
Tobias Pflug
@gilligan
Dec 11 2015 09:50
@scott-christopher i am on master
@scott-christopher working on a pull request
Scott Christopher
@scott-christopher
Dec 11 2015 09:50
how did you run the individual test?
Tobias Pflug
@gilligan
Dec 11 2015 09:51
basically just run mocha to run the individual file
@scott-christopher also just look at the output of the ramda repl
@scott-christopher it evaluates to false even though in the test it tests for equality to return true
Scott Christopher
@scott-christopher
Dec 11 2015 09:51
Yeah, the repl is running v0.18
Tobias Pflug
@gilligan
Dec 11 2015 09:51
ah, d'oh now i get you
Scott Christopher
@scott-christopher
Dec 11 2015 09:52
try running npm run build beforehand if you're running mocha directly
or npm run pretest && mocha test/equals
Tobias Pflug
@gilligan
Dec 11 2015 09:53
let me try
that works
and I don't understand why
can you enlighten me ? :)
Scott Christopher
@scott-christopher
Dec 11 2015 09:55
the tests use dist/ramda.js, so you need to make sure that has the latest build from the current source
The dist/ramda.js that is commited is the build from the most recent tagged release.
so when you ran the test without running npm run build prior, it was using ramda v0.18, which didn't yet have the equals implementation for Error
running npm run test implicitly runs npm run pretest by convention of npm scripts prefixed with pre (and likewise for post).
Tobias Pflug
@gilligan
Dec 11 2015 09:59
actually it all boils down to the fact that i hadn't rebased my branch for too long ;}
Scott Christopher
@scott-christopher
Dec 11 2015 09:59
or that :D
Tobias Pflug
@gilligan
Dec 11 2015 10:00
and at the point where the repl result did not make sense and i didn't think about it merely not being up to master
Tobias Pflug
@gilligan
Dec 11 2015 10:16
@scott-christopher either way - thanks for the quick heads up ;)
Scott Christopher
@scott-christopher
Dec 11 2015 10:43
no worries :)