Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 22:17
    CrossEye commented #2779
  • Jan 31 2019 21:04
    ArturAralin commented #2779
  • Jan 31 2019 20:08
    CrossEye commented #2779
  • Jan 31 2019 18:56
    buzzdecafe commented #2631
  • Jan 31 2019 18:09
    ArturAralin commented #2779
  • Jan 31 2019 16:18
    CrossEye commented #2779
  • Jan 31 2019 16:10
    CrossEye commented #2631
  • Jan 31 2019 16:06
    CrossEye commented #2777
  • Jan 31 2019 14:44
    ArturAralin opened #2779
  • Jan 31 2019 07:39
    inferusvv commented #2631
  • Jan 31 2019 03:07
    sespinozj commented #2771
  • Jan 31 2019 02:33
    machad0 commented #2771
  • Jan 31 2019 02:26
    JeffreyChan commented #2777
  • Jan 30 2019 14:30
    CrossEye closed #2777
  • Jan 30 2019 12:13
    vanyadymousky updated the wiki
  • Jan 30 2019 01:42
    JeffreyChan commented #2777
  • Jan 29 2019 21:06
    vanyadymousky updated the wiki
  • Jan 29 2019 16:28
    CrossEye commented #2777
  • Jan 29 2019 15:50
    mbostock commented #2772
  • Jan 29 2019 15:48
    CrossEye commented #2772
Tobias Pflug
@gilligan
I actually just did a PR where I used R.or(a,b) to pick a or b and someone commented "hey this should not work. R.or is documented to return true or false. You should use something else and file an upstream ticket" ;)
David Chambers
@davidchambers
S.or provides the "alternative" implementation, by the way.
Tobias Pflug
@gilligan
interesting ;)
just figured @CrossEye is on fp slack chat as well. i wish we could have the ui of slack combined with the practicality of gitter
David Chambers
@davidchambers
Would be nice!
Tobias Pflug
@gilligan
@davidchambers ever been on the fpslack chat ?
David Chambers
@davidchambers
No, I have not. My forays into the world of Slack have been limited so far. We use HipChat at Plaid. :\
Tobias Pflug
@gilligan
never used that
David Chambers
@davidchambers
You're not missing much.
Tobias Pflug
@gilligan
we actually have slack at holidaycheck
quite like it
@davidchambers do you think you have time to have another look at ramda/ramda#1529 later ?
David Chambers
@davidchambers
Once you've normalized the formatting of .eslintrc I'm happy to merge it. Thanks for all your work on this!
Tobias Pflug
@gilligan
oh sure, i'll just run jsonlint over it :)
David Chambers
@davidchambers
Lint the linter! :)
Tobias Pflug
@gilligan
oh.. yeah and there was actually a dangling comma in there haha
Tobias Pflug
@gilligan
@davidchambers fixed!
think the next PR I will try is adding jsverify tests
David Chambers
@davidchambers
That'll be sweet!
Tobias Pflug
@gilligan
should probably be "neutral element" not "unit element"
urghs, it is probably not that hard to write the tests in most cases but I think I will need help to designate which properties should hold for which function ;--)
Tobias Pflug
@gilligan
I opened #1540 to ask for some input on what functions folks would like to see which properties tested for ;)
Scott Sauyet
@CrossEye
Don't know how much I'm going to be online in the next week. Maybe more than normal, maybe lots less. Finally taking my delayed (and reduced) trip to India. Cheers!
Tobias Pflug
@gilligan
Wow, enjoy!
Scott Sauyet
@CrossEye
Thanks. Work, not pleasure, but I'll try.
Tobias Pflug
@gilligan
hm, i am quite confused right now
R.equals(new Error('XXX'), new Error('XXX')) this evaluates to false - the tests in equals.js test for it to be true
if I run only the equals test it fails, if I run everything via npm run test it passes
?!?!
Scott Christopher
@scott-christopher
@gilligan I'm guessing you're running the individual test on v0.18, which was tagged a couple of days before this commit landed ramda/ramda@ba70cc5
Tobias Pflug
@gilligan
@scott-christopher i am on master
@scott-christopher working on a pull request
Scott Christopher
@scott-christopher
how did you run the individual test?
Tobias Pflug
@gilligan
basically just run mocha to run the individual file
@scott-christopher also just look at the output of the ramda repl
@scott-christopher it evaluates to false even though in the test it tests for equality to return true
Scott Christopher
@scott-christopher
Yeah, the repl is running v0.18
Tobias Pflug
@gilligan
ah, d'oh now i get you
Scott Christopher
@scott-christopher
try running npm run build beforehand if you're running mocha directly
or npm run pretest && mocha test/equals
Tobias Pflug
@gilligan
let me try
that works
and I don't understand why
can you enlighten me ? :)
Scott Christopher
@scott-christopher
the tests use dist/ramda.js, so you need to make sure that has the latest build from the current source
The dist/ramda.js that is commited is the build from the most recent tagged release.
so when you ran the test without running npm run build prior, it was using ramda v0.18, which didn't yet have the equals implementation for Error
running npm run test implicitly runs npm run pretest by convention of npm scripts prefixed with pre (and likewise for post).