*Threads^
however, we added custom spawn support recently, and you can see it in use here: https://github.com/rustwasm/wasm-bindgen/tree/master/examples/raytrace-parallel
(although github appears to be down at the moment)
I was thinking of defining a panic_handler that calls
process::exit(1)
But I want to make sure I don't lose any of the panic info (still want the messages printed)
Is this the right way to do it?
@sunjay isn't that already what you're asking for?
although rayon's panic handler really only applies to spawns -- other stuff, we just propagate panics to the caller
I'd like to immediately quit completely as soon as any panic occurs, not wait for all the workers to finish
Hence why I want to use process::exit(1) since that would immediately quit everything
I will use that
Thanks!
:smile:
Hello. FYI, seems that even with semver system, builds with older compiler are broken with old rayon crates. Thus, rayon compilation will fail on old systems as follows:
Compiling crossbeam-utils v0.6.6
error: 128-bit type is unstable (see issue #35118)
|
533 | impl_arithmetic!(u128, "let a = AtomicCell::new(7u128);");
| ^^^^
I am currently looking for a workaround, let me know if you have one already.
Having the .lock file available is one, which I don't have in this case :b
I am usually very conservative about rustc requirements on crates I maintain
but we decided to limit that to about a year old for rayon: https://github.com/rayon-rs/rfcs/blob/master/accepted/rfc0003-minimum-rustc.md
another workaround is to directly require
rayon-core = "~1.4" in your own Cargo.toml
to pair with
rayon = "~1.0", since 1.1 is the version that needs newer rayon-core too
(
~ restricts the minor version too, compared to normal semver policy)
@cuviper Thanks for the info! The problem is that even if our master has new Rust compiler, the maintenance branches (which may be several years older) do not have it and it won't be upgraded there. So I would be very conservative about changing requirements for old crate versions on the fly. If possible, such requirements should be done for new crate versions only. Here I was expecting that
rayon = "~1.0" would not update to rayon-core > 1.4, which needs newer compiler.
BTW, https://github.com/rayon-rs/rfcs/blob/master/accepted/rfc0003-minimum-rustc.md is very good. To me it looks like "Increases to our minimum supported Rust will also require a new minor release in the semantic version of rayon crates, not just a patch release" means that this is just a glitch here and in the future it should work.
so if you really need this, specifying
rayon-core = "~1.4" is also required to keep it back
I'm still "coming back online"
how are things?
things are good here
fairly quiet in rayon, at least :)
I poked at a new
spawn_future in #679, but I'm an amateur in this area
next week btw I'll be in PDX basically all week