Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 15 18:18
    jondot opened #696
  • Sep 14 19:35
    nikomatsakis synchronize #695
  • Sep 14 19:33
    nikomatsakis opened #695
  • Sep 13 14:14
    magnusmanske opened #694
  • Sep 09 23:08
    tiby312 edited #693
  • Sep 09 23:07
    tiby312 edited #693
  • Sep 09 23:04
    tiby312 edited #693
  • Sep 09 23:04
    tiby312 opened #693
  • Sep 06 21:01
    bors[bot] closed #692
  • Sep 06 21:01
    bors[bot] closed #687
  • Sep 06 21:01

    bors[bot] on master

    Link the iterator traits from t… Typo in docs Co-Authored-By: J… Merge #692 692: Link the itera… (compare)

  • Sep 06 19:33

    bors[bot] on staging.tmp

    (compare)

  • Sep 06 19:33

    bors[bot] on staging

    Merge #692 692: Link the itera… (compare)

  • Sep 06 19:33

    bors[bot] on staging.tmp

    Link the iterator traits from t… Typo in docs Co-Authored-By: J… [ci skip][skip ci][skip netlify… (compare)

  • Sep 06 19:33

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Sep 06 19:32
    vorner synchronize #692
  • Sep 06 19:25

    bors[bot] on staging.tmp

    (compare)

  • Sep 06 19:25

    bors[bot] on staging

    Link the iterator traits from t… Merge #692 692: Link the itera… (compare)

  • Sep 06 19:25

    bors[bot] on staging.tmp

    Link the iterator traits from t… [ci skip][skip ci][skip netlify… (compare)

  • Sep 06 19:24

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

Josh Stone
@cuviper
@jq-rs what old system are you running, where you don't have at least Rust 1.26?
I am usually very conservative about rustc requirements on crates I maintain
but we decided to limit that to about a year old for rayon: https://github.com/rayon-rs/rfcs/blob/master/accepted/rfc0003-minimum-rustc.md
another workaround is to directly require rayon-core = "~1.4" in your own Cargo.toml
to pair with rayon = "~1.0", since 1.1 is the version that needs newer rayon-core too
(~ restricts the minor version too, compared to normal semver policy)
jq-rs
@jq-rs
@cuviper Thanks for the info! The problem is that even if our master has new Rust compiler, the maintenance branches (which may be several years older) do not have it and it won't be upgraded there. So I would be very conservative about changing requirements for old crate versions on the fly. If possible, such requirements should be done for new crate versions only. Here I was expecting that rayon = "~1.0" would not update to rayon-core > 1.4, which needs newer compiler.
jq-rs
@jq-rs
BTW, https://github.com/rayon-rs/rfcs/blob/master/accepted/rfc0003-minimum-rustc.md is very good. To me it looks like "Increases to our minimum supported Rust will also require a new minor release in the semantic version of rayon crates, not just a patch release" means that this is just a glitch here and in the future it should work.
Josh Stone
@cuviper
unfortunately, even with rayon = "~1.0", cargo will still greedily choose the newest compatible rayon-core, and 1.5 is compatible with 1.4
so if you really need this, specifying rayon-core = "~1.4" is also required to keep it back
Josh Stone
@cuviper
@nikomatsakis sync?
Niko Matsakis
@nikomatsakis
@cuviper :wave:
Josh Stone
@cuviper
welcome back!
Niko Matsakis
@nikomatsakis
thanks :)
I'm still "coming back online"
how are things?
Josh Stone
@cuviper
I know the feeling, probably a mountain of email
things are good here
fairly quiet in rayon, at least :)
I poked at a new spawn_future in #679, but I'm an amateur in this area
Niko Matsakis
@nikomatsakis
ah, cool
next week btw I'll be in PDX basically all week
Josh Stone
@cuviper
hey, me too!
naturally
Niko Matsakis
@nikomatsakis
:)
i'll be busy tuesday but maybe wed we can grab a coffee or something, plot some plans
I still want to force @aturon to participate
I was going to say -- should I just go over PRs and look for reviews?
(at this moment, I mean)
Josh Stone
@cuviper
PRs are mostly old stuff
#679 as mentioned for Future
#673 is the genericity thing -- waiting to see if the related rust PR will land
#670 is kind of on hold -- I'm hoping crossbeam can improve their own allocation story
#629 has an api question about into_remainder
the rest is stale
Niko Matsakis
@nikomatsakis
ok
I'd like to check out the future thing
sorry, got distracted, I suck this week :)
probably we'll really get back going post rustconf
Josh Stone
@cuviper
sure :)
and yeah, meeting up wednesday would be nice
Josh Stone
@cuviper
@stjepang I saw the announcement of async-std, congrats!
now my question, would my rayon spawn_future be usable with this?
or would you just task::spawn(async { /* something using rayon */ })?
Stuart Axelbrooke
@soaxelbrooke
Howdy! I am seeing a globally built thread pool only spawn 1 thread (should be 4) - any tips on how to debug this? I observed this via a work queue where workers lock one of 4 resources (1 per thread) to do their work, but only 1 lock is ever being attempted at a time. The thread pool is used via something.into_par_iter().for_each(...).
Josh Stone
@cuviper
@soaxelbrooke what does rayon::current_num_threads() say?
Stuart Axelbrooke
@soaxelbrooke
I'll check, brb!
It's reporting 4 threads
Josh Stone
@cuviper
well at least that's what you expected :)
Stuart Axelbrooke
@soaxelbrooke
:P