by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 17 23:57

    cuviper on rayon-core-v1.8.1

    (compare)

  • Sep 17 22:23
    bors[bot] closed #800
  • Sep 17 22:23
    bors[bot] closed #797
  • Sep 17 22:23

    bors[bot] on master

    Use wrapping addition for JEC Add stable-i686 to CI for 32-bi… Use actions/checkout@v2 consist… and 3 more (compare)

  • Sep 17 22:04

    bors[bot] on staging.tmp

    (compare)

  • Sep 17 22:04

    bors[bot] on staging

    Use wrapping addition for JEC Add stable-i686 to CI for 32-bi… Use actions/checkout@v2 consist… and 3 more (compare)

  • Sep 17 22:04

    bors[bot] on staging.tmp

    Use wrapping addition for JEC Add stable-i686 to CI for 32-bi… Use actions/checkout@v2 consist… and 3 more (compare)

  • Sep 17 22:04

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Sep 17 21:58
    cuviper synchronize #800
  • Sep 17 19:38
    cuviper opened #802
  • Sep 17 18:41
    SuperFluffy edited #801
  • Sep 17 18:41
    SuperFluffy edited #801
  • Sep 17 18:25
    SuperFluffy edited #801
  • Sep 17 18:25
    SuperFluffy edited #801
  • Sep 17 18:18
    SuperFluffy edited #801
  • Sep 17 18:17
    SuperFluffy opened #801
  • Sep 15 22:40

    bors[bot] on trying.tmp

    (compare)

  • Sep 15 22:40

    bors[bot] on trying.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Sep 15 22:19

    bors[bot] on trying.tmp

    (compare)

  • Sep 15 22:19

    bors[bot] on trying

    Try #800: (compare)

Niko Matsakis
@nikomatsakis
yes
Josh Stone
@cuviper
I think it's ok to have that in debug by default, with env control
Niko Matsakis
@nikomatsakis
ok
Josh Stone
@cuviper
or at least, I think that's what we have already
Niko Matsakis
@nikomatsakis
not sure
I can't remember
anyway, it's easy enough to change
this comment probably suffices
//! Debug Logging
//!
//! To use in a debug build, set the env var `RAYON_RS_LOG=1`.  In a
//! release build, logs are compiled out by default unless Rayon is built
//! with `--cfg rayon_rs_log` (try `RUSTFLAGS="--cfg rayon_rs_log"`).
//!
//! Note that logs are an internally debugging tool and their format
//! is considered unstable, as are the details of how to enable them.
I think that's the only place they're documented
that comment is also out of date, I realize now
Josh Stone
@cuviper
not sure why you switched to just RAYON_RS_LOG, compared to RAYON_NUM_THREADS
Niko Matsakis
@nikomatsakis
the new format would be RAYON_RS_LOG=all
or something like that
Josh Stone
@cuviper
on master, it said:
//! **Old environment variable:** `RAYON_LOG` is a one-to-one
//! replacement of the now deprecated `RAYON_RS_LOG` environment
//! variable, which is still supported for backwards compatibility.
I don't really worry about compatibility, just weird that you went for the deprecated one
that's just a nit though
Niko Matsakis
@nikomatsakis
heh
nikomatsakis @nikomatsakis has no excuse
Niko Matsakis
@nikomatsakis
I can change it :)
done
Josh Stone
@cuviper
ok
I'll try to give that a proper review today
Niko Matsakis
@nikomatsakis
I will try to update the RFC, but I've said it before :P
but it's still on my to do list, staring at me in the face
at least I can add a link to the youtube video
I would like to see it updated, and to update the docs in tree
up-to-date docs seems imp't to me :)
it's probably not that out of date
also, you should push your changes re: the segfault
Josh Stone
@cuviper
I just did
Niko Matsakis
@nikomatsakis
+1
Josh Stone
@cuviper
uh oh, you failed formatting...
Niko Matsakis
@nikomatsakis
heh I wondered about that
Josh Stone
@cuviper
have you seen that I switched to GitHub Actions, btw? I love how that looks
Niko Matsakis
@nikomatsakis
I saw some kind of error related to Cargo.lock?
I did see, very cool
Josh Stone
@cuviper
oh, yeah, if you changed dependencies, the compat lock needs to be updated
Niko Matsakis
@nikomatsakis
applied cargo fmt
I'm not sure how to update the dependencies though
I don't .. did I chagne anything?
Josh Stone
@cuviper
an annoying manual step, but this avoids the problem of our transitive dependencies maybe not holding strict MSRV
Niko Matsakis
@nikomatsakis
I might've added something for the log
Josh Stone
@cuviper
you added crossbeam-channel
Niko Matsakis
@nikomatsakis
ah yeah
Josh Stone
@cuviper
I'll update it
use of unstable library feature 'integer_atomics' (AtomicU64)
on 1.31.0
needs 1.34, but do all 32-bit targets have AtomicU64 anyway?