by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 11:08
    DzmitryFil opened #781
  • Aug 04 10:11
    nikomatsakis synchronize #746
  • Aug 03 19:55
    DzmitryFil closed #780
  • Aug 01 20:18
    DzmitryFil edited #780
  • Aug 01 19:44
    DzmitryFil opened #780
  • Jul 29 22:03
    couchand closed #779
  • Jul 29 19:20
    cuviper labeled #779
  • Jul 29 18:05
    couchand opened #779
  • Jul 24 03:07
    cuviper closed #776
  • Jul 21 19:46
    bors[bot] closed #771
  • Jul 21 19:46
    bors[bot] closed #770
  • Jul 21 19:46
    bors[bot] closed #770
  • Jul 21 19:46

    bors[bot] on master

    par_iter for Range<char> par_iter for RangeInclusive<cha… Allow char iter tests to run on… and 4 more (compare)

  • Jul 21 19:39

    bors[bot] on staging.tmp

    (compare)

  • Jul 21 19:39

    bors[bot] on staging

    par_iter for Range<char> par_iter for RangeInclusive<cha… Allow char iter tests to run on… and 4 more (compare)

  • Jul 21 19:39

    bors[bot] on staging.tmp

    par_iter for Range<char> par_iter for RangeInclusive<cha… Allow char iter tests to run on… and 4 more (compare)

  • Jul 21 19:39

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Jul 18 14:05
    v1gnesh opened #778
  • Jul 16 19:48
    bors[bot] closed #777
  • Jul 16 19:48

    bors[bot] on master

    Warn on rust-2018-idioms Fix elided_lifetimes_in_paths Fix clippy::let_underscore_lock and 3 more (compare)

Niko Matsakis
@nikomatsakis
or something like that
Josh Stone
@cuviper
on master, it said:
//! **Old environment variable:** `RAYON_LOG` is a one-to-one
//! replacement of the now deprecated `RAYON_RS_LOG` environment
//! variable, which is still supported for backwards compatibility.
I don't really worry about compatibility, just weird that you went for the deprecated one
that's just a nit though
Niko Matsakis
@nikomatsakis
heh
nikomatsakis @nikomatsakis has no excuse
Niko Matsakis
@nikomatsakis
I can change it :)
done
Josh Stone
@cuviper
ok
I'll try to give that a proper review today
Niko Matsakis
@nikomatsakis
I will try to update the RFC, but I've said it before :P
but it's still on my to do list, staring at me in the face
at least I can add a link to the youtube video
I would like to see it updated, and to update the docs in tree
up-to-date docs seems imp't to me :)
it's probably not that out of date
also, you should push your changes re: the segfault
Josh Stone
@cuviper
I just did
Niko Matsakis
@nikomatsakis
+1
Josh Stone
@cuviper
uh oh, you failed formatting...
Niko Matsakis
@nikomatsakis
heh I wondered about that
Josh Stone
@cuviper
have you seen that I switched to GitHub Actions, btw? I love how that looks
Niko Matsakis
@nikomatsakis
I saw some kind of error related to Cargo.lock?
I did see, very cool
Josh Stone
@cuviper
oh, yeah, if you changed dependencies, the compat lock needs to be updated
Niko Matsakis
@nikomatsakis
applied cargo fmt
I'm not sure how to update the dependencies though
I don't .. did I chagne anything?
Josh Stone
@cuviper
an annoying manual step, but this avoids the problem of our transitive dependencies maybe not holding strict MSRV
Niko Matsakis
@nikomatsakis
I might've added something for the log
Josh Stone
@cuviper
you added crossbeam-channel
Niko Matsakis
@nikomatsakis
ah yeah
Josh Stone
@cuviper
I'll update it
use of unstable library feature 'integer_atomics' (AtomicU64)
on 1.31.0
needs 1.34, but do all 32-bit targets have AtomicU64 anyway?
I thought we talked about using AtomicUsize instead
Niko Matsakis
@nikomatsakis
I think we probably did
I have a vague memory of that
Josh Stone
@cuviper
and how that would limit the number of threads, but <256 threads for 32-bit is probably fine
though we need to enforce that
frankly, over 256 threads is probably past diminishing returns even on 64-bit targets
Niko Matsakis
@nikomatsakis
ah yeah I remember that I wanted to document those flags
and convince myself that rollover was good
let's start (on the PR?) a to-do list of things to track
Niko Matsakis
@nikomatsakis
Ok, I did that, feel free @cuviper to edit and add add'l items
should've done this a while back
Niko Matsakis
@nikomatsakis
heh, I found the dropbox paper that we created during that video, it has some of these work items too
Zhengyi Yang
@zhengyi-yang
Is there a par_drain method in rayon?