by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 19:01
    XAMPPRocky edited #591
  • Jul 08 16:03
    linweijun opened #775
  • Jul 05 19:04
    bors[bot] closed #774
  • Jul 05 19:04

    bors[bot] on master

    Note that collect_into_vec is i… Merge #774 774: Note that coll… (compare)

  • Jul 05 18:57

    bors[bot] on staging.tmp

    (compare)

  • Jul 05 18:57

    bors[bot] on staging

    Note that collect_into_vec is i… Merge #774 774: Note that coll… (compare)

  • Jul 05 18:57

    bors[bot] on staging.tmp

    Note that collect_into_vec is i… [ci skip][skip ci][skip netlify… (compare)

  • Jul 05 18:57

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Jun 23 14:25
    SuperFluffy opened #774
  • Jun 21 11:51
    Jasper-Bekkers closed #576
  • Jun 20 18:57
    bergkvist edited #773
  • Jun 20 18:56
    bergkvist opened #773
  • Jun 19 23:17
    bergkvist edited #772
  • Jun 19 23:16
    bergkvist opened #772
  • Jun 19 01:15
    CAD97 synchronize #771
  • Jun 19 01:14
    CAD97 synchronize #771
  • Jun 19 01:12
    CAD97 synchronize #771
  • Jun 18 22:24
    CAD97 synchronize #771
  • Jun 18 21:51
    CAD97 synchronize #771
  • Jun 18 21:41
    CAD97 synchronize #771
Niko Matsakis
@nikomatsakis
it's probably not that out of date
also, you should push your changes re: the segfault
Josh Stone
@cuviper
I just did
Niko Matsakis
@nikomatsakis
+1
Josh Stone
@cuviper
uh oh, you failed formatting...
Niko Matsakis
@nikomatsakis
heh I wondered about that
Josh Stone
@cuviper
have you seen that I switched to GitHub Actions, btw? I love how that looks
Niko Matsakis
@nikomatsakis
I saw some kind of error related to Cargo.lock?
I did see, very cool
Josh Stone
@cuviper
oh, yeah, if you changed dependencies, the compat lock needs to be updated
Niko Matsakis
@nikomatsakis
applied cargo fmt
I'm not sure how to update the dependencies though
I don't .. did I chagne anything?
Josh Stone
@cuviper
an annoying manual step, but this avoids the problem of our transitive dependencies maybe not holding strict MSRV
Niko Matsakis
@nikomatsakis
I might've added something for the log
Josh Stone
@cuviper
you added crossbeam-channel
Niko Matsakis
@nikomatsakis
ah yeah
Josh Stone
@cuviper
I'll update it
use of unstable library feature 'integer_atomics' (AtomicU64)
on 1.31.0
needs 1.34, but do all 32-bit targets have AtomicU64 anyway?
I thought we talked about using AtomicUsize instead
Niko Matsakis
@nikomatsakis
I think we probably did
I have a vague memory of that
Josh Stone
@cuviper
and how that would limit the number of threads, but <256 threads for 32-bit is probably fine
though we need to enforce that
frankly, over 256 threads is probably past diminishing returns even on 64-bit targets
Niko Matsakis
@nikomatsakis
ah yeah I remember that I wanted to document those flags
and convince myself that rollover was good
let's start (on the PR?) a to-do list of things to track
Niko Matsakis
@nikomatsakis
Ok, I did that, feel free @cuviper to edit and add add'l items
should've done this a while back
Niko Matsakis
@nikomatsakis
heh, I found the dropbox paper that we created during that video, it has some of these work items too
Zhengyi Yang
@zhengyi-yang
Is there a par_drain method in rayon?
Josh Stone
@cuviper
@zhengyi-yang there's not, but I think we could support that fairly easily. could you file an enhancement issue?
easy for Vec, at least -- I don't think we could do that for other collections without access to more internals
Zhengyi Yang
@zhengyi-yang
@cuviper No problem. Thanks Josh.
Niko Matsakis
@nikomatsakis
hey @cuviper not sure I can make the sync today, but I have nothing to add beyond the work I did on the PR recently -- I think the next step I had in mind is to update RFC a bit and to run some measurements, but I was expecting you would need time to review the code in more detail in any case
I see there's a lot of notifications though (been trying to stay on top of that...) and I might try to go through some of them over next few days
I'm expecting to be on "stay-cation" at home, but then again I tend to count time working on rayon as fun vacation anyway :)
Josh Stone
@cuviper
@nikomatsakis ok, no worries, I still owe you a new review on that
I'll always welcome your input on general issues and such too, when you have the time :)
Niko Matsakis
@nikomatsakis
:heart:
Zhengyi Yang
@zhengyi-yang
Is it possible to implement rayon's par_iter and into_par_iter for crossbeam::queue?
Josh Stone
@cuviper
hmm, maybe -- we'd have to do it ourselves, not in crossbeam, to keep the dependency order straight
it would be an unindexed producer
@zhengyi-yang they don't implement plain Iterator either
Zhengyi Yang
@zhengyi-yang
@cuviper Thanks Josh. I see. So for now if I want to do some parallel to a queue, is it efficient to use something like (0..queue.len()).into_par_iter().map(|_| {queue.deque()})?
Josh Stone
@cuviper
I guess you mean queue.pop()? that would be efficient enough, sure, although it will just fail, not block, if the queue is empty
if you know nothing else will be pushing/popping, that should be fine