I'm thinking we may need to rearrange the project structure when it comes to the tests. Mocha does not look for tests in a tests directory by default, and you have told mocha to look for tests in
'src/components/**/*.test.js'. So either we need to do something like tell Mocha to look for tests in 'src/components/**/__tests__/*.test.js' or change where the tests are located in the project structure.
@joshdenz It does look for test files in
__test__ directory. Since src/components/**/*.test.jsserves the same purpose as src/components/**/__tests__/*.test.js in our case as we are going to put test files only in the __tests__ folder. However, if we would like to keep it self explanatory, then we can do something like src/components/*/__tests__/*.test.js but I don't really feel like it is necessary since we're going to maintain the structure anyways.
also one last thing regarding test location, in the package.json file you need to use double quotes for the test path rather than single quotes. You've got to use the escape char for double quotes so you can use two sets of them on your test line.
@joshdenz using single / double quotes really don't matter since both denote strings in shell.
Hey guys. Just an FYI here, your dependencies has 1 high severity vulnerability requiring an update to webpack-dev-server v3.1.14
A low severity issue that has been popping up every now and then in repositories. I'll update them though. Thanks for reminding!
Also, I was thinking about having separate test files for each category, as in ,
@joshdenz @KRRISH96 what are your thoughts on that?
render.test.js for render tests, accessibility.test.js for accessibility tests, edgecase.test.js for edge case tests ( if any ) and so on.@joshdenz @KRRISH96 what are your thoughts on that?
The things I suggested were the things that were required to actually run the tests in my environment. After cloning the repo and installing dependencies running
npm test resulted in no tests being found. I needed to explicitly specify the __tests__ folder in package.json and I needed to use escaped double quotes for the path else no tests were found.
My apologies if everything was running smoothly in your environment.
Did you start writing tests?
I'm working on more components.
@KRRISH96 has started working on the library too and we're also looking for more developers online to start contributing. Hoping to see the activity increase in the repository.