Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    John Peele
    @johnpeele
    Oh hmmm... I just went with the plugin build instructions and that worked. The render script doesn't seem to render anything to my blank Sketch doc
    Jon Gold
    @jongold
    hmmm
    @johnpeele what version of sketch?
    are there any errors in console?
    John Peele
    @johnpeele
    v43.2
    Jon Gold
    @jongold
    hmmm
    @briannhinton sorry, lost track of this tab :D
    uploaded a zip because I haven't had time to check the code
    you need a google translate API key (because I don't know if it's a huge deal if I share mine) - put it in src/translate.js
    Yifan Zhang
    @yifan
    Hi, I am following the instruction for examples, I am getting this error:
    🖨  Copied src/manifest.json in 13ms
    Executing post-build scripts
    🛠  Built ./my-command.js in 1285ms
    Unknown command ‘run’
    this is after npm run render
    Yifan Zhang
    @yifan
    Usage: sketchtool <command> [<args>]
                      [--formats=<string> | -f <string>]
                      [--use-id-for-name{=YES|NO} | --no-use-id-for-name | -n {<YES|NO>}]
                      [--max-size=<float> | -m <float>]
                      [--item=<string> | -i <string>]
                      [--items=<string> | -a <string>]
                      [--background=<string> | -g <string>]
                      [--compression=<float> | -c <float>]
                      [--reveal{=YES|NO} | --no-reveal | -r {<YES|NO>}]
                      [--outputJSON=<path> | -J <path>]
                      [--include-symbols{=YES|NO} | --no-include-symbols | - {<YES|NO>}]
                      [--bounds=<rectangle> | -b <rectangle>]
                      [--version | -v] [--filename=<string> | -F <string>]
                      [--scales=<path> | -s <path>]
                      [--compact{=YES|NO} | --no-compact | -k {<YES|NO>}]
                      [--overwriting{=YES|NO} | --no-overwriting | -V {<YES|NO>}]
                      [--trimmed{=YES|NO} | --no-trimmed | -t {<YES|NO>}]
                      [--group-contents-only{=YES|NO} | --no-group-contents-only | -G {<YES|NO>}]
                      [--help | -h]
                      [--include-namespaces{=YES|NO} | --no-include-namespaces | -N {<YES|NO>}]
                      [--progressive{=YES|NO} | --no-progressive | -p {<YES|NO>}]
                      [--save-for-web{=YES|NO} | --no-save-for-web | -w {<YES|NO>}]
                      [--output=<path> | -o <path>]
    Yifan Zhang
    @yifan
    node v7.9.0 npm v4.5.0
    npm ERR! Tell the author that this fails on your system:
    npm ERR!     skpm build --watch --run
    Yifan Zhang
    @yifan
    it looks like that I need to update Sketch
    Yifan Zhang
    @yifan
    okay, I am getting
    TypeError: null is not an object (evaluating 'context.document.currentPage')
    line: 9250
    column: 114
    Yifan Zhang
    @yifan
    working now.
    Dominik Michna
    @conymaniac

    I have similar problem as @johnpeele.

    Followed instructions here http://airbnb.io/react-sketchapp/ and nothing render to my sketch. When I close sketch (43.2) and hit render (npm run render), sketch opens at introduction page or with dialog message to open file.

    Tried different example (foursquare-maps), same problem. Render to web (npm run web) works great.

    Get error about deprecated loadingUtils.parseQuery().

    🖨  Copied src/manifest.json in 12ms
    (node:54160) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
    parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
    Executing post-build scripts
    🔨  Built ./main.js in 3329ms
    (null)

    node v6.10.2, npm 3.10.10, mac OS v10.12.4

    Jon Gold
    @jongold
    @johnpeele @conymaniac are you getting anything at all in your console? have you tried restarting Sketch?
    what path is Sketch located at?
    I need more info to try to help :(
    Dominik Michna
    @conymaniac

    @jongold Tried also styleguide example, same problem. After hit render, it shows me copied manifesto and build ./main.js. And (null) (as code above). And than only post-build script. No error.

    I restarted sketch, also closed it completely. When its closed and hit render, sketch opens only to dialog message. When I open new blank file, window with sketch still gets focused (i guess thanks to post-build script which keep repeating).

    Sketch is in Application folder and repo with react-sketch.app is on iCloud drive. I cant access to computer now to post full path (I'm sorry, battery ran out and I forgot charger - have to wait to tomorrow).

    Jon Gold
    @jongold
    is the path /Applications/Sketch.app or /Applications/Sketch 3.app?
    also, can you try dragging react-sketchapp to your desktop and running from there?
    there was a bug that was doing weird things if it was inside a folder with spaces in the name
    (weird huh?)
    sorry for the hiccups, appreciate you patience
    Dominik Michna
    @conymaniac
    Thank you! I will try it tomorrow and let you now. React-sketch.app seems like a really big thing!
    Jon Gold
    @jongold
    :)
    Dominik Michna
    @conymaniac

    I've changed path to React-sketch.app and works great. Thank you.

    iCloud Drive path:
    /Users/user.name/Library/Mobile\ Documents/com~apple~CloudDocs/

    Working path:
    /Users/user.name/Workspace/react-sketchapp/

    Jon Gold
    @jongold
    woo. hopefully that issue will be fixed in skpm soon :)
    Sebastian Scholle
    @sscholle_twitter
    @jongold Does the code used to render in Sketch, also get used in the final production App? How does the code (source of truth) translate into the final product?
    Erik
    @esthor
    @jongold Hi Jon. I’m giving a talk and demo of your library tonight at a React + Sketch meetup. I spent some time this weekend trying to wrap my head around it (I naively thought it was something simpler). I’m still trying to understand it, like how it works in production, tooling stacks needed and all that jazz. But the biggest thing for me was react primitives. While I continue down that path, I wanted to ask: Is it fair/accurate to say that react-sketchapp is part of a fork of react primitives, to make a sort of 'react-sketch primitives’ (a common language across react/rn/sketch)?
    Jon Gold
    @jongold
    @sscholle_twitter sorry, missed that :( yes! we're rendering our real components in Sketch :)
    possible workflows:
    • render stickersheets for designers to use with our design system components
    @esthor hey! I have no idea what timezone you're in, sorry if this is too late :(
    it's not a fork of primitives — indeed it's integrated in primitives
    react -primitives is a common set of components shared across platforms that then delegates to the corresponding platform when you render
    so rather than import { View } from 'react-native' you'd import { View } from 'react-primitives' and then your build tool would decide whether it wanted react-native or react-native-web or react-sketchapp components
    there are other ways to achieve it without using react-primitives at all, but react-primitives is a coworker's project so I'm kinda biased
    Erik
    @esthor
    @jongold Whoa. Can I just come and shadow you guys for a week? :smile: This is a really fascinating philosophy/workflow. I am curious about the tooling on the build side, the efficiency of using such a system (like, at what level of total component and view library complexity it makes sense), what portion of cross-platform production would primitives (or other 'rn-everywhere’) probably encompass, and what the design-side workflow would be like. Do you have any advice or recommendations on where to start looking for answers? (We use React for web and React-native for mobile, so I am already sold on the idea at least of a unified library of primitives/rn-web/rn-everywhere.) P.S. I saw your response, and that sweet tweet just moments after the talk. Is that component library tooling shown in the video going to be published? I was asked to give a follow-up talk :wink: Also, do you guys plan to develop and grow this openly long-term (both react-sketchapp and react-primitives)? Sorry if it’s too many questions.
    James Khatiblou
    @theonlyjames
    Is Sketch 48.1 supported by react-sketchapp? I'm assuming no.
    Also is anyone else getting this error after running npm run render in basic-setup example? Node 9.3.0 & npm 5.6.0 & Sketch 48.1
    UnhandledPromiseRejectionWarning: TypeError: execFile is not a function
    James Khatiblou
    @theonlyjames
    @jongold can you help please?!
    James Khatiblou
    @theonlyjames
    Also in the console I'm getting
    TypeError: MSAttributedString.alloc().initWithAttributedString is not a function. (In 'MSAttributedString.alloc().initWithAttributedString(attribStr)', 'MSAttributedString.alloc().initWithAttributedString' is undefined)
    line: 2957
    sourceURL: /Users/jkhat/Code/tmp/Sketch/react-sketchapp/examples/basic-setup/basic-setup.sketchplugin/Contents/Sketch/my-command.js
    column: 72
    Thomas Brasington
    @tbrasington
    Sketch 48 issue fix is here
    airbnb/react-sketchapp#214 @theonlyjames
    petere-kgb
    @petere-kgb
    how stable is this tool?