Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 03 21:41
    dbbk commented #5304
  • Mar 02 16:31
    MohanNarayana closed #6261
  • Mar 01 17:51
    nnnnat assigned #6261
  • Feb 26 20:18
    nnnnat commented #6322
  • Feb 25 15:31
    loan-laux commented #6261
  • Feb 23 16:22
    emiquelito commented #6322
  • Feb 23 16:22
    emiquelito commented #6322
  • Feb 23 15:26
    nnnnat closed #6234
  • Feb 23 15:25
    nnnnat closed #6322
  • Feb 22 23:45
    emiquelito edited #6322
  • Feb 22 23:32
    emiquelito labeled #6322
  • Feb 22 23:32
    emiquelito opened #6322
  • Feb 22 12:30
    loan-laux commented #6234
  • Feb 10 20:16

    MohanNarayana on v3.11.1

    (compare)

  • Feb 09 21:03

    Akarshit on trunk

    Release v3.11.1 Signed-off-by:… Release v3.11.1 Signed-off-by:… Merge branch 'trunk' of https:/… and 2 more (compare)

  • Feb 09 21:03
    Akarshit closed #6319
  • Feb 09 21:03
    jrw421 edited #6319
  • Feb 09 20:54
    jrw421 synchronize #6319
  • Feb 09 20:54

    jrw421 on release-next-v3.11.1

    Release v3.11.1 Signed-off-by:… (compare)

  • Feb 09 20:52
    jrw421 synchronize #6319
Eduard-Hasa
@Eduard-Hasa
I was able to easily do it in the storefront but finding it more difficult on the reaction admin
Also for some reason the whole reaction admin’s font is messed up by default for some reason. It seems like google fonts are not importing properly so it defaults to a italics crappy font
rondlite
@rondlite
@Eduard-Hasa I get "Source Sans Pro", "Roboto", "Helvetica Neue", Helvetica, sans-serif; as the font-family in admin.. so there is plenty to pick from for the browser you would think
Eduard-Hasa
@Eduard-Hasa
@rondlite Im not advocating that we should of been given more fonts to choose from im just trying to understand the configuration
image.png
The font is this weird font that I think might be a result of a bug somewhere in the default project
rondlite
@rondlite
what you get as font-family when you inspect the computed element of a text field?
I mean seems your whole font-family is not set as intended there
Eduard-Hasa
@Eduard-Hasa
font-family: "Source Sans Pro", "Roboto", "Helvetica Neue", Helvetica, sans-serif
rondlite
@rondlite
does the page shift to the italics version or is that rendered at first cycle like that
Eduard-Hasa
@Eduard-Hasa
Its like that always. Seems to me like its the reaction admin project because I have refreshed the whole project multiple times with the issue persisting. I think I seen it a version or two ago.
image.png
Its like that everywhere. I tried debugging this 2 weeks ago and I think I concluded that it was something with the fonts not importing properly from fontawesome or wherever they are pulling them from.
Loan Laux
@loan-laux
@Eduard-Hasa Very strange issue, I have to say. The problem with the styling of the admin is that it comes from at least three places: legacy leftover LESS files, “local” styled-components within the imports/* folders, and CSS-in-JS code included in the Catalyst components themselves. Definitely not easy to change stuff with a setup like that.
rondlite
@rondlite
@loan-laux @Eduard-Hasa and there is the occasional const useStyles = makeStyles({ card: { overflow: "visible" } }); in places too ......
Loan Laux
@loan-laux
Yep @rondlite. Definitely needs a big overhaul using just makeStyles with a common MUI theme, just like the example-storefront. Of course this will be the case of that new admin UI project which is in the pipeline. But I doubt we’ll see that happen on reaction-admin. Too much work.
Eduard-Hasa
@Eduard-Hasa
@loan-laux lol yeah I think the new version they have coming will be much better.
Do you guys not have this weird font showing up? Ive tried multiple deployments with the issue persisting.
rondlite
@rondlite
@loan-laux we just updated storefront to be nextjs10.. (woooorth it !!) and to have typescript (feels safer for frontend) .. the suggestion to change storefront to ts was not received well in community so we did for ourselfs
Loan Laux
@loan-laux
@rondlite Glad to hear that. Next 10 + TS is a killer combo! I especially love Next 10’s image optimization. Their team did an amazing job.
rondlite
@rondlite
the speed is insane.. having image on first paint is just funny.. ttfb 130ms, fcp 0.5s
Eduard-Hasa
@Eduard-Hasa
@rondlite do you guys have your own storefront application or is the example storefront project pretty simple to update to nextjs10
Eduard-Hasa
@Eduard-Hasa
image.png
@rondlite this is what I mean by something is up with the fonts not importing properly.. The default font should be Helvetica
Loan Laux
@loan-laux
@Eduard-Hasa Some components (especially from Catalyst) might override this font rule. Pretty sure that’s what’s happening here.
Eduard-Hasa
@Eduard-Hasa
Ah okay thanks Ill look into it.
Matthew McKenzie
@MojoDaHacker

Installing dependencies...

(Using Yarn because there is a yarn.lock file)

yarn install v1.21.1

[1/4] Resolving packages...

[2/4] Fetching packages...

error An unexpected error occurred: "/home/node/.cache/yarn/v6/npm-@material-ui-icons-4.11.2-b3a7353266519cd743b6461ae9fdfcb1b25eb4c5-integrity/node_modules/@material-ui/icons/.yarn-metadata.json: Unexpected token \u0000 in JSON at position 0".

info If you think this is a bug, please open a bug report with the information provided in "/usr/local/src/app/yarn-error.log".

info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

rondlite
@rondlite
@Eduard-Hasa we got own design but is all based on the example storefront which is pretty easy to change
Matthew McKenzie
@MojoDaHacker
this is the error I'm receiving. Off a make clean restart, then make init-dev, then this error shows up while trying to start the example storefront.
Loan Laux
@loan-laux
@MojoDaHacker Can you make sure to delete your storefront’s volumes/container and then restart the service?
rondlite
@rondlite
@MojoDaHacker you might want to do a yarn cache clean the error you posted is sort of described here too https://stackoverflow.com/questions/31547789/why-am-i-getting-unexpected-token-u0000-when-using-npm-install-g-package
Eduard-Hasa
@Eduard-Hasa
@loan-laux Your right! I didnt realize we were getting defaultTheme from @reactioncommerce/catalyst. Is there an easy way to develop on the catalyst package locally with live refresh changes?
Eduard-Hasa
@Eduard-Hasa
Also what is the recommended method to debug the reaction-admin dashboard plugins. For example im creating a layout and if there are any rendering errors the plugin just disappears and I have no logs or anything to reference to
rondlite
@rondlite
@Eduard-Hasa how do you mean? don't you get dev console output of the plugin?
Eduard-Hasa
@Eduard-Hasa
@rondlite It shows warnings and errors sometimes but a lot of stuff also does not. There are many instances where I will see a blank white screen because there are issues in the plugin code and see no error in the docker container logs. I could of sworn I seen somewhere that you can enable development level logs or something..
Is that even the best method of debugging? Man I wish Nextjs was in the backend too. The storefront is such a beautiful project lol
Loan Laux
@loan-laux
@Eduard-Hasa On the storefront, there’s a local component context which allows you to locally override any component you get from the Reaction Component Library. Unfortunately there’s no such local context on reaction-admin for Catalyst components… For the defaultTheme though, the only solution appears to locally mutate the defaultTheme that you’re getting from Catalyst before passing it on to your MuiThemeProvider. Anybody let me know if there’s a better way.
Eduard-Hasa
@Eduard-Hasa
Okay I thought so. I made it work I was just curious. Thanks
Optimisticcc
@Optimisticcc
how to create custom plugin in core and plugin route graphql for it?. any tutorial to do this? i am new with RC. I want to create paypal payment how can i do?
Eduard-Hasa
@Eduard-Hasa
Yup check the docs everything is there.
Sid-Turner-Ellis
@Sid-Turner-Ellis
Hiya, I have been trying to get this up and running without docker
Keep getting an error that my API keys are missing in my environment variables, Is this a known error?
Loan Laux
@loan-laux
@Sid-Turner-Ellis Have you tried adding the env vars that it says are missing?
Sid-Turner-Ellis
@Sid-Turner-Ellis
Yep, They have all been added @loan-laux
Loan Laux
@loan-laux
@Sid-Turner-Ellis And you’re still getting a message telling you they’re missing? On which sub-project is this and how did you add these env vars?
Sid-Turner-Ellis
@Sid-Turner-Ellis
Just added them straight to the .env file that was created after running bin/setup
I just cloned the repo and followed the guide for the setup that doesn't use docker
Loan Laux
@loan-laux
@Sid-Turner-Ellis The setup that doesn’t use Docker? I’m not sure we have any. Did you use the make command as part of reaction-development-platform?
Sid-Turner-Ellis
@Sid-Turner-Ellis
On the site there seems to be a non docker version?
Loan Laux
@loan-laux
@Sid-Turner-Ellis Last time I checked, the docs for v3 say explicitely that running outside of Docker isn’t officially supported… Are you looking at the v1 or v2 docs by any chance?