These are chat archives for reactioncommerce/reaction

8th
Dec 2014
Brad Davis
@thecolorblue
Dec 08 2014 00:12
Thanks @aaronjudd. Would the CustomMetafield be added to the product schema?
Aaron Judd
@aaronjudd
Dec 08 2014 02:42
@thecolorblue you might be able to just reassign
ReactionCore.Schemas.Metafield = new SimpleSchema([ ReactionCore.Schemas.Metafield
I'm not sure if you'd need to give it a new name, or reattach it.
otherwise, you'd need to update the product schema as well
Oleg Shilov
@olegshilov
Dec 08 2014 15:04
@aaronjudd from where bootstrap theme variables are taken when assembling core-theme? changing packages/reaction-core-theme/default/variables.less does not lead to any changes.
Oleg Shilov
@olegshilov
Dec 08 2014 15:21
i see it taken from client/themes/custom.reaction.import.less but if I understand correctly variables should be taken from packages/reaction-core-theme/default/variables.less
Aaron Judd
@aaronjudd
Dec 08 2014 16:46
@olegshilov - make sure you have the latest pull, should be 1.0.3, just in case to make sure we’re on the same version. the way it should work is the variables.less is compiled into custom.reaction.import.less, and are used by import into custom.reaction.less
if you had an earlier version, remove all the *.less files in client/themes
and they will rebuild
I think the first version put the variables in the wrong file
and it the build process won’t rebuild the the custom.*.import.less files if they already exists (as they are meant to be customized)
Aaron Judd
@aaronjudd
Dec 08 2014 16:52
it’s working if you see line 14 of custom.reaction.import.less has the Roboto font
Everest Liu
@evliu
Dec 08 2014 18:48
do you guys test on multiple browsers?
Aaron Judd
@aaronjudd
Dec 08 2014 18:57
@evliu yes, I test on latest editions FF, Safari, Chrome (all on Mac) - once in a blue moon I'll fire up a windows machine and test in IE - but I don't keep that very current (eventually I will). I also test in mobile and tablet- Safari, Chrome, FF - I have physical devices for Android (nexus 4), iPad Mini, iPad, iPhone, Fire, that I test on as well as the simulators
that said -I don't test every change, and it's been a while since I did a full test on all platforms - but if you see something let me know and I can go through the full suite
Everest Liu
@evliu
Dec 08 2014 18:58
sweet. i’m wondering how to take care of the background for scroll-bouncing in safari
you know what i’m talking about?
Aaron Judd
@aaronjudd
Dec 08 2014 18:59
not sure..
the text in the footer on safari?
Everest Liu
@evliu
Dec 08 2014 19:00
when you scroll above or below the page content, there’s a springy effect where it goes beyond the page or below the page
let me see if a can get a screenshot
Aaron Judd
@aaronjudd
Dec 08 2014 19:00
I think I know what you mean, I was noticing this yesterday
Everest Liu
@evliu
Dec 08 2014 19:01
it’s one of those caveats with safari, haha, but safari is still my browser of choice even though debugging is better on chrome
Aaron Judd
@aaronjudd
Dec 08 2014 19:02
do all bootstrap sites give this error in safari: "Unexpected CSS token: :" for the IE filters? I was wondering about fixing that as well in safari
Everest Liu
@evliu
Dec 08 2014 19:03
oh is that what it is? i always see it but i ignore it, let me ask my UI guy
Ben Stocks
@bstocks
Dec 08 2014 19:03
I’ve seen that on several other sites
Aaron Judd
@aaronjudd
Dec 08 2014 19:04
I usually filter it out, as it's in the core bootstraps use of filter: progid:DXImageTransform.Microsoft.BasicImage(rotation=1);
@evliu I'm not sure the solution for the safari 'bounce' issue
Everest Liu
@evliu
Dec 08 2014 19:05
i’ll look into it sometime
microsoft breaks things often (in context of bootstrap and more)
Everest Liu
@evliu
Dec 08 2014 19:11
was there something i need to do after pulling the new reaction-core@0.2.2 for the theme to work again? can’t find it in the instructions. i added the reactioncommerce:core-theme package
Aaron Judd
@aaronjudd
Dec 08 2014 19:12
did it create files in client/themes?
Everest Liu
@evliu
Dec 08 2014 19:12
oh i didn’t, i just wanted to use the default theme
and i added the package using meteor add, didn’t clone the package
Aaron Judd
@aaronjudd
Dec 08 2014 19:13
that is the default theme now, you shouldn't have to clone
Everest Liu
@evliu
Dec 08 2014 19:13
do i have to update the reaction container? right now there is no styling whatsoever
oh reaction did update, i’ll pull in the changes
Aaron Judd
@aaronjudd
Dec 08 2014 19:14
ah, pull v0.2.2 branch of reaction
Everest Liu
@evliu
Dec 08 2014 19:14
yea, that’s it
Aaron Judd
@aaronjudd
Dec 08 2014 19:15
adds two new json files that define the theme setup, and then the build process will add a bunch of new .less files
Everest Liu
@evliu
Dec 08 2014 19:15
got it
Everest Liu
@evliu
Dec 08 2014 19:16
i’ll check it out
Everest Liu
@evliu
Dec 08 2014 19:32
this.isSoMuch(betterThan, IRC);
Aaron Judd
@aaronjudd
Dec 08 2014 19:54
@.isSoMuch "betterThan",  "IRC"
you've been coffeescripted
Everest Liu
@evliu
Dec 08 2014 20:23
hahaha
still don’t think i’ll get used to space-delimited syntaxes, not my forté
Everest Liu
@evliu
Dec 08 2014 23:37
so my coworker and i just spent a good amount of time talking about the variant options and were thinking it may be a good idea to nest options within variants rather than tag on a parentId (since it’s NoSQL rather than a relational model in which you would need something like a parentId), and it would consistently follow the model pattern (i.e. variants are nested within the product rather than just have productIds). thoughts?
Aaron Judd
@aaronjudd
Dec 08 2014 23:58
I did consider that approach, but it’s more about the business model, than the data design. A variant isn’t really a “option” it’s truly a product in it’s own right. the “product” is really a wrapper, and not the actual product. You can’t check out with a “product”, so if you were nesting them you’d be nesting a full product inside a product. I do have in mind an inheritance model for products, where you can clone a product, and then override or extend the variants, the parentId and cloneId are more for the future inheritance model for the products