These are chat archives for reactioncommerce/reaction

3rd
Feb 2015
Everest Liu
@evliu
Feb 03 2015 00:18 UTC
now i just gotta figure out how to work it… it looks enabled and configured in the admin, but during checkout on another browser, it says no shipping packages config'd
Aaron Judd
@aaronjudd
Feb 03 2015 00:20 UTC
hmmm, should work right out of the box
to reset, you could delete the Shipping collection
Everest Liu
@evliu
Feb 03 2015 00:23 UTC
alright
hmm, yea, can’t get it to work, even after adding a new shipping provider.
Aaron Judd
@aaronjudd
Feb 03 2015 00:27 UTC
you are using the development branch?
Everest Liu
@evliu
Feb 03 2015 00:27 UTC
yep, on core, the parent container, theme, and shipping
all pulled today
i’ll debug it
Aaron Judd
@aaronjudd
Feb 03 2015 00:31 UTC
I’m walking through them now, to check that they are all up to date, and testing local
Everest Liu
@evliu
Feb 03 2015 00:35 UTC
in client/templates/cart/checkout/shipping/shipping.coffee, i see it’s trying to do ReactionCore.Collections.Packages.find()… but should it be ReactionCore.Collections.Shipping?
nvm
it’s just seeing if a shipping package exists
Aaron Judd
@aaronjudd
Feb 03 2015 00:37 UTC
I just committed a few differences I have local (so you may want to pull), and reset, checked methods settings, added a new provider and method
Everest Liu
@evliu
Feb 03 2015 00:37 UTC
ok
where did you push to?
Aaron Judd
@aaronjudd
Feb 03 2015 00:39 UTC
shipping (and payment packages)
(development)
Everest Liu
@evliu
Feb 03 2015 00:39 UTC
fetch isn’t showing any new commits on reaction-shipping
Aaron Judd
@aaronjudd
Feb 03 2015 00:40 UTC
reactioncommerce/reaction-shipping@024174e
Everest Liu
@evliu
Feb 03 2015 00:40 UTC
already have that but it’s from jan 24th
Aaron Judd
@aaronjudd
Feb 03 2015 00:41 UTC
ok, yeah, nothing new there then, but reaction-core-theme has some minor updates as well. nothing that I think would cause the issue you are describing
Everest Liu
@evliu
Feb 03 2015 00:41 UTC
and is reaction-core supposed to have any shipping stuff in it?
Aaron Judd
@aaronjudd
Feb 03 2015 00:42 UTC
yes
Everest Liu
@evliu
Feb 03 2015 00:42 UTC
alright
Aaron Judd
@aaronjudd
Feb 03 2015 00:42 UTC
that would be calling a method in core, so that’s probably where you are behind
Everest Liu
@evliu
Feb 03 2015 00:42 UTC
i have Template.coreCheckoutShipping.helpers:shippingTemplates, that’s where i’m debugging right now and seeing if it’s returning nothing
yea, the query is returning an empty array for me, looking into mongo right now
Aaron Judd
@aaronjudd
Feb 03 2015 00:45 UTC
well the Failed to add shipping provider sounds like addShippingProvider: is missing in the cart/methods on server
Everest Liu
@evliu
Feb 03 2015 00:46 UTC
but it should still work with the built-in flat-rate ones, right?
Aaron Judd
@aaronjudd
Feb 03 2015 00:46 UTC
yes, that’s the method when you add a “flat rate” provider ...
Everest Liu
@evliu
Feb 03 2015 00:47 UTC
what does this query do? 'registry.shippingTemplate': {$exists: true},
i don’t see anything called shippingTemplate in the Packages collection for reaction-shipping entry
Aaron Judd
@aaronjudd
Feb 03 2015 00:48 UTC
from shipping.coffee:
 shippingTemplates: ->
    return ReactionCore.Collections.Packages.find({
      'enabled':true,
      'registry.shippingTemplate': {$exists: true},
      'registry.provides': {$in: ["shippingMethod"]}
      })
Everest Liu
@evliu
Feb 03 2015 00:49 UTC
yea, the second option in the options object passed to find
when i look at the document, it has the registry.provides and enabled, but there is no registry.shippingTemplate
Aaron Judd
@aaronjudd
Feb 03 2015 00:51 UTC
that’s set in register.coffee, in the package, and loads the package client facing template in the cart
shippingTemplate: “flatRateCheckoutShipping” in register.coffee
Everest Liu
@evliu
Feb 03 2015 00:52 UTC
hmm, looks like it’s not setting it in the db; i already dropped the collection and let it recreate itself twice; shippingTemplate never gets added to the registry sub-document
ohhh, maybe i need to drop the Packages document for that plugin
Aaron Judd
@aaronjudd
Feb 03 2015 00:53 UTC
just thinking that myself
probably had the old package info, and not updating
although I think I wrote something to remove that if “reaction” is running, and you do meteor add / remove in another console
Everest Liu
@evliu
Feb 03 2015 00:56 UTC
there we go, worked after i dropped that document and restarted meteor
Aaron Judd
@aaronjudd
Feb 03 2015 00:56 UTC
did you just symlink the package in while the server was running when you got the development shipping repo?
Everest Liu
@evliu
Feb 03 2015 00:57 UTC
i cloned it right into the packages folder
i’m getting the same thing for payment not being configured, so i’ll probably have to do the same with the payment packages
Aaron Judd
@aaronjudd
Feb 03 2015 00:57 UTC
ah ok. I think I could probably reproduce this now..
payment you actually do have to enable
Everest Liu
@evliu
Feb 03 2015 00:58 UTC
yea, they are already enabled
and set up with the id/secret
Aaron Judd
@aaronjudd
Feb 03 2015 00:58 UTC
I disabled the default of ‘paypal’, now you have to enable at least one payment provider on a fresh install (but shipping is autoenabled)
ok, probably same deal then
they now have a paymentTemplate in the registry
Everest Liu
@evliu
Feb 03 2015 00:59 UTC
my thoughts exactly. i’m gonna give a go at creating a payment module; any docs or should i just model off the existing packages?
Aaron Judd
@aaronjudd
Feb 03 2015 01:00 UTC
they just got a pretty good overhaul - I’d use one of them as a model
Everest Liu
@evliu
Feb 03 2015 01:01 UTC
sounds good thx
feel free to update the docs as you go ;-)
Everest Liu
@evliu
Feb 03 2015 01:02 UTC
cool, i think i can do the package part just fine, haha, but i’ll see what i can do with doc-ing hooking into the reaction payment system
Aaron Judd
@aaronjudd
Feb 03 2015 01:02 UTC
lol, k
Everest Liu
@evliu
Feb 03 2015 20:43 UTC
in reaction-paypal/client/templates/cart/checkout/payment/methods/paypal/paypal.coffee:26, it just contains Template.paypalPaymentForm.helpers with no actual helpers attached to it, so is that line necessary?
Aaron Judd
@aaronjudd
Feb 03 2015 21:57 UTC
nope
dangling leftovers
Ben Stocks
@bstocks
Feb 03 2015 23:18 UTC
ah, that was me starting to add in some date dropdowns and then getting distracted. I’ll fix.
Aaron Judd
@aaronjudd
Feb 03 2015 23:19 UTC
you shouldn’t need to add them anymore, they are defined in core
Ben Stocks
@bstocks
Feb 03 2015 23:20 UTC
ok, got it, makes more sense that way.