These are chat archives for reactioncommerce/reaction

13th
Feb 2015
Everest Liu
@evliu
Feb 13 2015 00:15
possible bug: when i alter a shipping method (say disable one of them), the Cart.findOne().shipping.shippingQuotes doesn’t reflect that change; does this matter?
Aaron Judd
@aaronjudd
Feb 13 2015 01:32
we could trigger a refresh (just remove all existing rates), but at the time I didn't think so. I'd think we'd err on the side of having a rate rather than needing reactivity there.
Everest Liu
@evliu
Feb 13 2015 01:33
maybe call the method that pulls it from the actual shipping module instead of storing it in the cart object? not sure of the logic, never done ecommerce platform coding before reaction, haha
Aaron Judd
@aaronjudd
Feb 13 2015 01:37
well if you delete the rates, they'll repopulate - (ie: when adding a new item to the cart with existing shipping, remove rates). I'm intentionally 'caching' the rates this way because with external calls (as I've worked with them all in the past) can be less responsive (performance wise) (so we want to limit actual rate lookups). This logic could probably be moved into a "on change qty" action on the schema eventually so that no real handling is needed.
Everest Liu
@evliu
Feb 13 2015 01:43
i see. i’m thinking it’s a lot of overhead if you have a ton of carts and each one has a copy of the shipping. wont’ the rates be cached in the Shipping collection anyways?
Aaron Judd
@aaronjudd
Feb 13 2015 02:03
once the rates are coming from multiple carriers, shipping collection will contain the allowed methods, but not the shipping quotes themselves (looking at it now you'd see only flat rates). Those are what would be cached in the cart - not system wide - as rates aren't going to be reused from cart to cart
provider->allowed methods in Shipping, cart.shipping.quotes-> in cart, reset on cart change
Everest Liu
@evliu
Feb 13 2015 02:05
alright
Aaron Judd
@aaronjudd
Feb 13 2015 02:05
so right now when you’re looking at flat rates, yeah, it seems like duplicate stuff
Everest Liu
@evliu
Feb 13 2015 02:21
that makes sense then since rates could vary
didn’t think of that
too used to amazon prime :P
Aaron Judd
@aaronjudd
Feb 13 2015 02:22
I wish all shipping was free or flat rate, but hey…
Everest Liu
@evliu
Feb 13 2015 02:26
lol
Darin Hensley
@dman777
Feb 13 2015 02:29
Hi, I am new to Node.js commerce. This project looks really promising. I wanted to make a simple arts and crafts store for my mom. Any idea when this will be deemed ready for production?
Aaron Judd
@aaronjudd
Feb 13 2015 02:44
@dman777 cant really say for any specific case, it’s a little early unless you’re ready to get down and dirty in the code, we’re looking at a few months for an officially “stable” version
Darin Hensley
@dman777
Feb 13 2015 02:46
ok, thanks!
Aaron Judd
@aaronjudd
Feb 13 2015 02:46
@dman777 sure thing
Everest Liu
@evliu
Feb 13 2015 03:14
When i try to enable/disable package as an admin, i’m getting this interesting error: "Access denied. No allow validators set on restricted collection for method 'update'. [403]”
just me?
Aaron Judd
@aaronjudd
Feb 13 2015 03:15
hmm. not sure, but I’m in the middle of a vary large rewrite (should be committed soon) that refactors the entire package system so I’ll test for that
but in general, no I haven’t seen that
Everest Liu
@evliu
Feb 13 2015 03:18
alright i’ll keep on the lookout
krishnamisra
@krishnamisra
Feb 13 2015 22:45
I am checking out using svn. I believe I need to checkout trunk for development
Aaron Judd
@aaronjudd
Feb 13 2015 22:52
@krishnamisra hi! docs for installing from git are here: https://github.com/reactioncommerce/reaction-core/blob/development/docs/installation.md , if there is anything that needs clarifying please let me know, I’m updating the docs in the package-registry-refactor branch.
Everest Liu
@evliu
Feb 13 2015 23:01
@bstocks how can i help out with the reaction-paypal package?
Ben Stocks
@bstocks
Feb 13 2015 23:05
@evliu i’ve started work on it in the pay-with-paypal branch. I’ve got the basics working, but am waiting on #314 before doing too much more. I’m digging into the questions you pose in reaction-paypal/issues/7 and will weigh in soon
Everest Liu
@evliu
Feb 13 2015 23:05
i’ve been playing with that branch [:
Ben Stocks
@bstocks
Feb 13 2015 23:07
cool. I think #314 will prompt a fair bit of refactoring. Major things that are still needed: hooking back into the workflow once paypal does the callback and determining exactly what info needs to be sent by the javascript button.
Aaron Judd
@aaronjudd
Feb 13 2015 23:08
I’m about to commit all the updates for all the packages. I can push paypal right now, if you want to test with the package-refactor-branch
Ben Stocks
@bstocks
Feb 13 2015 23:08
great
:thumbsup:
playing with it now
Everest Liu
@evliu
Feb 13 2015 23:12
cool, i’ll take a look on monday; getting pay-with-paypal definitely isn’t as easy, lol
i’ve been playing around with a lot of express checkout but after a good discussion yesterday, we figured out it’s not very advantages vs normal checkout with paypal
Ben Stocks
@bstocks
Feb 13 2015 23:13
@aaronjudd - getting a error: conflict: contraints on reactioncommerce:core cannot be satisfied. Constrains come from: <top level> … anything special I should be doing?
Aaron Judd
@aaronjudd
Feb 13 2015 23:13
@bstocks I just pushed more to the refactor branch (sort of midstream), that you’ll need as well. (that’s it though, structures are not changing…)
Ben Stocks
@bstocks
Feb 13 2015 23:14
@evliu - yeah, I looked into express checkout too. my current direction is just using the PayPal javascript button and passing the full cart amount through.
Everest Liu
@evliu
Feb 13 2015 23:15
yea, just gotta update the price if different shipping is selected
main thing with express checkout was that i was able to itemize the list
Aaron Judd
@aaronjudd
Feb 13 2015 23:21
@bstocks I’ve been working with just core, paypal, refactor branch where they are all in synch. you might try commenting out the other packages (or clone / linking them all and switch branches).. or just wait, lol.
Ben Stocks
@bstocks
Feb 13 2015 23:21
but i’m impatient!
Everest Liu
@evliu
Feb 13 2015 23:21
lol
you guys have a good weekend; gonna hit the gym now [:
Aaron Judd
@aaronjudd
Feb 13 2015 23:21
I’ll be publishing a bunch of packages…!
Ben Stocks
@bstocks
Feb 13 2015 23:21
talk to you later @evliu
Everest Liu
@evliu
Feb 13 2015 23:22
👍