These are chat archives for reactioncommerce/reaction

30th
Mar 2015
Bogi
@boboci9
Mar 30 2015 17:32

Hi, after a meteor upgrade I get this error:

While building the application:
   client/themes/custom.bootstrap.less:1629:18: Less compiler error: variable
   @form-group-margin-bottom is undefined

Does anyone encountered this?

Everest Liu
@evliu
Mar 30 2015 17:35
haven’t upgraded yet
Bogi
@boboci9
Mar 30 2015 17:38
Unfortunately I have and now I can't get rid of the error :(
Everest Liu
@evliu
Mar 30 2015 17:38
you can meteor upgrade to a specific version of meteor i believe
don’t remember off the top of my head how
pretty sure it involves the @ symbol
Spencer Norman
@spencern
Mar 30 2015 17:40
What version did you upgrade to?
Bogi
@boboci9
Mar 30 2015 17:41
reaction: updated to Meteor 1.0.5.
Everest Liu
@evliu
Mar 30 2015 17:45
1.1 RC is available so you can always try that to see if they fix it
Bogi
@boboci9
Mar 30 2015 17:55
The issue comes from the reaction somehow, because I tried using the 1.0.4 meteor version and the same error occurred from the less file
Spencer Norman
@spencern
Mar 30 2015 17:59
My guess would be it's got more to do with your bootstrap install and less (no pun intended) to do with reaction. Check reaction-core-theme too
From your error though it sounds like there is a less variable that is getting called but never defined, or called before it gets defined.
Everest Liu
@evliu
Mar 30 2015 18:01
i’ll git clone a new reaction instance and see if i get the same issue
Bogi
@boboci9
Mar 30 2015 18:01
My reactioncommerce:core-theme is in version 1.3.2 isn't that the latest?
Everest Liu
@evliu
Mar 30 2015 18:01
the great uses of the /tmp folder [:
Bogi
@boboci9
Mar 30 2015 18:02
@spencern yes that is what the error is suggesting but the file is autogenerated, so I can't manually overwrite it
Spencer Norman
@spencern
Mar 30 2015 18:04
:/ I wonder if there was a breaking change in one of the deps for core-theme. Curious what evliu finds when he clones.
Bogi
@boboci9
Mar 30 2015 18:05
I am trying to get the latest RC version too to see if that fixes the issue
Spencer Norman
@spencern
Mar 30 2015 18:06
Cool. I've got to get a few changes pushed on a different project for work, but I'll look into this too later this afternoon if you don't get it figured out by then.
Bogi
@boboci9
Mar 30 2015 18:07
ok, I will let you know how it works out, thanks
Everest Liu
@evliu
Mar 30 2015 18:08
do you get that error in the web console or in terminal?
and at what page do you get it? i just spun up a blank reaction with the newest reaction-core and theme, not seeing the bug
Bogi
@boboci9
Mar 30 2015 18:11
teminal
blank reaction, nothing starts
Everest Liu
@evliu
Mar 30 2015 18:12
hmm, i just got it to work with no issues, with theme and core cloned into packages
did a quick set up and checked out an order too
made sure i did a meteor update too
Spencer Norman
@spencern
Mar 30 2015 18:14
@boboci9 are you using a local version of the reaction-core-theme package?
Bogi
@boboci9
Mar 30 2015 18:14
first time I made the meteor update I made it without sudo so some errors appears, second time I made sudo meteor update I got meteor already in the newest version :( maybe something got stuck, can I got a step back somehow ?
yes I'm using a local version
Everest Liu
@evliu
Mar 30 2015 18:15
hmm, i never use sudo on meteor commands
Spencer Norman
@spencern
Mar 30 2015 18:16
Try using the atmosphere version of reaction-core-theme (you should be able to just move the local package out of your /packages directory)
Bogi
@boboci9
Mar 30 2015 18:16
I usually use them with sudo
Spencer Norman
@spencern
Mar 30 2015 18:17
I also never use sudo with meteor, it can have unintended consequences sometimes
Bogi
@boboci9
Mar 30 2015 18:17
@spencern already tried that :( but still not working
ok, I will try with a completely new reaction version, let's see
Bogi
@boboci9
Mar 30 2015 18:27
for me with simple meteor without sudo I always get errors, but I have been using sudo meteor just fine for the last 6 months so I'm not sure the problem is there
Jacob Gadikian
@faddat
Mar 30 2015 18:28
@boboci9 me too
I got around it by not meteor updating….
Bogi
@boboci9
Mar 30 2015 18:28
but even if I clone a completely new reaction version in a new folder I get the same error
Jacob Gadikian
@faddat
Mar 30 2015 18:28
I’m not yet too familiar with the code yet
yeah it was exactly the same for me. I think the update was screwing up a few of the modules.
Everest Liu
@evliu
Mar 30 2015 18:29
hmm, it might be better to change the persmissions of your projects so you don’t have to use sudo
Bogi
@boboci9
Mar 30 2015 18:30
ok, I will try that as well but I don't think it has anything to do with this new issue though
Everest Liu
@evliu
Mar 30 2015 18:33
yea, i’m not sure what the issue is, but just saying it’s good to not use sudo in general, even with things like npm, it’s good to just change the permissions of node_modules so you can just use npm without sudo
so don’t feel like you have to change it, just a good practice of not using God-mode unless actually necessary
Jacob Gadikian
@faddat
Mar 30 2015 18:34
oh I didn’t use sudo
I just didn’t do the update. Both are not best practice, though ;)
Everest Liu
@evliu
Mar 30 2015 18:34
people break their OSes using sudo because of one incorrect character, haha
but yea, i’m not sure how to reproduce the less issue you see
Bogi
@boboci9
Mar 30 2015 18:44
so I changed all permissions to the current user, so now I start with simple meteor
but still with a completely new version I get the error
not even sure where to start the search for the fix because it happens even in a completely newly cloned reaction version
I just do:
git clone https://github.com/reactioncommerce/reaction.git
cd reaction && git checkout master
meteor
Spencer Norman
@spencern
Mar 30 2015 18:51
Not sure where you should start either, but I'd probably start checking anything related to that less error. See if you can trace where the generated file is coming from and why it's not generating all of the variables. Check your npm less version, etc
Bogi
@boboci9
Mar 30 2015 18:54
ok thanks, I will debug it in this newly created project so that I'm sure nothing I've implemented is messing it up
Bogi
@boboci9
Mar 30 2015 19:05
after adding the missing less variables but new errors came up :( still in a completely newly cloned reaction version
Exception from sub products id T54d6ei3hPSh948nT Error: Did not check() all arguments during publisher 'products'
I20150330-22:02:23.527(3)?     at [object Object]._.extend.throwUnlessAllArgumentsHaveBeenChecked (
Everest Liu
@evliu
Mar 30 2015 19:09
i actually also clone core and theme, not just the parent container
mkdir packages; cd packages; git clone rcommerce/reaction-core (and theme)
and rcommerce cuz i was too lazy to type out the whole repo URI
Bogi
@boboci9
Mar 30 2015 19:11
I have those packages cloned in my main project where I was working initially :( but I will try them here as well
Vlatko Koudela
@vkoudela
Mar 30 2015 19:24
looks like checking out the master branch of reactioncommerce/reaction produces the less error - development branch works fine
Everest Liu
@evliu
Mar 30 2015 19:58
oh, i’m always on dev branch
that may be it then
Bogi
@boboci9
Mar 30 2015 20:04
I added some missing less variables in the theme files, and I got rid of the other error, I am usually on the dev myself but I wanted to test out something on the main repo as well, anyways it's working now, thanks
Everest Liu
@evliu
Mar 30 2015 20:07
👍
Aaron Judd
@aaronjudd
Mar 30 2015 23:40
@boboci9 re: the use of sudo. probably similar to #198 fix your .npm permissions with:
sudo chown -R `whoami` ~/.npm
Aaron Judd
@aaronjudd
Mar 30 2015 23:49
@vkoudela @boboci9 - glad you guys figured it out. my advice is to use the development branch if you are doing development. Master shouldn't cause errors though, but here's the background on why you might have issues: *.less files are committed to master because I auto-build the reaction docker images from master. It's a temporary solution, but if you don't run meteor at least once in development mode the .less files won't get created, which is why I commit them on the master and not on development branch (otherwise they won't get included in the bundled images). I am hoping to clean that up, by automating the creation of a release branch that has the .less files and remove them from master as well, but.. my fingers only go so fast.