These are chat archives for reactioncommerce/reaction

21st
Apr 2015
Goutham Veeramachaneni
@gouthamve
Apr 21 2015 07:05
@aaronjudd I saw your hack of changing the 404 route. But even then the mocha tests are not running properly (or rather not running at all). Mocha logs are not showing any errors. It just gets stuck at Running mocha server tests
Goutham Veeramachaneni
@gouthamve
Apr 21 2015 07:12
Are the mocha tests running for you @spencern ?
Goutham Veeramachaneni
@gouthamve
Apr 21 2015 07:26
I think it relates to this issue mad-eye/meteor-mocha-web#148
Bogi
@boboci9
Apr 21 2015 13:05
@aaronjudd wondeing about how the roles work with the permissions, I think I'm missing something since I don't see any permission checks in the reactionApp helper, so if the user has dashboard access he has access to every shortcut package?
Bogi
@boboci9
Apr 21 2015 13:32
What is the difference if a user has admin roles or if it appears in the members list with the isAdmin flag set?
Jacob Gadikian
@faddat
Apr 21 2015 14:29
mocha vs chai?
(also may be a bit of a noob question)
;)
Aaron Judd
@aaronjudd
Apr 21 2015 16:22
@Gouthamve I ended up just cloning the mike:mocha into my packages/dir and fixing the one line defining root_url
@faddat the mike:mocha package is supposed to include mocha+chai
I'm not sure if we've settled on mocha vs jasmine - I'm just using jasmine at the moment, as it seems to work well
Spencer Norman
@spencern
Apr 21 2015 17:13
I've also been using jasmine almost exclusively
Everest Liu
@evliu
Apr 21 2015 17:41
yea, we’re jasmine too
Aaron Judd
@aaronjudd
Apr 21 2015 19:31
@boboci9 I think you'd want to manage those in the publication
Bogi
@boboci9
Apr 21 2015 19:37
I am trying to figure out how this works for the reactionApp helper
Aaron Judd
@aaronjudd
Apr 21 2015 19:39
but the helper is client side and when it fetches the packages, those are filtered by if Roles.userIsInRole(this.userId, ['dashboard','owner','admin'])
that's where you'd want to modify for additional roles (in the publication)
Bogi
@boboci9
Apr 21 2015 19:42
and the difference between the admin role and the member isAdmin? can you tell me what is the difference?
because I see that member isAdmin also has dashboard access
but I can't figure out how the permissions work in this case
Aaron Judd
@aaronjudd
Apr 21 2015 19:50
honestly, it's been a long time since I've walked through the permissions (beyond admin) so I'm not entirely sure off the top of my head. (and it's high on the list of items to review, and write tests for)
Bogi
@boboci9
Apr 21 2015 19:52
I am working through it as well
but I couldn't figure out the member isAdmin part yet