These are chat archives for reactioncommerce/reaction

24th
Apr 2015
Aaron Judd
@aaronjudd
Apr 24 2015 15:47
@boboci9 were you able to resolve bower install?
Bogi
@boboci9
Apr 24 2015 16:59
@aaronjudd no :( did noone else have this issue? was it only for me? I am working on an older version
Aaron Judd
@aaronjudd
Apr 24 2015 17:01
nobody else has reported it, I’ve been unable to recreate, just theories.
Bogi
@boboci9
Apr 24 2015 17:02
should there be any files present in the lib/bower folder that I had to create?
Aaron Judd
@aaronjudd
Apr 24 2015 17:03
no, it should create the folder. I test by deleting packages/reaction-core/lib/bower
I just wanted you to try that in case there was some permissions issue
Bogi
@boboci9
Apr 24 2015 17:04
let me retry it in an other branch
Aaron Judd
@aaronjudd
Apr 24 2015 17:05
is there any thing else you didn’t pull down? (reaction, or theme) - I don’t think there’s anything else you would need except core - but…
Bogi
@boboci9
Apr 24 2015 17:06
I also tried a meteor update but no luck
Aaron Judd
@aaronjudd
Apr 24 2015 17:06
I’m writing a circle script that will test packages, including their integration with other packages - hopefully should cover this kind of failure - it’s been a bit of a slog
Bogi
@boboci9
Apr 24 2015 17:07
as soon as I pull the new version it crashes
Errors prevented startup:                  

   While building package reactioncommerce:core:
   error: File not found: lib/statemachine/state-machine.js
   error: File not found: lib/i18next-1.7.3/i18next-1.7.3.js
   error: File not found: lib/swiper/idangerous.swiper.css
   error: File not found: lib/swiper/idangerous.swiper.js
   error: File not found: lib/jquery-autosize/jquery.autosize.js
   error: File not found: lib/imagesLoaded/imagesloaded.pkgd.js
   error: File not found: lib/jquery-ui/jquery-ui-1.10.4.custom.js
   error: File not found: lib/jquery-ui/jquery-ui-1.10.3.custom.css
   error: File not found: lib/jquery-collapsible/jquery.collapsible.js
   error: File not found: lib/jquery-serialize/jquery.serialize-hash.coffee
   error: File not found: lib/jquery-cookie/jquery.cookie.js
   error: File not found: lib/openexchangerates/money.js
   error: File not found: lib/openexchangerates/accounting.js

=> Your application has errors. Waiting for file change.
=> Modified -- restarting.                    
Bower:  { [Error: No cached version for git@github.com:sdrdis/jquery.serialize-hash.git#*] stack: [Getter] }
Bower:  { [Error: Failed to execute "git ls-remote --tags --heads git@github.com:sdrdis/jquery.serialize-hash.git", exit code of #128] stack: [Getter] }
=> Errors prevented startup:                  

   While building package reactioncommerce:core:
   <runJavaScript-179>:239:55: Cannot read property 'name' of undefined
   (compiling lib/bower.json)
   at getDependencies (<runJavaScript-179>:239:55)
   at <runJavaScript-179>:251:5
   at Function._.each._.forEach (<runJavaScript-177>:147:22)
   at getDependencies (<runJavaScript-179>:250:5)
   at bowerHandler (<runJavaScript-179>:117:35)
   at Package (<runJavaScript-179>:277:10)

   error: File not found: lib/bower/jquery.ui/ui/core.js
   error: File not found: lib/bower/jquery.ui/ui/widget.js
   error: File not found: lib/bower/jquery.ui/ui/mouse.js
   error: File not found: lib/bower/jquery.ui/ui/position.js
   error: File not found: lib/bower/jquery.ui/ui/autocomplete.js
   error: File not found: lib/bower/jquery.ui/ui/sortable.js
   error: File not found: lib/bower/jquery.ui/ui/draggable.js
   error: File not found: lib/bower/jquery.ui/ui/droppable.js
   error: File not found: lib/bower/jquery.ui/ui/effect.js
   error: File not found: lib/bower/jquery.ui/ui/effect-slide.js
   error: File not found: lib/bower/jquery.ui/ui/menu.js
   error: File not found: lib/bower/autosize/dest/autosize.js
   error: File not found: lib/bower/collapsible/jquery.collapsible.js
   error: File not found:
   lib/bower/openexchangerates.accounting/accounting.min.js
   error: File not found: lib/bower/openexchangerates.money/money.js
   error: File not found: lib/bower/jquery.tagsinput/jquery.tagsinput.js
   error: File not found: lib/bower/jquery.cookie/jquery.cookie.js
but if noone else had this issue it could be only on my side some other package
Aaron Judd
@aaronjudd
Apr 24 2015 17:11
this looks like bower is running after reaction-core loads package.js which is not the order of execution I’ve been getting. I’m thinking about how we diagnose package load order -> if you have something different in the order of .meteor/packages or a dependency that is different. (or do you have a completely clean install you can test?)
Bogi
@boboci9
Apr 24 2015 17:11
I can't even do a meteor list to see if any other package is out of date
I will try a completely new install to see
Aaron Judd
@aaronjudd
Apr 24 2015 17:13
what do you get if you run git ls-remote --tags --heads git@github.com:sdrdis/jquery.serialize-hash.git
Bogi
@boboci9
Apr 24 2015 17:14

Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Aaron Judd
@aaronjudd
Apr 24 2015 17:14
I get
44340da33ee38f08960aa814be357624b5b4a7b5 refs/heads/master
Bogi
@boboci9
Apr 24 2015 17:15
could that be the issue?
Aaron Judd
@aaronjudd
Apr 24 2015 17:15
yeah, I think so
this is causing the rest of bower to error, which in turns lets reaction-core package.js try to addFiles that don’t exist
Bogi
@boboci9
Apr 24 2015 17:16
I see
should I add some extra permissions somewhere?
Aaron Judd
@aaronjudd
Apr 24 2015 17:20
well I’m curious about the git error - I’m wondering if I’m authenticated to github (at cli). what if you run git ls-remote --tags --heads https://github.com/sdrdis/jquery.serialize-hash.git
Bogi
@boboci9
Apr 24 2015 17:21
-tags --heads https://github.com/sdrdis/jquery.serialize-hash.git
44340da33ee38f08960aa814be357624b5b4a7b5 refs/heads/master
Aaron Judd
@aaronjudd
Apr 24 2015 17:21
perfect!
Bogi
@boboci9
Apr 24 2015 17:22
this looks better :)
Aaron Judd
@aaronjudd
Apr 24 2015 17:22
ok in packages/reaction-core/lib/bower.json update that url
Bogi
@boboci9
Apr 24 2015 17:25
accounting gives the same error
git ls-remote --tags --heads git@github.com:openexchangerates/accounting.js.git
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Aaron Judd
@aaronjudd
Apr 24 2015 17:26
pull from development
I updated the others
Bogi
@boboci9
Apr 24 2015 17:26
ok let me try
:+1: thank you the new version is working great
Aaron Judd
@aaronjudd
Apr 24 2015 17:29
awesome! that’s an odd one
Bogi
@boboci9
Apr 24 2015 17:30
yes, strange that noone else had the issue, I am just working on a new PR and I wanted to get the latest version before I make the changes, I will post an issue about that soon
Aaron Judd
@aaronjudd
Apr 24 2015 17:30
I’m thinking I have some ssh-keys installed - probably because I have the github mac app installed.
Bogi
@boboci9
Apr 24 2015 17:30
This message was deleted
I'm working on Linux and mostly from terminal
Aaron Judd
@aaronjudd
Apr 24 2015 17:31
somebody else would probably have had the issue (soon as we get windows going)
looking forward to the new pr.
(general pr hint: tests are now highly encouraged)
Bogi
@boboci9
Apr 24 2015 17:35
ok, I'm not sure how to add them for this section but before the PR I am working on a description of the whole use case to see your input and then you could suggest where to add the tests
Aaron Judd
@aaronjudd
Apr 24 2015 17:44
sounds good. i’m hoping we can get a couple contributors to help out with reviewing new features/pr, defining some guidelines for testing and code reviews / acceptance after I get the ci implementation working smoothly.
Bogi
@boboci9
Apr 24 2015 17:46
sounds good, I'm sure people will contribute
and tests will make it more safe
Spencer Norman
@spencern
Apr 24 2015 17:46
I'm definitely up for helping with that
Almost done with my Foundation 5 port as well and working on what is necessary to make it as plug-and-play as possible
Aaron Judd
@aaronjudd
Apr 24 2015 17:50
I started to move the core-theme build package stuff out of core, but decided to wait and see what thoughts you had.
Spencer Norman
@spencern
Apr 24 2015 17:53
Definitely, I have one other project I need to get done today but will hopefully be able to publish the F5 theme later today or this weekend.
I'll let you know thoughts on that as soon as I can
Aaron Judd
@aaronjudd
Apr 24 2015 17:53
@/all anybody have experience with creating a complex circle.yml?
@spencern :thumbsup:
Everest Liu
@evliu
Apr 24 2015 20:16
Nope, sorry