These are chat archives for reactioncommerce/reaction

19th
May 2015
Michael Jenny
@prinzdezibel
May 19 2015 18:21
I checked out METEOR@1.1.0.2 and now it works. (Before that I was on branch development.) I don't see what's wrong with my first attempt.
anyway..
all is good
Aaron Judd
@aaronjudd
May 19 2015 18:22
maybe the trick is meteor update?
Michael Jenny
@prinzdezibel
May 19 2015 18:23
can't say, but why not..
is the branch feature-role-372 already merged?
Aaron Judd
@aaronjudd
May 19 2015 18:25
not yet, I’d like to get some feedback though - it’s functionally complete - I was just going to do a little more UI cleanup and add a few tests.
ie: I’d like to be able to merge in the next 24-48 hours…
you’ll probably need the theme branch as well, though
Michael Jenny
@prinzdezibel
May 19 2015 18:27
how does this new velocity icon in the upper right work?
Aaron Judd
@aaronjudd
May 19 2015 18:28
you should see a panel when you click on it, with test results
Michael Jenny
@prinzdezibel
May 19 2015 18:29
I have a zero count everywhere
and loading icons for every section. doesn't show anything
do I need to start a test server or anything?
Aaron Judd
@aaronjudd
May 19 2015 18:31
no, it should start everything up. it might not be finding the tests
check to see that reaction/tests/jasmine is symlinked to packages/reaction-core/tests
the latest velocity is supposed to handle this, but I’ve had a few issues
Michael Jenny
@prinzdezibel
May 19 2015 18:34
jasmin dir is symlinked, mocha not so much
Aaron Judd
@aaronjudd
May 19 2015 18:35
if you have the mike:mocha package installed, remove it (we’re just using jasmine now)
Michael Jenny
@prinzdezibel
May 19 2015 18:35
no. it's not there "no such file or directory". ie the symlink is dangling
should be ok then
Aaron Judd
@aaronjudd
May 19 2015 18:40
I just pushed https://github.com/reactioncommerce/reaction/tree/feature-role-372 as well, that’s my complete env - should be 52 tests passing
Spencer Norman
@spencern
May 19 2015 19:34
I've got 50 tests passing on my device branch as well, but have had the 0 tests issue numerous times. I can't figure out how to reproduce it, but have found that messing with one of the spec files usually will fix it. Sometimes it's super slow to recognize updates though.
I'm a few commits back of current dev though