These are chat archives for reactioncommerce/reaction

21st
May 2015
Bogi
@boboci9
May 21 2015 14:10
Hi @aaronjudd I am testing the feature-roles-372 branch but when I hit meteor reset none of the collections from the DB got populated, did you get any similar issues?
Aaron Judd
@aaronjudd
May 21 2015 14:42
No, I reset regular. I also use bin/reset when I really want a clean test
The fixture data might be updated, not sure if you have different fixture data
Bogi
@boboci9
May 21 2015 14:52
This is the only concrete error that I see
TypeError: Cannot set property 'languages' of undefined
W20150521-17:51:33.996(3)? (STDERR)   at Object.loadI18n (/home/bogi/Meteor/newco/reaction/.meteor/local/build/programs/server/packages/reactioncommerce_core.js:3449:24)
W20150521-17:51:33.996(3)? (STDERR)   at loadFixtures (/home/bogi/Meteor/newco/reaction/.meteor/local/build/programs/server/packages/reactioncommerce_core.js:3550:12)
but it gives me a lot of keys won't match the schema as well
Bogi
@boboci9
May 21 2015 15:33
I tried creating a completely new reaction app in a clean folder (everything from the first step) but when I to change to the feature-roles-372 branch it gives me a lots of conflicts so I went and downloaded the feature-roles-372 branch and zipped it out in my folder, but now I get the bower error again :(
lib/bower/jquery.ui/themes/base/all.css: warn: there are some @import rules those are not taking effect as they are required to be in the beginning of
the file
lib/bower/jquery.ui/themes/base/base.css: warn: there are some @import rules those are not taking effect as they are required to be in the beginning
of the file

/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/fibers/future.js:245
                        throw(ex);
                              ^
Error: Path reservation conflict: packages/bower/jquery/dist/jquery.js
  at [object Object]._.extend.reserve (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/builder.js:236:15)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1159:15
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1151:11
  at Array.forEach (native)
  at Function._.each._.forEach (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1150:11
  at Array.forEach (native)
  at Function._.each._.forEach (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:79:11)
  at eachResource (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1149:9)
  at [object Object]._.extend.write (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1158:5)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1815:12
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1918:25
  at Function._.each._.forEach (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/underscore/underscore.js:87:22)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:1917:7
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/bundler.js:2147:20
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/buildmessage.js:264:13
  at [object Object]._.extend.withValue (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/fiber-helpers.js:115:14)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/buildmessage.js:257:29
  at [object Object]._.extend.withValue (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/fiber-helpers.js:115:14)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/buildmessage.js:255:18
  at [object Object]._.extend.withValue (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/fiber-helpers.js:115:14)
  at /home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/tools/buildmessage.js:246:23
  at [object Object]._.extend.withValue (/home/bogi/.meteor/packages/meteor-tool/.1.1.3.z37vt8++os.linux.x86_6
Aaron Judd
@aaronjudd
May 21 2015 17:31
@boboci9 sorry for the slow response, I'm actually travelling today
I've never had these issues, I'm trying to think on what might cause these? it's a clean checkout of core/ feature -372? you are using the 372 branch of reaction as well? I don't think there is anything in the reaction (app) branch or in theme that would cause this error (maybe some UI errors if you are using older, but otherwise I think it should be ok)
circle ci is building these ok as well from clean checkouts (timedout error is a problem with meteor/velocity not terminating after the tests finish)
Bogi
@boboci9
May 21 2015 18:03
I'm not sure what do you mean by it's a clean checkout of core/ feature -372? you are using the 372 branch of reaction as well? I don't see anything like feature-372? I only have feature-roles-372 and I got that version as the reaction core app not cloned in the packages but I will try as a package as well. Let me know which version is the feature-372(without role in the middle)?
Spencer Norman
@spencern
May 21 2015 18:20
Hi @boboci9,
I'm also able to get 372 working on a clean checkout. I did have to use meteor --allow-incompatible-update but otherwise was able to get things working fine.
Here's my steps to reproduce:
  1. Clone the feature-role-372 branch of reaction (not core) into feature-role-372
    git clone -b feature-role-372 --single-branch git@github.com:reactioncommerce/reaction.git feature-role-372
  2. cd feature-role-372 and mkdir packages and cd packages
  3. Clone the feature-roles-372 branch of reaction core into the packages directory:
    git clone -b feature-roles-372 --single-branch git@github.com:reactioncommerce/reaction-core.git reaction-core
  4. Clone the feature-roles-372 branch of reaction-core-theme into the packages directory:
    git clone -b feature-roles-372 --single-branch git@github.com:reactioncommerce/reaction-core-theme.git reaction-core-theme
  5. Run meteor using --allow-incompatible-update
Bogi
@boboci9
May 21 2015 18:25
thanks I will try it and get back to you
Spencer Norman
@spencern
May 21 2015 18:26
Ok, I'm running to lunch, but will be available after.
Bogi
@boboci9
May 21 2015 19:54
Sorry I had to run out too, but I'm back
The first is already giving me an error : git clone -b feature-role-372 --single-branch git@github.com:reactioncommerce/reaction.git feature-role-372
bogi@bogi-ubuntu:~/Meteor/newco-role$ git clone -b feature-role-372 --single-branch git@github.com:reactioncommerce/reaction.git feature-role-372
Cloning into 'feature-role-372'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Bogi
@boboci9
May 21 2015 19:59
I tried it with featured-roles-372 too
git clone -b feature-roles-372 --single-branch git@github.com:reactioncommerce/reaction.git feature-roles-372
But I could make it work with:
git clone -b feature-roles-372 --single-branch https://github.com/reactioncommerce/reaction-core.git feature-roles-372
I will continue with the next steps and see where they lead me
Bogi
@boboci9
May 21 2015 20:12
If I do this in a completely new folder it will lead me to run: You're not in a Meteor project directory., The .meteor folder was not created
Bogi
@boboci9
May 21 2015 20:24
I created a new meteor project and copied the .meteor folder over, then I was able to run meteor --allow-incompatible-update I know it sounds like a hack but I just wanted to get this working all day, anyways I get the project running but it gives me a completely new error
 ReferenceError: Plugin is not defined
W20150521-23:22:25.015(3)? (STDERR)     at app/server/buildtools/theme-configurator.js:139:1
W20150521-23:22:25.015(3)? (STDERR)     at app/server/buildtools/theme-configurator.js:141:3
To @spencern are you sure you meant this line: git clone -b feature-roles-372 --single-branch git@github.com:reactioncommerce/reaction-core-theme.git reaction-core-theme copy the feature-roles branch in the reaction theme folder?
Spencer Norman
@spencern
May 21 2015 20:31
Regarding this error Permission denied (publickey). fatal: Could not read from remote repository.
I think that's because you don't have your ssh key setup with github
I'd imagine that using https would be fine as well
Bogi
@boboci9
May 21 2015 20:34
It seems now it has a problem with the theme, or you suspect something else?
Aaron Judd
@aaronjudd
May 21 2015 20:51
@boboci9 I’ve not seen that one either. The theme checkout (and all the other cloned packages) should go in packages/
Bogi
@boboci9
May 21 2015 20:52
yes they are there, it was just strange to me to get the feature-roles-372 in the theme folder
Aaron Judd
@aaronjudd
May 21 2015 20:54
you don’t need the .meteor folder, if you clone reaction, and run meteor from that directory, it should already have it. All others clone to packages/. The client/themes/ should now have client/themes/bootstrap if you have the feature-roles-372 of reaction, packages/rection-core-theme, reaction-core.
(I just moved client/themes/.less .json to client/themes/bootstrap to help organize for @spencern foundation theme
(so for example, foundation can now use client/themes/foundation)
Bogi
@boboci9
May 21 2015 20:57
if I clone reaction yes it's there but I tried as @spencern suggested git clone -b feature-role-372 --single-branch git@github.com:reactioncommerce/reaction.git feature-role-372and this way the .meteor folder was not there, I'm not sure why
ok I will try again I see where I could have missed something, my first step was reaction-core not reaction, I will redo all the steps
that is why my .meteor folder was missing
Bogi
@boboci9
May 21 2015 21:08
ok this worked thanks @spencern and @aaronjudd
the magic was to use reaction.git in the first line as Spencer suggested and reaction-core.git in the other two
Aaron Judd
@aaronjudd
May 21 2015 21:11
:thumbsup: I’ve got my local pretty organized to swith between branches, and to let me test PR’s. I’ve been thinking of writing a script to help configure dev packages, but everyone’s environment is different so tough to do.
Bogi
@boboci9
May 21 2015 21:12
It's still strange for me since I don't see yet into the soul of the app, why it only works with Spence's 5 steps otherwise it gives errors after errors but good that I could get it started
anyways, I will do some testing set up a marketplace configuration and report back, thanks again
Aaron Judd
@aaronjudd
May 21 2015 21:14
I keep a reaction, and packages folder at the top level, and clone all the packages into the packages/folder then symlink into reaction/packages. This way I’m actually testing all the latest branches of everyone’s packages
Bogi
@boboci9
May 21 2015 21:18
when you will have some spare time you could write down the steps to this approach to the developers guide doc or anywhere else and I will try them out :)
Aaron Judd
@aaronjudd
May 21 2015 21:31
will do soon - it’s really pretty easy to keep it all in synch, but a pain to get started
I think this is more an issue with package development