These are chat archives for reactioncommerce/reaction

26th
Sep 2015
Mike Murray
@mikemurray
Sep 26 2015 00:12
are all packages using the development branches as well?
Aaron Judd
@aaronjudd
Sep 26 2015 03:28
this less@1.0.11 <- reactioncommerce:reaction-analytics 1.0.4 shows you which package is out of date.
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 06:43
Is there a way I can hide products from the homepage?
Also, I think pagination is essential here, because it is taking upwards of 4 secs (the spinner time) on local to show the home page with 300 products (without images)!
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 06:59
Also I created small package for adding fake data. https://github.com/Gouthamve/reaction-faker
Demo: https://www.youtube.com/watch?v=e3qgnJqvLww
I will be adding more customisation later, and I hope it will be helpful.
Aaron Judd
@aaronjudd
Sep 26 2015 14:40
@Gouthamve that's very cool. (yes, clearly pagination need). Did you consider using the factories for that? https://github.com/reactioncommerce/reaction-core/tree/development/common/factories
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 14:41
Wait, nope. What are they?
Aaron Judd
@aaronjudd
Sep 26 2015 14:42
Factory.create("Product") - will make your faker product
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 14:43
Oh. Cool! This is much better, but if you look at my package, I am adding a faked boolean for the faked products which allows me to remove those fake products. (I dont think I want to do meteor reset)
Aaron Judd
@aaronjudd
Sep 26 2015 14:43
mostly used for writing tests, but at the moment I have Factories, and faker exposed - in case they are useful for more than just tests
have you used velocity, jasmine at all? (do you have them enabled locally?)
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 14:46
Nope. I will set the test environment up now.
Aaron Judd
@aaronjudd
Sep 26 2015 14:46
velocity will set up a separate test instance, test data being isolated
in .meteor/packages, just uncomment the testing section
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 14:48
Oh. Can we access that version of reaction that velocity sets up?
Aaron Judd
@aaronjudd
Sep 26 2015 14:48
I'm not really sure how you'd test for xxx number of products and the ui / performance implications - so I think your package is still very useful - but maybe you could reuse the factories
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 14:48
Yep, I will be reusing factories.
Aaron Judd
@aaronjudd
Sep 26 2015 14:49
yes, you can click on the "testing section header" in the velocity control panel and that will take you to the server/port/ that tests are running on
or in the console it will echo the address that velocity is running on, when you first start up
you can actually watch the test runs, at least when things are working right
although, it's really too fast to watch, more like you can watch the beginning and end
but might be reasonable to add 50 products in the test, to test that pagination,etc is working
(if that were coded)
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 14:54
I am going to look at velocity and tests again. I finally wrote some tests for my golang projects, so I think I will give js/meteor tests another shot now.
Any chance we have some kind of code-coverage information?
Aaron Judd
@aaronjudd
Sep 26 2015 14:59
nope, not yet. no code coverage stuff, I've looked into it, but.... nothing concrete yet

@paulgrever you can write them in the packages, no problem - but you don’t get to use the pretty velocity console for the results. you’ll need to use the command line to test. ie:

VELOCITY_TEST_PACKAGES=1 meteor test-packages --driver-package velocity:html-reporter --velocity --port 3006 reactioncommerce:core

or to test on change:

VELOCITY_TEST_PACKAGES=1 meteor test-packages --port 3006 reactioncommerce:core
(how to run on the CLI as well)
Goutham Veeramachaneni
@gouthamve
Sep 26 2015 17:56
Do you plan to have e-commerce analytics like funnels built into reaction-analytics or do you want leave it out to the analytics providers?
Aaron Judd
@aaronjudd
Sep 26 2015 18:03
built into reaction-analytics
as long as the right events are there, you can always customize the providers reports
Bryan Wu
@cooloney
Sep 26 2015 22:14
@aaronjudd back to the question I posted yesterday. how to solve the package out of date issue.
Aaron Judd
@aaronjudd
Sep 26 2015 22:14
meteor update
did you do that?
Bryan Wu
@cooloney
Sep 26 2015 22:15
i fresh clean git clone the reaction project to development. and just run meteor.
ok, let me try it.
thanks
after meteor update, i got the same error message
$ meteor update
This project is already at Meteor 1.2.0.1, the latest release.
=> Errors while upgrading packages:           

While selecting package versions:
error: Conflict: Constraint less@1.0.14 is not satisfied by less 2.5.0_2.
Constraints on package "less":
* less@=2.5.0_2 <- top level
* less@2.5.0_1 <- reactioncommerce:core 0.8.0
* less@2.5.0_1 <- reactioncommerce:bootstrap-theme 1.6.0
* less@1.0.14 <- reactioncommerce:reaction-accounts 1.0.1
* less@2.5.0_1 <- reactioncommerce:reaction-shipping 0.6.0
* less@1.0.11 <- reactioncommerce:reaction-analytics 1.0.4
* less@2.5.0_1 <- reactioncommerce:reaction-social 0.4.0
* less@2.5.0_1 <- reactioncommerce:reaction-paypal 1.1.0
* less@2.5.0_1 <- reactioncommerce:reaction-stripe 2.1.0

Conflict: Constraint less@1.0.11 is not satisfied by less 2.5.0_2.
Constraints on package "less":
* less@=2.5.0_2 <- top level
* less@2.5.0_1 <- reactioncommerce:core 0.8.0
* less@2.5.0_1 <- reactioncommerce:bootstrap-theme 1.6.0
* less@1.0.14 <- reactioncommerce:reaction-accounts 1.0.1
* less@2.5.0_1 <- reactioncommerce:reaction-shipping 0.6.0
* less@1.0.11 <- reactioncommerce:reaction-analytics 1.0.4
* less@2.5.0_1 <- reactioncommerce:reaction-social 0.4.0
* less@2.5.0_1 <- reactioncommerce:reaction-paypal 1.1.0
* less@2.5.0_1 <- reactioncommerce:reaction-stripe 2.1.0
Aaron Judd
@aaronjudd
Sep 26 2015 22:17
ok so, all the latest packages have been published. if you are seeing this same message
   * less@1.0.14 <- reactioncommerce:reaction-accounts 1.0.1
   * less@2.5.0_1 <- reactioncommerce:reaction-shipping 0.6.0
   * less@1.0.11 <- reactioncommerce:reaction-analytics 1.0.4
it’s showing you which packages aren’t right-> the two using older versions of less need to be updated.
even if you do meteor update, if you have those packages local, (cloned earlier), meteor will likely be using those
if you type meteor list it will show you all the package versions
it should contain something like this:
reactioncommerce:bootstrap-theme          1.6.0+ Reaction Commerce Bootstrap theme builder
reactioncommerce:core                     0.8.1+ Reaction Commerce Core
reactioncommerce:reaction-accounts        1.1.0+ Reaction Accounts - Authentication UI for Reaction Commerce
reactioncommerce:reaction-analytics       1.1.0+ Reaction Analytics - Integrate third-party analytics libraries
reactioncommerce:reaction-analytics-libs  1.1.0+ Reaction Commerce - Analytics Libraries
reactioncommerce:reaction-paypal          1.1.0+ Reaction Paypal - PayPal payments for Reaction Commerce
reactioncommerce:reaction-shipping        0.6.0+ Reaction Shipping - Flat Rate shipping for Reaction Commerce
reactioncommerce:reaction-social          0.4.0+ Reaction Social - Social Sharing Package for Reaction
reactioncommerce:reaction-stripe          2.1.0+ Reaction Stripe - Stripe payments for Reaction Commerce
Bryan Wu
@cooloney
Sep 26 2015 22:23
even meteor list gave me the same error.
i did download some packages locally, but I did fresh clean git clone the new project.
then i met this error
Aaron Judd
@aaronjudd
Sep 26 2015 22:26
where did you clone the packages to? did you set PACKAGE_DIRS= to anything?
(ie, did you put them in the packages/ dir, or did you put them elsewhere, and set PACKAGE_DIRS)
Bryan Wu
@cooloney
Sep 26 2015 22:30
I cloned the 0.7 reaction to a directory named demo_0.7 and cloned some packages source to demo_0.7/packages/
I set the PACKAGE_DIRS=packages/.
but today I fresh clean the latest reaction repo to a new directory named reaction
then run meteor failed like this
now my PACKAGE_DIRS is empty
Aaron Judd
@aaronjudd
Sep 26 2015 22:37
so in the clean repo, with an empty packages/*, perhaps try: PACKAGE_DIRS=“” meteor update
Bryan Wu
@cooloney
Sep 26 2015 22:39
weird. same error
$ PACKAGE_DIRS="" meteor update
This project is already at Meteor 1.2.0.1, the latest release.
=> Errors while upgrading packages:           

While selecting package versions:
error: Conflict: Constraint less@1.0.14 is not satisfied by less 2.5.0_2.
Constraints on package "less":
* less@=2.5.0_2 <- top level
* less@2.5.0_1 <- reactioncommerce:core 0.8.0
* less@2.5.0_1 <- reactioncommerce:bootstrap-theme 1.6.0
* less@1.0.14 <- reactioncommerce:reaction-accounts 1.0.1
* less@2.5.0_1 <- reactioncommerce:reaction-shipping 0.6.0
* less@1.0.11 <- reactioncommerce:reaction-analytics 1.0.4
* less@2.5.0_1 <- reactioncommerce:reaction-social 0.4.0
* less@2.5.0_1 <- reactioncommerce:reaction-paypal 1.1.0
* less@2.5.0_1 <- reactioncommerce:reaction-stripe 2.1.0

Conflict: Constraint less@1.0.11 is not satisfied by less 2.5.0_2.
Constraints on package "less":
* less@=2.5.0_2 <- top level
* less@2.5.0_1 <- reactioncommerce:core 0.8.0
* less@2.5.0_1 <- reactioncommerce:bootstrap-theme 1.6.0
* less@1.0.14 <- reactioncommerce:reaction-accounts 1.0.1
* less@2.5.0_1 <- reactioncommerce:reaction-shipping 0.6.0
* less@1.0.11 <- reactioncommerce:reaction-analytics 1.0.4
* less@2.5.0_1 <- reactioncommerce:reaction-social 0.4.0
* less@2.5.0_1 <- reactioncommerce:reaction-paypal 1.1.0
* less@2.5.0_1 <- reactioncommerce:reaction-stripe 2.1.0
Aaron Judd
@aaronjudd
Sep 26 2015 23:19
@cooloney please try doing meteor update again. I pushed some updates to the two packages that are causing you issues.
Bryan Wu
@cooloney
Sep 26 2015 23:32
cool, but i think you missed one more package
$ meteor update
This project is already at Meteor 1.2.0.1, the latest release.
=> Errors while upgrading packages:           

While selecting package versions:
error: Conflict: Constraint reactioncommerce:reaction-analytics-libs@1.1.0 is not satisfied by reactioncommerce:reaction-analytics-libs
1.0.1.
Constraints on package "reactioncommerce:reaction-analytics-libs":
* reactioncommerce:reaction-analytics-libs@1.1.0 <- reactioncommerce:reaction-analytics 1.1.0
reactioncommerce:reaction-analytics-libs needs update
Aaron Judd
@aaronjudd
Sep 26 2015 23:54
one more time.
these are the same packages that are in the development branches of each repo, but weren’t published. I would not have thought they needed to be, since the previous (updated packages for Meteor 1.2 had already been published)
but I had issues upgrading to Meteor 1.2 myself - everything had to be just right.. (package version wise). once upgraded it was all cool.