These are chat archives for reactioncommerce/reaction

8th
Oct 2015
Aaron Judd
@aaronjudd
Oct 08 2015 01:00
@/all v0.9.0 (beta-1) has been merged into development, master, and all packages have been published.
Bryan Wu
@cooloney
Oct 08 2015 01:02
@aaronjudd awesome, thanks a lot
Aaron Judd
@aaronjudd
Oct 08 2015 01:03
:thumbsup:
Li Ming
@limingth
Oct 08 2015 01:06
:clap:
Aesop7
@Aesop7
Oct 08 2015 04:01
YES!
Bogi
@boboci9
Oct 08 2015 08:37
:+1:
Has anyone ever used semanticUI components with reaction core? I tried but it's not working as it should be and I am suspecting some package incompatibility, so a feedback would be good if someone managed to use them together
Aleksei Mironov
@alexmironof
Oct 08 2015 14:57
Awesome news! Congrats! :clap: I'll check it today :smile:
Spencer Norman
@spencern
Oct 08 2015 15:53

Were there any structural changes to product methods in 0.9? I’m getting some failing tests that point to the products/cloneVariant method. (my tests are in a separate package)

Specifically getting this error:
TypeError: Cannot call method ‘push’ of undefined
Pointing at this line:
https://github.com/reactioncommerce/reaction-core/blob/development/server/methods/products.js#L41

Michael Jenny
@prinzdezibel
Oct 08 2015 15:56
:+1: Congrats to the Beta release
Spencer Norman
@spencern
Oct 08 2015 16:01
Figured it out - results is never initialized in this block. I’ll send a PR
Ash Ganatra
@ashga
Oct 08 2015 16:01
hi does any one know if reaction supports product attributes and filtering and sorting on these?
Aaron Judd
@aaronjudd
Oct 08 2015 16:18
@ashga yes on product attributes - and search with pinterest like tag search filtering is on our short term roadmap.
Aaron Judd
@aaronjudd
Oct 08 2015 16:24
@spencern likely to be a more than a few spots on this that there may be unintended consequences (because really the code is pretty much a rewrite over the last two releases). I’ll be creating a branch today, that focuses on getting tests back and running for everything as well.
Spencer Norman
@spencern
Oct 08 2015 16:24
Yeah, no worries. Just working through updating some of our packages. Overall pretty smooth, just a few hiccups.
Aaron Judd
@aaronjudd
Oct 08 2015 16:25
@prinzdezibel @kefirchik @Aesop7 :+1: in the same vein: PR’s or issues appreciated for anything you find!
hrath2015
@hrath2015
Oct 08 2015 16:26
@aaronjudd I see name is changed for 2 packages core and bootstrap theme. Any reasons?
also coretheme
Aaron Judd
@aaronjudd
Oct 08 2015 16:29
@hrath2015 I’m guessing you were using master/0.6.4? we didn’t rename any packages, but might have introduced the bootstrap-theme package since then. Functionally the same, bootstrap-theme is the builder-package that loads core-theme, this functionality used to be in core, and we move to it’s own package so that it’s easier to build custom themes
Spencer Norman
@spencern
Oct 08 2015 16:33
@aaronjudd also interested in a let vs const discussion now that we’ve migrated to ES6/2015
hrath2015
@hrath2015
Oct 08 2015 16:34
@aaronjudd thanks.
Aaron Judd
@aaronjudd
Oct 08 2015 16:36
@spencern yeah me too -I’ve been meaning to dig into that more. I started to use const in a few places, but wasn’t quite sure how it was working - for instance I thought that you could do const results= []; instead of let but still modify the value afterwards? The compiler was telling me that you can’t modify a read only value (which obviously IS what I would expect, but not what I think the docs say const will do.)
Spencer Norman
@spencern
Oct 08 2015 16:37
You can do const results = [] and then push into it
the main difference is that you can’t reassign const
e.g.
const a = 1;
a = 2;
Aaron Judd
@aaronjudd
Oct 08 2015 16:38
I had thought that was what I tried, but it was probably 3AM lol
Spencer Norman
@spencern
Oct 08 2015 16:38
lol, possibly your complier was grumpy too.
Aaron Judd
@aaronjudd
Oct 08 2015 16:39
atom-linter and atom-eslint, etc have basically been pushing out a new update every day - so I wouldn’t be surprised if it works now
Spencer Norman
@spencern
Oct 08 2015 16:40
yeah, I’m using atom-eslint and added the no-const-reassign rule to your .eslintrc file and have been using const primarily in the rental package
Aaron Judd
@aaronjudd
Oct 08 2015 16:40
in any case, with the results example - that’s exactly what I was planning there so if that’s what you do add to the PR, cool
Spencer Norman
@spencern
Oct 08 2015 16:41
ok, just didn’t want to start using unless there were plans to update most of the project in that direction. It looks funny to have just one ;)
Aaron Judd
@aaronjudd
Oct 08 2015 16:42
lol, well either work I guess - I’m in favor of using const though.
Spencer Norman
@spencern
Oct 08 2015 16:42
:+1:
Aaron Judd
@aaronjudd
Oct 08 2015 16:44
we’re really going to push ourselves for frequent releases going forward - these last ones have just been huge structurally - but the foundation is stable now ;-) (so easier to do small quick releases)
Spencer Norman
@spencern
Oct 08 2015 16:45
That’s great. Updated the PR. The stable base will be fantastic.
Aaron Judd
@aaronjudd
Oct 08 2015 16:47
:thumbsup: merged.
Paul Grever
@paulgrever
Oct 08 2015 17:07
Quick question - my settings.json for setting a default admin user no longer works after a bin/reset. Is there something I need to change so that I have a custom admin access? Or a new process?
Aaron Judd
@aaronjudd
Oct 08 2015 17:23
update the REACTION_AUTH, REACTION_EMAIL, REACTION_USER variables
(from METEOR_AUTH,etc)
btw - I much prefer setting them in my ENV along with PACKAGE_DIRS
Paul Grever
@paulgrever
Oct 08 2015 17:33
This is what I have in my settings.json and it keeps saying User not found when I try to login and it’s not created in the DB.
{
  "ROOT_URL": "",
  "MONGO_URL": "",
  "MAIL_URL": “”,
  "reaction": {
    "REACTION_USER": "Paul",
    "REACTION_AUTH": "testadmin",
    "REACTION_EMAIL": "paul@getoutfitted.com"
  },
  "isDebug": "info",
  "public": {
    "velocity:html-reporter": {
      "position": "top right",
      "tab-index" : 1
    }
  }
}
It’s also not showing up in initial start up when I start my server too
Aaron Judd
@aaronjudd
Oct 08 2015 17:34
2 seconds I’ll test that
Bryan Wu
@cooloney
Oct 08 2015 17:34
@aaronjudd I met the same issue as @paulgrever here
Spencer Norman
@spencern
Oct 08 2015 17:38
I have the same issue when using the settings.json file but when setting them as ENV variables it works fine.
this works: REACTION_USER=spencer REACTION_AUTH=password REACTION_EMAIL=spencer@example.com meteor
Aaron Judd
@aaronjudd
Oct 08 2015 17:47
yup, reviewing the logic now. To be honest, the use of settings was just a leftover meteor thing, that I reallly don’t agree with but have left for convienance and because of lot of meteor packages use it. I clearly borked this while refactoring fixtures! keep the bugs coming , we’ll release them in a update today. you can use ENV for now
Michael Jenny
@prinzdezibel
Oct 08 2015 18:00
@aaronjudd Are there any plans for a amazon payments plugin?
Aaron Judd
@aaronjudd
Oct 08 2015 18:02
not on my radar, but payment packages really aren’t to tough to write. We’re also looking at a couple payment solutions that have a generic api, that allow for many different providers - similar to segment.io, but for payments. (open to suggestions on this) - that would be ideal package to cover as many cases as possible without having to develop packages for each payment vendor
Michael Jenny
@prinzdezibel
Oct 08 2015 18:15
Do you have an example of an generic api provider at hand?
perpi
@perpi
Oct 08 2015 18:15
http://demo.reactioncommerce.com --> 0.9? --> If yes, there are some problems with RTL when I choose Arabic, especially on products.
Aaron Judd
@aaronjudd
Oct 08 2015 18:17
@prinzdezibel I have a meeting with these guys tomorrow: https://accepton.com
@perpi demo not updated. we haven’t touched much (RTL) in this release, so the same issues probably exist - it’d be great if you could create an issue, maybe with some screenshots so we understand
Bryan Wu
@cooloney
Oct 08 2015 21:59
@aaronjudd looks like the facebook login button is gone in beta, is there any way to bring it back?
Aaron Judd
@aaronjudd
Oct 08 2015 22:06
in the admin dashboard, accounts settings
all the meteor auth packages, except meteor developer auth are now included there
even if you have it in your local settings.json (or use enable:true), otherwise you need to enable it from admin
Aaron Judd
@aaronjudd
Oct 08 2015 22:12
@cooloney @paulgrever fixtures fixes for REACTION_AUTH,etc fixed, pushed and published in 0.9.1
Bryan Wu
@cooloney
Oct 08 2015 22:17
@aaronjudd awesome, appreciate and I verified the facebook/twitter/github sign in works fine now
Aaron Judd
@aaronjudd
Oct 08 2015 22:17
:thumbsup: @mikemurray