These are chat archives for reactioncommerce/reaction

15th
Oct 2015
Spencer Norman
@spencern
Oct 15 2015 00:05
@mikemurray you’ve probably seen this, but it was helpful for me just now in understanding a bit more about the less import system: meteor/meteor#5242
Mike Murray
@mikemurray
Oct 15 2015 00:11
nice. I'm going to dig deeper to see how crazy we can get with the imports cross package
I import all over the place :)
danielortiz
@danielortiz
Oct 15 2015 00:48
I don't know why, but reaction is not giving me a new user and password anymore after I run "meteor reset"
Mike Murray
@mikemurray
Oct 15 2015 00:50
@danielortiz which version of reaction?
danielortiz
@danielortiz
Oct 15 2015 00:50
I just cloned it from master
Mike Murray
@mikemurray
Oct 15 2015 00:52

hmm.

I have this exported in my .profile

export REACTION_USER="display name"
export REACTION_AUTH="some_password"
export REACTION_EMAIL="email_address@something.com"
so when you do a meteor reset, it'll use those values
danielortiz
@danielortiz
Oct 15 2015 00:52
hmmm
Aaron Judd
@aaronjudd
Oct 15 2015 00:52
@danielortiz I just tested, both with ENV vars set like @mikemurray as well as PACKAGES_DIR="" REACTION_USER="" REACTION_AUTH="" REACTION_EMAIL="” meteor and it worked..
it’s a bit further up in the output than it used to be, sure you’re looking hard enough for it? lol
danielortiz
@danielortiz
Oct 15 2015 00:54
I was, tried multiple times..just deleted and cloned again, let's see
Aaron Judd
@aaronjudd
Oct 15 2015 00:55
that comes from reaction-core, maybe you need to pull that as well (although the most recently published packages work, hence my PACKAGES_DIR test)
danielortiz
@danielortiz
Oct 15 2015 00:56
that's weird, completely removed reaction and cloned again
still nothing
Aaron Judd
@aaronjudd
Oct 15 2015 00:57
very strange -> the only thing that would prevent it from displaying the admin user credentials (on purpose) would be if there was already an existing admin user
danielortiz
@danielortiz
Oct 15 2015 01:00
I do need to buy a ssd. My mac take years to run meteor
Aaron Judd
@aaronjudd
Oct 15 2015 01:01
what we need is for Apple to release new a MBP!
danielortiz
@danielortiz
Oct 15 2015 01:02
I'm brazilian, I won't be seeing any new MBP any time soon =P
Aaron Judd
@aaronjudd
Oct 15 2015 01:02
You can sneak them over the border from Paraguay can’t you? ;-)
danielortiz
@danielortiz
Oct 15 2015 01:03
hahaha not that easy..1 USD = 4 BRL..it's insane
it already was even when 1USD was 2BRL..the salary difference is huge
a senior developer here makes about what a macdonalds employee makes in US =P
Aaron Judd
@aaronjudd
Oct 15 2015 01:04
for such a Linux orientated country, you’d think they would make an exception for Macs
danielortiz
@danielortiz
Oct 15 2015 01:06
that's the way I'm gonna stick with my mid 2012 MBP for a while =P
Aaron Judd
@aaronjudd
Oct 15 2015 01:07
hey - that’s still what I’m working with.. got rent to pay which is probably 4x the rent there.. maybe it all works out in the end.
danielortiz
@danielortiz
Oct 15 2015 01:08
hahaha sure..I'm not complaining about my MBP, it does the job..a new SSD drive will do
Aaron Judd
@aaronjudd
Oct 15 2015 01:09
you could try doing bin/reset and bin/clone-packages.sh if you want to really get all the most recent stuff to see if that fixes the issue. (beware: this is the heavy stick approach)
danielortiz
@danielortiz
Oct 15 2015 01:09
what I feel most is not being able to buy a good gaming pc =(
hahahaha
I think I know what happened..maybe (i say maaaybe) I was with mongo running, and it waas preventing something to do something else, etc
anyway, closed the terminal, cloned the repo and it worked
=)
Aaron Judd
@aaronjudd
Oct 15 2015 01:12
:thumbsup:
danielortiz
@danielortiz
Oct 15 2015 01:13
thank you guys
CA99
@CA99
Oct 15 2015 01:18
thanks
Aaron Judd
@aaronjudd
Oct 15 2015 01:19
you can reuse that function anywhere to make life a bit easier -> you (may)have to do it right before you send the mail
danielortiz
@danielortiz
Oct 15 2015 03:14
same problem again =/
no idea whats happening
blob
could have something to do with this error?
Aaron Judd
@aaronjudd
Oct 15 2015 03:36
that looks like a registerPackage error, where “provides: “ should be in the package registry entry
Aaron Judd
@aaronjudd
Oct 15 2015 03:42
that could cause the failure because // create default admin user ReactionRegistry.createDefaultAdminUser(); runs after the package entries are loaded in core/server/fixtures.js.
we probably could move that before the packages load routines, just for convienance sake.
Aaron Judd
@aaronjudd
Oct 15 2015 04:37
@danielortiz pull reaction-core development branch, I’ve updated the fixtures load order to load the admin user earlier. This way there shouldn’t be any problems if a package load fails.
tested your issue by adding a Provides: ‘’ to an existing package, and that did cause the error.
should make development a little easier in any case (but the problem is still a bad registry entry)
Aaron Judd
@aaronjudd
Oct 15 2015 04:46
fyi: the error is that Provides: should be provides:.
Rashid Omar
@rashthedude
Oct 15 2015 09:45
Sorry if this question sounds rather stupid but does Reaction have an admin back-end area?
I haven't had the chance to look into it as of yet
JF
@cloudzombie
Oct 15 2015 09:47
The front end is the back end. From. My limited use.
Aleksei Mironov
@alexmironof
Oct 15 2015 09:47
@rashthedude actually there is route for /dashboard and editing integrated directly into frontend
Rashid Omar
@rashthedude
Oct 15 2015 09:48
thanks @kefirchik
so for statistics, billing informations etc should be found in /dashboard
Aleksei Mironov
@alexmironof
Oct 15 2015 09:51
@rashthedude no problem :smile:
yes, everything is in dashboard (when you log in as admin you can open it from profile dropdown menu)
Rashid Omar
@rashthedude
Oct 15 2015 09:57
sweet
danielortiz
@danielortiz
Oct 15 2015 14:39
ow, thank you @aaronjudd, I'm gonna try that
Spencer Norman
@spencern
Oct 15 2015 16:54
@mikemurray thanks for the repo!
CA99
@CA99
Oct 15 2015 20:45
blob
well that was interesting...
what do you guys typically do for SMTP relaying for development/testing purposes?
Spencer Norman
@spencern
Oct 15 2015 20:46
I use mandrill usually
SendGrid lets you send up to 12k transaction emails a month for free
Mike Murray
@mikemurray
Oct 15 2015 20:59
@CA99 SendGrid, Mailgun (love that name) and Mandrill ( what i use personally)
CA99
@CA99
Oct 15 2015 20:59
SendGrid requires corporate info (we're not that far yet), Mandrill is offline for some reason.
I might just have to go with a local SMTP server, but I was hoping Gmail would work.
Spencer Norman
@spencern
Oct 15 2015 21:00
If you can’t get either SendGrid or Mandrill to work, then Mailgun is a great option
Mike Murray
@mikemurray
Oct 15 2015 21:01
hmm, just signed in to https://mandrillapp.com/ , unless you mean their mail service itself is down
CA99
@CA99
Oct 15 2015 21:06
mandrill.com is what's down; might just be a DNS problem for me (I'm on Google's DNS). anyway, MailGun seems to be working pretty well; I'll give it a go.
Mike Murray
@mikemurray
Oct 15 2015 21:07
:thumbsup:
Spencer Norman
@spencern
Oct 15 2015 22:25
Are front end tests working as expected currently? (on dev)
Aaron Judd
@aaronjudd
Oct 15 2015 22:41
@spencern sort of… they’re a little unpredictable. If they don’t pass, a refresh or two later they will.
I’ve got 49 tests passing right now
Spencer Norman
@spencern
Oct 15 2015 22:42
Ok, that’s what I was seeing on my end as well, so just making sure my code’s not breaking anything
Aaron Judd
@aaronjudd
Oct 15 2015 22:42
but on a fresh clean install, I had 3 failures, then they pass
Spencer Norman
@spencern
Oct 15 2015 22:42
I’m seeing fluctuation between 2 fails and 10 fails
Aaron Judd
@aaronjudd
Oct 15 2015 22:42
so there are some timing issues...
Spencer Norman
@spencern
Oct 15 2015 22:42
have yet to see them all pass
Aaron Judd
@aaronjudd
Oct 15 2015 22:43
I’ve got solid green at the moment… but it’s annoyingly unstable - I don’t think we’ve quite got a handle on writing these yet..
Spencer Norman
@spencern
Oct 15 2015 22:44
It’s always these two that fail for me too: Product.meta data: should have a title set to Example Productand Router.Index.meta data: should have a title set to Index
Aaron Judd
@aaronjudd
Oct 15 2015 22:44
oh funny - I never see those - my failures are always on guest login, or checkout address adds
Spencer Norman
@spencern
Oct 15 2015 22:44
Had the guest one and the checkout address one earlier
Aaron Judd
@aaronjudd
Oct 15 2015 22:45
I thought I squashed that index one a while ago sigh
I think we should offer a bounty for passing (valid) tests… any volunteers? lol
Spencer Norman
@spencern
Oct 15 2015 22:45
lol
Just finished up a refactor of all of the factories so that we can use them on our end for various things, hopefully they will make writing core tests easier too
Aaron Judd
@aaronjudd
Oct 15 2015 22:47
I do think the major problem is timing, and I sort of discovered the waitForElement helper about 1/2 through writing these… in many cases that solves the issues
though I suspect UI / client tests are always likely to be fragile
Spencer Norman
@spencern
Oct 15 2015 22:48
agreed. Client tests are really nice to have, but always a pain in my experience
@paulgrever found the waitForElement helper essential in a few client tests he’s written too
Aaron Judd
@aaronjudd
Oct 15 2015 22:49
the factories are big help. those server integration tests are the ones I care about the most
as you probably noticed, got all the CI stuff back running today, and they are just running the server tests
(also automatically pushing new docker builds out after each successful test)
Spencer Norman
@spencern
Oct 15 2015 22:51
Yeah, thats good. I stole your circle.yml file for one of our packages as well. Couldn’t figure that out on my own for the life of me.
Nice work on the docker builds, I haven’t waded too far into that yet
Aaron Judd
@aaronjudd
Oct 15 2015 22:51
only took like 4 months, lol
Spencer Norman
@spencern
Oct 15 2015 22:51
lol
Aaron Judd
@aaronjudd
Oct 15 2015 22:52
docs and tests are my remaining vacation goals (oh and a blog post or two)
Spencer Norman
@spencern
Oct 15 2015 22:52
I spent like 3 hours on it and then saw a random commit message to core that mentioned circle and just flat copied it.
Aaron Judd
@aaronjudd
Oct 15 2015 22:52
the core circle.yml is the one to copy. The one in reaction is doing a whole lot more - you don’t want all that
Spencer Norman
@spencern
Oct 15 2015 22:53
yeah, that’s what I learned
Aaron Judd
@aaronjudd
Oct 15 2015 22:54
it’s about time to start requiring tests for PR’s ;-)
Spencer Norman
@spencern
Oct 15 2015 22:55
Looking forward to it.
Aaron Judd
@aaronjudd
Oct 15 2015 22:56
:thumbsup:
Aaron Judd
@aaronjudd
Oct 15 2015 23:02
oh - and localization fixes - since I’m in MX ;-)
Spencer Norman
@spencern
Oct 15 2015 23:02
Doing some localized user testing while you’re down there? ;)
Aaron Judd
@aaronjudd
Oct 15 2015 23:03
exactly! it’s the only way to really test these things.. (that’s what I claim at least)
@CA99 I’m using Mailgun for my tests, that works great for me and seems to be the fastest (and free for 300 tests a day)
mandrill is the slow dog. I wouldn’t bother unless you need mailchimp
CA99
@CA99
Oct 15 2015 23:34
Mailgun's definitely working quite well; I got some emails to send from a separate meteor test app (using the Mail.send code from Meteor's documentation). on Reaction, I'm getting a 403 error; looking into it.
Aaron Judd
@aaronjudd
Oct 15 2015 23:38
@CA99 make sure you pull the latest - I actually fixed an error last night where I was getting a timeout, could be the same thing
oh - and I switched to using port 587, 25 was giving me a error as well (probably just my local internet here blocking it)
CA99
@CA99
Oct 15 2015 23:48

I'm on the latest git pull so far.

Error is "Unable to send invitation email. [403]" from dashboard/accounts. I don't see errors in the server console.

The emails from my test app (basically the app you get from meteor create, plus the mail code added in) is sending normally. Both apps have the same process.env.MAIL_URL, so I'm pretty sure there's no issues with ports getting blocked. (no port is specified in the SMTP string)

also thinking of setting "isDebug": "info" in the settings.json file to "error" or something; see if that makes it more verbose.
Aaron Judd
@aaronjudd
Oct 15 2015 23:52
hmm, I tested that same thing last night (worked), maybe you should try adding the port. all the code is in that same block I pointed at the other day though. I only tested with setting in settings.json and in reaction.json, not with setting MAIL_URL though, so I might have screwed that up
isDebug: debug is the more verbose version, I suspect you won’t get much more info there though
CA99
@CA99
Oct 15 2015 23:54
I tested with MAIL_URL set through the settings json file (for both meteor apps), and verified that it propagated to process.env.MAIL_URL in meteor shell.
Aaron Judd
@aaronjudd
Oct 15 2015 23:55
as long as it’s set in process.env it should be good, I think
I sort of regret allowing so many configuration options ;-) everytime I look at it my head spins :worried: