These are chat archives for reactioncommerce/reaction

16th
Oct 2015
CA99
@CA99
Oct 16 2015 00:06
I switched to port 587 on both apps; same results where reaction displays the web frontend error 403, while the meteor test app sends successfully.
Aaron Judd
@aaronjudd
Oct 16 2015 00:07
interesting, I’ll give it another going through see if I can replicate
CA99
@CA99
Oct 16 2015 00:07
this is via dashboard/accounts - add member
I'm using mailinator addresses. next up, I have to figure out how to trim down the guest list of all those guest users I created. (haven't been able to locate it in MongoDB quite yet but I'm still kind of learning how to use it in the first place.)
Aaron Judd
@aaronjudd
Oct 16 2015 00:10
I just successfully invited myself (alt. email)…
(using mailgun)
CA99
@CA99
Oct 16 2015 00:11
hmm... maybe git's doing something odd. I'll dig through it.
I have reaction and reaction-core, and both mention up-to-date on git pull. git HEAD shows it's on development as well.
Aaron Judd
@aaronjudd
Oct 16 2015 00:12
:thumbsup: (I set the mail url using the private/settings/reaction.json method)
CA99
@CA99
Oct 16 2015 00:41
Yeah, git's definitely behaving oddly; I'll sort that out eventually on my end. right now, the error is gone, but it's still sending the email to the console instead of MAIL_URL; I think that env var has to be set before launching the server in this particular case. (I tried:
process.env.MAIL_URL = Meteor.settings.MAIL_URL
as well as
MAIL_URL = Meteor.settings.MAIL_URL
in the meteor shell, and the behavior didn't change.) Again, looks to be an issue on my end.
Spencer Norman
@spencern
Oct 16 2015 00:50
I had to export MAIL_URL= to get the mail working on my end. reaction.json did not work for me. Only testing with the email sent out to the initial user.
Aaron Judd
@aaronjudd
Oct 16 2015 00:51
knowing me, I probably fixed reaction.json and broke the export… :fire:
I’ll test it later tonight, but I do know the mail itself is working...
Spencer Norman
@spencern
Oct 16 2015 00:53
Yeah, worked for me :+1:
Anmol Agrawal
@anmolonruby
Oct 16 2015 06:59
Just curious, is there any company/startup that's using reaction commerce right now. Please share their links so that I can get a feel of it.
Aleksei Mironov
@alexmironof
Oct 16 2015 09:03

@mikemurray please check out dukeondope/reaction-core@f68fb9d and dukeondope/reaction-core-theme@a205621

is there a better way to implement such kind of stuff?
or is there a chance to make it a default option for reaction in the future?

https://files.gitter.im/reactioncommerce/reaction/ZyY1/blob

newsiberian
@newsiberian
Oct 16 2015 09:11
@mikemurray, hello, I guess there is a typo in reaction-core/client/templates/layout/header/i18n/i18n.js line 12: language.label.toLowercase
Aaron Judd
@aaronjudd
Oct 16 2015 13:42
@newsiberian committed fix: reactioncommerce/reaction-core@af54e96
Michael Jenny
@prinzdezibel
Oct 16 2015 15:39
@aaronjudd Re: Hi Aaron. Of course I can write an integration test. But I need a kick starter on how I should do this. Can you give me a dry advise? Thank you.
Aaron Judd
@aaronjudd
Oct 16 2015 15:47
@prinzdezibel core/tests/jasmine/server/integration/methods.js is probably the best one to look at for an example. No worries though, give me a few [days] and I’ll write some cart tests that we can use as a blueprint for writing some more, it might be a bit much too ask right now, but thinking it’s a good thing to start requesting - if nothing else, to see how easy it is for others. I’ve written up some testing docs https://github.com/reactioncommerce/reaction/blob/development/docs/developer/testing.md - let me know what you think I should add to help.. probably some examples to begin with?
Michael Jenny
@prinzdezibel
Oct 16 2015 15:48
how do I run the tests?
Aaron Judd
@aaronjudd
Oct 16 2015 15:49
VELOCITY_TEST_PACKAGES=1 meteor test-packages --port 3006 reactioncommerce:core
(to run at the same time as your regular install, but on another port)
Aaron Judd
@aaronjudd
Oct 16 2015 16:00
or a more verbose version:
VELOCITY_TEST_PACKAGES=1 meteor test-packages --driver-package velocity:html-reporter --port 3006 --velocity reactioncommerce:core
and btw - nothing about getting tests going have been easy - so I don’t have high expectations! lol
Mike Murray
@mikemurray
Oct 16 2015 16:05

@kefirchik you could override the template instead of changing it in core. see https://github.com/reactioncommerce/reaction/blob/master/docs/developer/templates.md.

Otherwise, at the moment thats how you would do it. Override the theme and modify it to your needs.

Of course in the future I want to show the image / color of a variant. That whole product page is due for a overhaul.

Michael Jenny
@prinzdezibel
Oct 16 2015 17:15
@aaronjudd :thumbsup: Tests are important. But getting it right is a PITA. I really struggle with them in all my projects.
Michael Jenny
@prinzdezibel
Oct 16 2015 18:00
@aaronjudd: Is the test framework also suitable for client side tests?
Something like Selenium?