These are chat archives for reactioncommerce/reaction

16th
Dec 2015
pixelpunch
@pixelpunch
Dec 16 2015 09:45
@aaronjudd Thanks. Will do that.
elkridgelodge
@elkridgelodge
Dec 16 2015 12:52
can i not include template files in a package? it keeps saying "couldn't find a file are you sure you defined it?" unless i manually put it in the app
i'm using api.addAssets on an .html file for e.g.
elkridgelodge
@elkridgelodge
Dec 16 2015 14:15
okay i'm starting to see i have to include blaze-html-templates and maybe a bunch of other stuff in the package
Mike Murray
@mikemurray
Dec 16 2015 15:48
@elkridgelodge thats right, your package.js file is a manifest of all the files your package uses for itself, or exposes for other packages to use. Very much in the same vain as script tags in HTML
Bogi
@boboci9
Dec 16 2015 15:52

Hi, I still have some questions regarding the coreorderworkflows, there are a lot of calls in the code like, could someone help me out in the reason so I can add my new workflow steps

  Meteor.call("workflow/pushOrderWorkflow", "coreOrderWorkflow", "coreProcessPayment", template.order._id);

or in the shipping step

Template.coreOrderShippingSummary.events({
      "click .btn": function () {
        Meteor.call("workflow/pushOrderWorkflow", "coreOrderWorkflow", "coreOrderCreated", this._id);
       }
    });

although the order has been previously forced in the coreOrderCompleted step. This means if I add some new workflow steps when these lines are called my order is forced to step in the next step although it's not called coreProcessPayment (this doesn't even exists) or 'coreOrderCreated' but that is how the workflow/pushOrderWorkflow works that it will take the next registered step not the parameter so my order jumps though all my steps because of these calls

Aaron Judd
@aaronjudd
Dec 16 2015 15:56
@boboci9 the workflow isn't fully finalized - we're just going to use "new", "coreOrderCreated"(rename to coreOrderPending?), "coreOrderCompleted" at the order level. We'll strip out the other ui/steps (although, we'll update pushOrderWorkflow so that you can add / remove whatever you need).. moving the payment processed, shipping, etc to line item workflows, and once they are all completed (as a shipment), the order will get coreOrderCompleted.
we started out working on just the major order flow, but realized partly through it that we ought to do everything at the line item, not really the order -> gives us more flexibilty for multi-vendor/marketplaces/split shipments..
but wanted to get a working order flow out so that it can be used.. we'll have this updated quickly though
Mike Murray
@mikemurray
Dec 16 2015 16:00
@aaronjudd @boboci9 "new" (orders created by user), "coreOrderPending" (orders accepted by the shop, and being actively fulfilled), "coreOrderCompleed" (shipped, captured, fully / partually refunded, canceled, or otherwise done)
@aaronjudd coreOrderPending === coreOrderProcessing
Bogi
@boboci9
Dec 16 2015 16:05
I see and do you know when can these changes be expected as I will have to redo these steps in my packages as well?
Aaron Judd
@aaronjudd
Dec 16 2015 16:08
@boboci9 working on it now..
Bogi
@boboci9
Dec 16 2015 16:10
ok thanks, I will subscribe to this issue to stay up to date with the develpoment
Mike Murray
@mikemurray
Dec 16 2015 16:11
@boboci9 and i'll keep it updated with my progress
Bogi
@boboci9
Dec 16 2015 16:11
thanks :+1:
Bogi
@boboci9
Dec 16 2015 18:34
Does it evey happen to anyone else that the login dropdown/user dropdown is not working (not opening)?
Mike Murray
@mikemurray
Dec 16 2015 18:35
@boboci9 any errors in the js console / terminal?
Bogi
@boboci9
Dec 16 2015 18:35
no none, I tried debugging it but it's hard since no errors anywhere, it just stopped opening
but if noone else has this issue it might be one of my packages so I will remove them one by one to see what could cause it
Aaron Judd
@aaronjudd
Dec 16 2015 18:38
haven’t seen that.. did you have packages modifying the accounts?
Bogi
@boboci9
Dec 16 2015 18:39
no, but I had to add a new bootstrap package to have the glyphicons showing up it could be causing the dropdown not to answer
btw the dropdown is there and it's filled correctly it's just not opening
Aaron Judd
@aaronjudd
Dec 16 2015 18:40
weird
maybe if there were more than one of the same element that the dropdown is triggered on?
Bogi
@boboci9
Dec 16 2015 18:42
yes very weird, I am debugging this but I don't have anything changing this part, I just have one registry entry with userDropdown but that has never caused issues before
Mike Murray
@mikemurray
Dec 16 2015 18:43
It might be both versions of the bootstrap JS/CSS fighting each other
Bogi
@boboci9
Dec 16 2015 18:45
with the previous bootstrap I was able to add glyphicons but this one doesn't support it so I needed a new bootstrap
:( this was it
Mike Murray
@mikemurray
Dec 16 2015 18:46
would the glyphicons package not do? https://atmospherejs.com/bootstrap3/glyphicons
and flagged as not working :(
Bogi
@boboci9
Dec 16 2015 18:46
I have less versioning issue if I try this
Aaron Judd
@aaronjudd
Dec 16 2015 18:47
personally, I’d just drop the css import in and forget about the package :fire:
Bogi
@boboci9
Dec 16 2015 18:47
yepp not working, I tried it, conflict between the two less versions, this uses a very old less
Mike Murray
@mikemurray
Dec 16 2015 18:48
which bootstrap package are you using?
Bogi
@boboci9
Dec 16 2015 18:48
@aaronjudd ,good idea I will try that thanks