These are chat archives for reactioncommerce/reaction

18th
Dec 2015
newsiberian
@newsiberian
Dec 18 2015 05:29
@aaronjudd, hello, is this fine?
Aaron Judd
@aaronjudd
Dec 18 2015 05:31
no that’s wrong…fix committed.
newsiberian
@newsiberian
Dec 18 2015 05:33
Thanks)
newsiberian
@newsiberian
Dec 18 2015 07:35

@aaronjudd, in accounts tests in Factory.create("user").profile i see:

I20151218-13:31:00.997(6)? { name: 'Anne Dooley',
I20151218-13:31:00.997(6)?   email: 'Dereck.Wuckert90@gmail.com',
I20151218-13:31:00.998(6)?   profilePictureUrl: 'http://lorempixel.com/640/480' }

this is not that we are expected to see. In factories/common/factories/account.js we have:

profile: {
    addressBook: [
      faker.reaction.address()
    ]
  },

Any ideas why result is different?

newsiberian
@newsiberian
Dec 18 2015 07:47
This message was deleted
Ups. my fault. I ran Factory.create("user") instead of Factory.create("account")
Aaron Judd
@aaronjudd
Dec 18 2015 07:52
:+1:
newsiberian
@newsiberian
Dec 18 2015 08:40
@aaronjudd, I notice that currently accounts._id is equal with users._id, but in factories we have this props not equal which could be right. Any thoughts?
Aaron Judd
@aaronjudd
Dec 18 2015 08:44
while it’s convenient to have them be equal, I don’t think it’s something we should depend on, which is why there is a userId in Accounts
newsiberian
@newsiberian
Dec 18 2015 08:47
I see...
@aaronjudd, this makes things more complex... will we have a situations when user will have several accounts?
rkhunter
@rkhunter
Dec 18 2015 12:08
I cannot manage to add a custom translation
I want to put it into packages/reaction-core/private/data/i18n/bg.json
rkhunter
@rkhunter
Dec 18 2015 12:19
adding a line in packages/reaction-core/private/package.js does not help
newsiberian
@newsiberian
Dec 18 2015 12:59
@rkhunter, hi, you can try to add a record somewhere here, then you will need to reset the reaction, I guess.
rkhunter
@rkhunter
Dec 18 2015 13:17
new Translation is imported in console output
still not in UI
after ./reaction reset it appeared
how would I supply new translation to git repo?
Aaron Judd
@aaronjudd
Dec 18 2015 16:34
@newsiberian no - sorry didn't mean to imply that (not planning on multiple accounts- at least for core). core functionality is one account -> multiple shops.
@rkhunter you can submit a PR, to get your currency added