These are chat archives for reactioncommerce/reaction

3rd
Feb 2016
irwynks
@irwynks
Feb 03 2016 04:57
This is easily the most exciting thing I've come across in the past two years.. :)
Brent Hoover
@zenweasel
Feb 03 2016 08:21
@irwynks Thanks! We’re pretty excited too.
Aaron Judd
@aaronjudd
Feb 03 2016 17:14
@PaulSavignano you can create any .js file, so “client/template.js” is just an example, showing how you can extend the template with “template.replaces” - v0.12 is a big update for all of this - doc updates needed.
Israel Ortiz
@soyisraelortiz
Feb 03 2016 17:48
where can i find layoutHeader ? i want to change the logo
Israel Ortiz
@soyisraelortiz
Feb 03 2016 17:54
found it packages/reaction-core/client/components/header.html
rkhunter
@rkhunter
Feb 03 2016 19:01
How can I download v12?
I tried the way to pull from git hub but it doesn't seem to work (i get v11 instead)
David Rynearson
@The-Outrider
Feb 03 2016 20:11
not seeing a v12 in the official releases https://github.com/reactioncommerce/reaction/tags
otherwise you can do a git checkout of the feature-0.12 branch
git fetch, git checkout features-v0.12
@rkhunter
Paul Savignano
@PaulSavignano
Feb 03 2016 20:48
@aaronjudd Thanks!
Aaron Judd
@aaronjudd
Feb 03 2016 21:17
@The-Outrider @rkhunter if you want to use the feature-0.12 branch, you need to pull all the repo packages branches as well feature-route-502 branches. (just in the packages)
David Rynearson
@The-Outrider
Feb 03 2016 21:24
@aaronjudd good to know thanks mate.
Spencer Norman
@spencern
Feb 03 2016 22:07
Will packages currently using an iron-router routing scheme continue to work in 0.12 or will all packages need to be migrated to flow-router and use the new routing registry before they will work in 0.12?
rkhunter
@rkhunter
Feb 03 2016 22:20
@aaronjudd @The-Outrider alright, thanks. Will check it out tomorrow
Aaron Judd
@aaronjudd
Feb 03 2016 22:30
@spencern bit of a complicated answer. most things should just be fine. Router changes to ReactionRouter, I thought about wrapping that as Router to not break existing packages (with warnings) but felt like it’s better to make a clean break
However the reason I say most things will be fine, as the registry is used for most routes now
I’ll probably end up just throwing some warnings on the older Router use, - path updates should be pretty easy, it’s mostly a search and replace kind of update
Spencer Norman
@spencern
Feb 03 2016 22:34
Yeah, we may have some bigger issues as we are currently using router level subscriptions, etc and not registering a lot of our routes currently, but we were planning to move to flow-router and template based subscriptions anyway, so this will probably force our hand on that.
Aaron Judd
@aaronjudd
Feb 03 2016 22:35
it’s not really that bad… you can do the subscriptions in flow-router but they are removing that in the next release, and recommend template level. I’ve moved all the subs in the template but really not much effort.
things are 5x faster though… just in how everything feels/responds
and much easier to understand / code.. .
Spencer Norman
@spencern
Feb 03 2016 22:37
yeah, agreed. I much prefer the style behind flow router
Just wasn’t quite available when we started
Aaron Judd
@aaronjudd
Feb 03 2016 22:51
I thought about making the reaction-router work with both flow-router and iron-router - there’s a package out there to wrap both into a single api, but I decided that would be a project for someone else ;-)
re: the registry -> it doesn’t change though and the routes define in the registry will work out of the box
Spencer Norman
@spencern
Feb 03 2016 23:44
ok, looking forward to 0.12 and that will be a good impetus for us to move all of our subs to templates
We’ve needed to do that refactor anyway
How much are you guys testing master currently? We’ve just started to write tests again after a couple months of not writing any. Have run into a few issues with old factories not working, but seems like it’s coming back together pretty quickly.