These are chat archives for reactioncommerce/reaction

18th
Feb 2016
Spencer Norman
@spencern
Feb 18 2016 00:31
It doesn’t seem like shopName is set when I run ReactionCore.getShopName() in my routes.js file.
Adel Abula
@Adel-Magebinary
Feb 18 2016 00:50
hey guys
first time here
any one can please send me a demo to play with?
Brent Hoover
@zenweasel
Feb 18 2016 00:51
Hi @Adel-Magebinary . You can download the product and try it out locally by following the instructions here https://docs.reactioncommerce.com/reaction-docs/development/installation
Adel Abula
@Adel-Magebinary
Feb 18 2016 00:56
Sounds good. does it come with demo data?
do you know where's the most up to date documentation?
Brent Hoover
@zenweasel
Feb 18 2016 00:57
Yes it does. You should be able to play around with it right away.
Adel Abula
@Adel-Magebinary
Feb 18 2016 00:58
Nice. are you guys open to contribution?
I got a team of four.
Brent Hoover
@zenweasel
Feb 18 2016 00:59
Yes, very. If you look at our history, you see we accept PR’s from contributors every week
Adel Abula
@Adel-Magebinary
Feb 18 2016 00:59
I thought they were internal PR
Brent Hoover
@zenweasel
Feb 18 2016 01:00
We do both. And we have a few outside contributors who have been added as “collaborators"
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:00
let me check the repo and doc properly first
are you guys on JIRA?
Brent Hoover
@zenweasel
Feb 18 2016 01:02
No, we do everything right here on Github
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:03
just got it
cool looking good man.
Brent Hoover
@zenweasel
Feb 18 2016 01:03
That’s an overview of issues/PR’s etc for all Reaction-related repos
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:13
feature usually is not most important for eCommerce platform. The key is the localization - the stemless integration to local apps.
I think that's how Magento got so big.
I have been working on magento projects for 5 years.
it's a good platform but it makes simple things to complicated.
Brent Hoover
@zenweasel
Feb 18 2016 01:14
Yes, I think almost every at RC has worked with Magento
Yes, not being like Magento was a big design goal. Especially in configuring products, etc.
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:15
I can help you guys with some localization in the future.
payment gateway integrations
shipping gateways
for new zealand / au
Brent Hoover
@zenweasel
Feb 18 2016 01:16
Yes, we are always looking to expand those areas. You may want to look at https://github.com/reactioncommerce/reaction-paymentmethod which is a template package I wrote for creating payment providers
We are just starting to add shipping gateways, it’s my next project
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:17
sounds good. Let me have a look
Brent Hoover
@zenweasel
Feb 18 2016 01:19
Just an FYI that just as of a few hours ago we just merged in a big rewrite of the routing package. So you may see a little discrepency between the docs and the code on development right now until Aaron has a chance to update the docs
@spencern Aaron’s not ignoring your question, he’s driving home in LA rain traffic
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:24
blob
stuck here for while.
Brent Hoover
@zenweasel
Feb 18 2016 01:25
Yes, it takes a while to download all the dependencies. Not sure what results you will get with running sudo
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:26
cp: cannot create regular file ‘/usr/local/bin/clone-packages.sh’: Permission denied
Brent Hoover
@zenweasel
Feb 18 2016 01:26
What platform are you on?
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:26
ubuntu 14.04
Brent Hoover
@zenweasel
Feb 18 2016 01:28
It still should work. Downloading packages from Atmosphere can be slow. There’s nothing really Reaction-specific going on there, that’s just Meteor starting up
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:29
yep. would be good to know what's been downloading.
if it things break up, I at least know where to start
Brent Hoover
@zenweasel
Feb 18 2016 01:29
well, it will always pick up where it left off
@jshimko Should reaction install still work if he runs it under sudo or should he just fall back to install the dependencies manually?
Aaron Judd
@aaronjudd
Feb 18 2016 01:38
@zenweasel I’m not that weak - I was cycling home in the rain! :bike:
Brent Hoover
@zenweasel
Feb 18 2016 01:40
No disrespect intended. It can take 45 minutes to drive home in the rain in LA
Jeremy Shimko
@jshimko
Feb 18 2016 01:40
Meteor and Reaction definitely don’t require root priviledges to install, but Node/NPM likely does on Ubuntu. That said, I’d probably try running ./reaction install without sudo and then provide a password when prompted for the Node install.
Brent Hoover
@zenweasel
Feb 18 2016 01:40
It just fails on the cp command
Jeremy Shimko
@jshimko
Feb 18 2016 01:40
But let me fire up an Ubuntu VM and confirm that. Been a while since I’ve done it.
Brent Hoover
@zenweasel
Feb 18 2016 01:41
cp: cannot create regular file ‘/usr/local/bin/clone-packages.sh’: Permission denied
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:41
it's just trying to write on /usr/local/bin
and npm requires sudo with -g
if you install without -g , it should be fine.
Jeremy Shimko
@jshimko
Feb 18 2016 01:43
I haven’t used this with Ubuntu in a while. I’m going to have to fire up a VM before I can suggest anything useful. Give me a few
Brent Hoover
@zenweasel
Feb 18 2016 01:54
@Adel-Magebinary Did your install just hang?
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:55
yep
still hanging
Brent Hoover
@zenweasel
Feb 18 2016 01:56
You might want to try cancelling out and just running reaction
Based on your screenshot it looks like the dependencies are installed
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:57
Error: SQLITE_CANTOPEN: unable to open database file
have to sudo
it picked it up catalog update again
Brent Hoover
@zenweasel
Feb 18 2016 01:57
sudo for reaction?
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:57
yep
Brent Hoover
@zenweasel
Feb 18 2016 01:57
We don’t use SQLLite for anything
what about running it like ./reaction?
Adel Abula
@Adel-Magebinary
Feb 18 2016 01:58
blob
it should be same thing. it changed now
to downloading 75 packages :)
Brent Hoover
@zenweasel
Feb 18 2016 01:59
You shouldn’t need sudo to run ./reaction
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:00
yes it looks like the permission was set by sudo / root in the first place
the required files might be owned by root
it's installing packages now
Brent Hoover
@zenweasel
Feb 18 2016 02:01
Yeah. There may be a lot of bad ramifications from running sudo reaction install
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:01
more errors
ReferenceError: Router is not defined
=> Exited with code: 8
=> Your application is crashing. Waiting for file change.
Brent Hoover
@zenweasel
Feb 18 2016 02:02
Ok, I think those are because of the changes we just merged in
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:02
shall i reset to a commit?
Jeremy Shimko
@jshimko
Feb 18 2016 02:02
You definitely don’t need sudo for Reaction or Meteor. But you might for Node/NPM (although not strictly required). Since you ran sudo reaction install, now you’re going to need it for everything (which you don’t want). All of that Meteor/Reaction stuff lives in your ~/ dir. So you can probably safely run sudo chown -R yourname:yourname ~/ to wipe out all of that root owned stuff in your home directory.
Brent Hoover
@zenweasel
Feb 18 2016 02:03
Are you more interested in looking at code or just running through the checkout, etc.?
Actually it’s probably just easier to cd to launchdock-connect and double-check that you are on the development branch
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:05
im interested to look at both
Brent Hoover
@zenweasel
Feb 18 2016 02:05
Yeah, it’s best to just get you running with the latest changes
Shouldn’t be too hard. I ran into that same issue this morning
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:06
blob
as expected
Brent Hoover
@zenweasel
Feb 18 2016 02:06
not sure what that tells me
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:06
files owned by root
in .meteor
Brent Hoover
@zenweasel
Feb 18 2016 02:07
well, the issue with ‘Router not found` and the permission issues are not related (I believe)
Jeremy Shimko
@jshimko
Feb 18 2016 02:07
chown -R yourname:yourname ~/
Brent Hoover
@zenweasel
Feb 18 2016 02:08
that command might need to be sudo if you are chowning roots files
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:08
yep
Jeremy Shimko
@jshimko
Feb 18 2016 02:08
yes, definitely
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:08
done it before i sent the screenshot.
i'll give it a one more try
Jeremy Shimko
@jshimko
Feb 18 2016 02:08
your home directory permissions are definitely broken from running sudo before install
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:09
yes. npm packages are broken
Brent Hoover
@zenweasel
Feb 18 2016 02:10
I wonder if it wouldn’t be easier to just whack the install and start over from scratch
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:10

cp bin/clone-packages.sh /usr/local/bin/

copy reaction so that you don't need ./

cp reaction /usr/local/bin/reaction && chmod + /usr/local/bin/reaction

this two commands would not work in linux
becuase of permission
Brent Hoover
@zenweasel
Feb 18 2016 02:11
Yes, @jshimko and I just discussed this yesterday
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:11
i will fix it
Jeremy Shimko
@jshimko
Feb 18 2016 02:11
oh install scripts.
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:11
few sec
Jeremy Shimko
@jshimko
Feb 18 2016 02:11
rarely faster than the steps they attempt to obscure. :)
Brent Hoover
@zenweasel
Feb 18 2016 02:12
Yeah, if you change that line to sudo cp bin/clone-packages.sh /usr/local/bin/ you should be good
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:12
yep
Jeremy Shimko
@jshimko
Feb 18 2016 02:12
yep
Brent Hoover
@zenweasel
Feb 18 2016 02:12
Yes, this is not the user experience we were hoping for
Aaron Judd
@aaronjudd
Feb 18 2016 02:18
@spencern it’s exported from core in main.js, but is client only, if your route is common that could be it
but we should add to server side...
because flow-router does recommend making routes common (for ssr)
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:20
it's working fine with user but it's Router is not defined
Aaron Judd
@aaronjudd
Feb 18 2016 02:20
@Adel-Magebinary ReferenceError: Router is not defined would be resolved with a “meteor update” the dev versions file needs to be bumped for the published fix to the reaction-stripe package. or you could do meteor remove reactioncommerce:reaction-stripe
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:21
blob
meteor update
fixed it
shall i add to install script?
reaction/bin/install
Brent Hoover
@zenweasel
Feb 18 2016 02:26
@Adel-Magebinary No. This is just a one-time issue having to do with the changes just pushed out
Normally meteor update would not be needed
Aaron Judd
@aaronjudd
Feb 18 2016 02:48
I’ve updated the versions in development, so that’s not an issue now. @spencern I’ve added server side getShopName. also - you may need a dependancy on reaction-collections to use that. (defined in that collection package so that a core dependency is not needed)
@zenweasel although adding a meteor update into the process might not be bad. @jshimko thoughts?
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:54
which object stores all of the data?
Jeremy Shimko
@jshimko
Feb 18 2016 02:54
There’s probably not any major problems with running meteor update, but adding it to the default install script opens up the possibility that people will end up with different package versions than what is committed to the repo's versions file. So there’s technically a possibility that could cause an unintended issue.
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:55
@jshimko good thinking. Just fix the version in package manager then.
Jeremy Shimko
@jshimko
Feb 18 2016 02:55
But generally, no, it’s probably not that big of a deal. Meteor is currently pretty conservative about version updates
Adel Abula
@Adel-Magebinary
Feb 18 2016 02:57
which object do you store all of the product details?
ReactionCore.Collections.Products?
Brent Hoover
@zenweasel
Feb 18 2016 03:08
Yes, that’s correct
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:37
@zenweasel how to get all products collections in console?
Brent Hoover
@zenweasel
Feb 18 2016 03:38
You can use the meteor mongo command or a GUI like robomongo.
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:39
sorry. I mean on chrome console
Brent Hoover
@zenweasel
Feb 18 2016 03:40
I can’t try it at the moment but you should be able to do something like ReactionCore.Collections.Products.find()
Actually let me see what gets published
Jeremy Shimko
@jshimko
Feb 18 2016 03:41
That returns a cursor. You can use .fetch() to get an array
ReactionCore.Collections.Products.find().fetch()
Brent Hoover
@zenweasel
Feb 18 2016 03:41
^^^ right
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:42
There's a query object too
Nice. thanks.
Jeremy Shimko
@jshimko
Feb 18 2016 03:42
ReactionCore.Collections.Products.find({ thing1: “something”, thing2: “another" }).fetch()
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:43
I was wowed when it doesn't fire any ajax request when you add things to cart
it all
Jeremy Shimko
@jshimko
Feb 18 2016 03:43
Oh AJAX… I don’t miss it even a little.
Brent Hoover
@zenweasel
Feb 18 2016 03:43
Yeah, it’s all DDP
lol, nope
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:44
so awesome :)
all changes
go to a big object right?
wait
im wrong
Brent Hoover
@zenweasel
Feb 18 2016 03:44
they are optimistically propogated in the client collection and then moved to the server collection through Pub/Sub
newsiberian
@newsiberian
Feb 18 2016 03:45
@Adel-Magebinary, you can't get all products from chrome, because you are subscribed only on 10 product max at the beginning
Jeremy Shimko
@jshimko
Feb 18 2016 03:45
right
newsiberian
@newsiberian
Feb 18 2016 03:46
So, it meteor you can't get all products from your db. it will be too big stress for server
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:46
understand. I was just trying to find where did was the request
go to
lol
Brent Hoover
@zenweasel
Feb 18 2016 03:46
You can use the websocket console to see the actual messages back and forth
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:47
which port does DDP use?
Brent Hoover
@zenweasel
Feb 18 2016 03:48
I believe it just runs on whatever port your webserver is running
Jeremy Shimko
@jshimko
Feb 18 2016 03:48
80/443
Brent Hoover
@zenweasel
Feb 18 2016 03:49
wouldn’t it be 3000 when running locally @jshimko ?
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:49
so it's still HTTP
Jeremy Shimko
@jshimko
Feb 18 2016 03:49
yes
yes
no
Brent Hoover
@zenweasel
Feb 18 2016 03:49
localhost_3000.png
Brent Hoover
@zenweasel
Feb 18 2016 03:51
^^^ or that, that’s better
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:51
my lorrrrd
this thing is so crazy
Brent Hoover
@zenweasel
Feb 18 2016 03:52
It’s a different way to deal with Client/Server web applications for sure
Adel Abula
@Adel-Magebinary
Feb 18 2016 03:54
This thing would change the industry for sure.
I sound like a redneck haha
Brent Hoover
@zenweasel
Feb 18 2016 03:55
If you like Javascript you will like Meteor IMHO
Adel Abula
@Adel-Magebinary
Feb 18 2016 04:00
DDP bases on UDP?
where can I find the code?
somewhere on meteor?
Adel Abula
@Adel-Magebinary
Feb 18 2016 04:01
yep found it thanks.
Jeremy Shimko
@jshimko
Feb 18 2016 04:02
Brent Hoover
@zenweasel
Feb 18 2016 04:02
But honestly you don’t really need to do a lot of dealing with DDP like you did Ajax
it’s not really a true Analog
The data is handled through pub/sub and Meteor handles getting it back and forth
Jeremy Shimko
@jshimko
Feb 18 2016 04:04
Right. Just read guide.meteor.com and only worry about understanding the internals when you need to for some reason. Pub/sub, collections, methods, etc. will take care of implementing DDP for you. You’ll rarely need to use the DDP methods directly. Only in advanced situations.
Adel Abula
@Adel-Magebinary
Feb 18 2016 04:12
Sure. I'm just curious about how it works if it's bind to HTTP / HTTPS.
There must be a requesting firing out sometime and somewhere.
Adel Abula
@Adel-Magebinary
Feb 18 2016 04:56
it's so cool

adel@Adel:~/Works/Clients/MageBinary/reaction(development)$ sudo tcpflow -i lo port 3000 -c
tcpflow: listening on lo
127.000.000.001.03000-127.000.000.001.45094:
write error to stdout

127.000.000.001.38104-127.000.000.001.03000: }#EgBE
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "6G
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "Q84(#"z-dG
write error to stdout

127.000.000.001.38104-127.000.000.001.03000: /9vi
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "v2,
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "8?b
write error to stdout

127.000.000.001.03000-127.000.000.001.38104:
write error to stdout

127.000.000.001.38104-127.000.000.001.03000: nU8cnU
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "Kv1
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "o
write error to stdout

127.000.000.001.38104-127.000.000.001.03000: \LF-
write error to stdout

127.000.000.001.03000-127.000.000.001.38104: "Gv1

it's even encrypted with DDP
Adel Abula
@Adel-Magebinary
Feb 18 2016 05:10
DDP = Web Socket.
I thought the author of hacked the core of http protocol. LOL.
newsiberian
@newsiberian
Feb 18 2016 05:13
@jshimko I've running launchdock-connect with meteor-1.3.beta-8 and faced with the following error:
 packages/reactioncommerce:launchdock-connect/server/templates/verify_email.html:1:
   Expected one of: <body>, <head>, <template>
could we do something with it?
Adel Abula
@Adel-Magebinary
Feb 18 2016 05:15
you clearly don't have a body tag for the whole template as I start play with reaction today.
try add body tag on the main frame of the template.
Adel Abula
@Adel-Magebinary
Feb 18 2016 05:16
i dont know but i guess
adding a template tag
for first and last line?
newsiberian
@newsiberian
Feb 18 2016 05:18
Let @jshimko decide what to do, I think
Brent Hoover
@zenweasel
Feb 18 2016 05:28
@newsiberian We haven’t been testing with Meteor 1.3 yet
It’s after midnight where Jeremy is so he might not respond right away
newsiberian
@newsiberian
Feb 18 2016 05:33
@zenweasel, i've running it with reaction about few weeks. Works great)
Brent Hoover
@zenweasel
Feb 18 2016 05:34
Great. But none of us have so we don’t know about any issues. I hear it’s supposed to be pretty backwards compatible though
newsiberian
@newsiberian
Feb 18 2016 05:35
I think we need to transfer reaction to it as ASAP because, MDG fixing bug response is fast now, but after release they can slow down, so we better test it now
Brent Hoover
@zenweasel
Feb 18 2016 05:36
Aaron has been working with it. He wrote redoc with it.
newsiberian
@newsiberian
Feb 18 2016 05:39
Yes, I know, but where is a lot of specific stuff with reaction. because we are using packages a lot. MDG need more real data from such developers as we are. Where is a lot of specific problems with import path from packages, with naming folders, etc.
newsiberian
@newsiberian
Feb 18 2016 05:45
my point is, it is not profitable to wait for release
Aaron Judd
@aaronjudd
Feb 18 2016 05:45
@newsiberian trust me. it is.
newsiberian
@newsiberian
Feb 18 2016 05:46
))
Aaron Judd
@aaronjudd
Feb 18 2016 05:47
right now, the latest beta are barely functional. and we’re trying to get to a production quality build, which means soon we’re probably going to start falling a build or two behind..
the truth is, I think we’ll be heading to npm more and more.. and yes - exports/imports etc.. but not necessarily completely based on Meteor
the goal of modularizing more and more (from my point of view) is just to make it easier to start updating individual packages where appropriate (and yes, out of Meteor when that’s suitable)
newsiberian
@newsiberian
Feb 18 2016 05:51
@aaronjudd, could you update some stuff I found with v12
we need to add api.use("aldeed:simple-schema"); dep to:
  • reaction-paymentmethod,
  • launchdock-connect
  • reaction-social
  • reaction-shipping
  • reaction-inventory
  • reaction-stripe
Aaron Judd
@aaronjudd
Feb 18 2016 05:52
no, you should add reaction-collections
collections includes schema as a dependency, and enforces security, so that’s the best one to include. I’ll put them in
newsiberian
@newsiberian
Feb 18 2016 05:53
I have it.
SS is used internally in these packages from some time (v12)
you are including core
in core you include collections
newsiberian
@newsiberian
Feb 18 2016 05:58
this is not work for me in meteor-1.3)
I know, 1.2 version is running fine
should be exporting - if Meteor 1.3 is ready and backward compatible :dart:
similar to the issues I was having in redoc
it might be that if we add api.imply in the collection and then in core, it might bubble up
newsiberian
@newsiberian
Feb 18 2016 06:03
give me a minute
It works fine with imply. So, could you add implys? :smiling_imp:
Aaron Judd
@aaronjudd
Feb 18 2016 06:26
lol, ok I’m fixing the tests now, and I’ll look at that after I finish.
hrath2015
@hrath2015
Feb 18 2016 06:27
@aaronjudd what to infer from the line from previous chat message which reads " (and yes, out of Meteor when that’s suitable)" :worried:
Aaron Judd
@aaronjudd
Feb 18 2016 06:41
just that I think some things, like an inventory engine,etc might be better suited as pure node packages - and if so, that would be fine. not leaving the meteor eco system, just that I think that’s basically how meteor is going as well.. (for the record, I’m a fan of all the things the Meteor team is proposing lately)
hrath2015
@hrath2015
Feb 18 2016 06:57
:+1:
Aaron Judd
@aaronjudd
Feb 18 2016 07:37
@newsiberian btw - we’ve always managed to update to the latest Meteor within our next release.. and I’m sure we’ll keep trying to - so happy to take those 1.3 PRs.. I’m not getting the tests finished (updating the factories package) tonight, but I’ve got your implies added in my local.
newsiberian
@newsiberian
Feb 18 2016 07:40
thanks
lijiming
@lijiming
Feb 18 2016 10:19
i'm going to do an enhancement on Chinese translation, should I add an issue or just go ahead to PR?
Brent Hoover
@zenweasel
Feb 18 2016 10:25
I don’t think you need to create an issue
newsiberian
@newsiberian
Feb 18 2016 11:15
@mikemurray, Hi, disabling apps through dashboard doesn't work for me with latest development. No logs in console.
robert
@bob360
Feb 18 2016 11:28
I just stumble into reaction ,install it and waited 1 hr to install 36 packages,realize that it frozed,back to install this time, 2 packages where installed and running up to 9 items ,it would accept more.Anyone understand why?
I dont understand why when admin logged ,to have add to cart,it does'nt make sense to me
Brent Hoover
@zenweasel
Feb 18 2016 12:24
@bob360 Sorry, I can’t understand your question
Jeremy Shimko
@jshimko
Feb 18 2016 13:37
@newsiberian thanks for the heads up on the email template issue. Apparently, <html> is no longer an acceptable top level tag for Meteor email templates. I created an issue so this gets fixed when we move to 1.3.
reactioncommerce/launchdock-connect#12
xsz
@helxsz
Feb 18 2016 13:58
Hi, I just installed the reaction on my mac, I tried to create my own theme, but I could not find .metor/packages
Jir
@fuzzyshark
Feb 18 2016 14:03
Hi, I am looking into building an e-commerce website on meteor. And reaction seems to be a great platform, is it alright if i build on it while still using all the original core components for commercial purposes ?
robert
@bob360
Feb 18 2016 15:21
reaction would not accept you to add more than 10 products, Anyone understand why?
Sara Hicks
@saralouhicks
Feb 18 2016 18:14
@fuzzyshark yes, absolutely!
Aaron Judd
@aaronjudd
Feb 18 2016 18:38
@helxsz maybe you mean reaction/packages rather than .meteor/packages ?
@bob360 probably an issue with auto loading pagination.. you certainly should be able to add more (but maybe you can’t see them?). assuming you’re running the v0.12 development version? I’ll take a look today -> it’s a brand new development version, so it’s got a few lingering issues..
Spencer Norman
@spencern
Feb 18 2016 21:13

@aaronjudd I’m on the latest version of dev ([a495ce7]) and have

  api.use('reactioncommerce:core@0.12.0');
  api.use('reactioncommerce:reaction-inventory');
  api.use('reactioncommerce:reaction-router');
  api.use('reactioncommerce:reaction-collections’);

in my package.js file. I’m still having trouble accessing the current shop name via ReactionCore.getShopName().toLowerCase()

To be clear, the function ReactionCore.getShopName() exists and runs, but it returns undefined.
I can run this same function once the app loads from the browser console and it returns the correct shop name.

I’ve tried putting my routes.js file in the client directory as well as in common and neither seem to affect
Adel Abula
@Adel-Magebinary
Feb 18 2016 21:56
hey guys
who shall I talk to about 'Reaction Development Partner Program.'
I'm quiet interested to get my company involve.
Aaron Judd
@aaronjudd
Feb 18 2016 22:20
@Adel-Magebinary talk to @saralouhicks
@spencern maybe the subscription to Shops isn’t ready yet?
Spencer Norman
@spencern
Feb 18 2016 22:21
Yeah, that’s what I’m thinking too
Just trying to figure out how to wait on that
Adel Abula
@Adel-Magebinary
Feb 18 2016 22:21
I want to get my team involved and start helping you guys and learning new tech atm.
Aaron Judd
@aaronjudd
Feb 18 2016 22:21
that should be one of the first things happening..
@Adel-Magebinary that’s great! we checked out your site earlier :thumbsup:
Adel Abula
@Adel-Magebinary
Feb 18 2016 22:22
Magento is going to die in next 2 - 5 years
Our site is not good at all
We're pushing the new one shortly.
Aaron Judd
@aaronjudd
Feb 18 2016 22:24
well, I like the name, even if magento is dying :sparkles:
Adel Abula
@Adel-Magebinary
Feb 18 2016 22:24
Total rebuilt with new strategy.
Haha. We might go with MagiBinary soon haha
nah. just kidding. gonna keep the name
blob
You'll like our new logo :)
Aaron Judd
@aaronjudd
Feb 18 2016 22:25
@spencern can you put them in either Meteor.startup or Tracker.autorun then check the sub is ReactionCore.Subscriptions.Shops.isReady()
@Adel-Magebinary I like it.. makes me think of robots, and gaming
Aaron Judd
@aaronjudd
Feb 18 2016 22:31
@spencern in general having to do a lot more manual checking if things exist, or are ready now ,because the router isn’t holding everything back
Spencer Norman
@spencern
Feb 18 2016 22:31
Yeah, we’re learning that a bit moving some of our subs out of router into templates
Aaron Judd
@aaronjudd
Feb 18 2016 22:31
that’s part of the reason for the registry routing...
Spencer Norman
@spencern
Feb 18 2016 22:31
yeah, makes sense
Aaron Judd
@aaronjudd
Feb 18 2016 22:34
you might also want to look at how I loaded the router itself -> there’s some trickiness to ensure the route loading occurs last
Aaron Judd
@aaronjudd
Feb 18 2016 22:55
a good recent talk to for more details on how the pub/sub/oplog works and optimization: https://www.youtube.com/watch?v=1M0lEuhxAGk
Spencer Norman
@spencern
Feb 18 2016 22:56
Moving routes into a tracker.autorun and waiting on the Shops subscription to be ready solved it
Aaron Judd
@aaronjudd
Feb 18 2016 22:56
:thumbsup:
Spencer Norman
@spencern
Feb 18 2016 22:56
I’ll check out that talk too, looks good
Aaron Judd
@aaronjudd
Feb 18 2016 22:57
it’s long, but worth it
Spencer Norman
@spencern
Feb 18 2016 23:16
Welp, scratch that about my issue being solved. I can wait on the Shops subscription and log proof that the subscription is ready, but ReactionCore.getShopName() still returns undefined for some reason.
Screen Shot 2016-02-18 at 4.18.57 PM.png
Spencer Norman
@spencern
Feb 18 2016 23:56
That screenshot may not be very helpful, after digging a bit more, it’s apparent that the Shops collection becomes ready far before ReactionCore.getShopName() is populated
With a debugger statement in my package, I can stop execution and query ReactionCore.Collections.Shops and get back a shop but still have an undefined shopName