These are chat archives for reactioncommerce/reaction

26th
Feb 2016
Brent Hoover
@zenweasel
Feb 26 2016 05:09
Hey everyone. @newsiberian has created, and @aaronjudd and I have contributed to create a test plan/spec for testing the functionality of the product admin. It’s first use will be verifing that this PR reactioncommerce/reaction#741 does not cause any regression, but it can be used in the future for QA/testing. I have created this issues reactioncommerce/reaction#826 for feedback and comments. I would appreciate anybody who can review or test the plan and see if any functionality is missing.
hrath2015
@hrath2015
Feb 26 2016 05:26
@zenweasel I did some test with V11 when it was submitted. It looked OK in initial test of workflows. I will test again with v12 and report back. Any special instruction to follow for v12, please share.
Brent Hoover
@zenweasel
Feb 26 2016 05:28
Well, specifically testing the current v12 against the flattened product schema in #741. It may have ramifications that are not immediately apparent, which is why we want to drill down into more detail.
hrath2015
@hrath2015
Feb 26 2016 05:28
sure echo that.
Brent Hoover
@zenweasel
Feb 26 2016 05:30
More than likely once we know which part of the functionlity it makes the most sense to test we will start create automated tests against this.
Not mentioned in the test plan would be any performance testing with people who have a lot of products
hrath2015
@hrath2015
Feb 26 2016 05:33
:thumbsup: good point.
Brent Hoover
@zenweasel
Feb 26 2016 05:34
Just thought of it, I guess that’s a note to myself to add it
Kavish Patel
@thekavish
Feb 26 2016 10:10
@aaronjudd, I am building this project on a linux system, still am getting this compiling error.
Jesus Millan
@JsusMillan
Feb 26 2016 16:17
Hello
Mike Murray
@mikemurray
Feb 26 2016 16:18
Hello @JsusMillan
Jesus Millan
@JsusMillan
Feb 26 2016 16:19
@mikemurray o/
¿some package so that when an article is published it will automatically upload to social networks?
Mike Murray
@mikemurray
Feb 26 2016 16:22
@JsusMillan we currenly don't have any auto publish features to social networks. This feature may be added in the future.
Jesus Millan
@JsusMillan
Feb 26 2016 16:25
@mikemurray ah ok, i need this funtions, I can works in this packet
from comunity
Spencer Norman
@spencern
Feb 26 2016 19:25
@aaronjudd - got back to trying to debug the layout/workflow issue we were chatting about earlier.
Screen Shot 2016-02-26 at 12.25.35 PM.png
Aaron Judd
@aaronjudd
Feb 26 2016 19:29
@spencern I think you need a combination of layout and workflow, not just workflow, so if layout=undefined here, you will be trying to use a layout that matched “coreLayout” with workflow “coreRentalWorkflow”. is this what you’re expecting?
Spencer Norman
@spencern
Feb 26 2016 19:30
I’ve checked all of my sources, and I can’t find any locations where I’m not defining both a layout and a workflow
but entirely possible I’m still not fully understanding how this is supposed to work
e.g. in the registry I have a route (provides dashboard) set up like this
{
    // Provides Dashboard Card
    // Route from card renders template specified in the dashboard when clicking
    // the card or the arrow on the card
    // Links to main rentalProducts list
    route: '/dashboard/rentalProducts',
    layout: 'coreRentalLayout',
    provides: 'dashboard',
    name: 'rentalProducts',
    label: 'Rental Products',
    description: 'Enables rental products for your shop',
    icon: 'fa fa-calendar',
    container: 'getoutfitted',
    template: 'dashboardRentalProducts',
    workflow: 'coreRentalWorkflow',
    priority: 1
  }
Aaron Judd
@aaronjudd
Feb 26 2016 19:30
add on line 94 there options.layout = layout ?
in the // check route permissions section
because we are actually overwriting whatever you pass if you don’t have permissions
Spencer Norman
@spencern
Feb 26 2016 19:31
Screen Shot 2016-02-26 at 12.31.28 PM.png
Aaron Judd
@aaronjudd
Feb 26 2016 19:31
(which also could be the issue)
Spencer Norman
@spencern
Feb 26 2016 19:31
already done
Also in my layout/workflow definition in the register.js file
  layout: [{
    workflow: 'coreRentalWorkflow',
    layout: 'coreRentalLayout',
    theme: 'default',
    enabled: true,
    structure: {
      template: 'rentalShopSettings',
      layoutHeader: 'layoutHeader',
      layoutFooter: '',
      notFound: 'notFound',
      dashboardHeader: 'dashboardHeader',
      dashboardControls: 'accountsDashboardControls',
      dashboardHeaderControls: '',
      adminControlsFooter: 'adminControlsFooter'
    }
  }]
layout is still undefined through here?
Spencer Norman
@spencern
Feb 26 2016 19:35
That’s how I ended up here, I was initally putting the debugger here: https://github.com/reactioncommerce/reaction/blob/development/packages/reaction-router/common/layout.js#L26
and it was always undefined
so it would get initialized to coreLayout
Aaron Judd
@aaronjudd
Feb 26 2016 19:35
and everything else passes.. ?
lol what magic did I do.. where..
Spencer Norman
@spencern
Feb 26 2016 19:35
yeah, it doesn’t seem that layout ever ends up in the packages database collection though
that was where I was looking next
Aaron Judd
@aaronjudd
Feb 26 2016 19:36
aha!
Spencer Norman
@spencern
Feb 26 2016 19:36
but couldn’t identify where that was
Aaron Judd
@aaronjudd
Feb 26 2016 19:36
look at the schema
Spencer Norman
@spencern
Feb 26 2016 19:37
ah, - the registry schema?
Aaron Judd
@aaronjudd
Feb 26 2016 19:37
but I just checked the Packages collection I see the layout there. I think there is a Layout schema now
Aaron Judd
@aaronjudd
Feb 26 2016 19:39
this is a bit of annoyance I was having while testing.. during import, if something doesn’t match the schema, it just goes around it, with no errors.
Spencer Norman
@spencern
Feb 26 2016 19:39
Would be nice to have warnings at least for that
Layouts does seem to have the schema for ‘layout’, but for some reason it’s not loading the defined layout here by default
Aaron Judd
@aaronjudd
Feb 26 2016 19:41
yeah, I’ll have to dig into ReactionImport for that..
Spencer Norman
@spencern
Feb 26 2016 19:41
registry on the other hand doesn’t have layouts in the schema
but feels like we probably shouldn’t be defining it there
but leaving it up to the workflow
Aaron Judd
@aaronjudd
Feb 26 2016 19:41
but the core packages with layout are getting packages.layout entries
Spencer Norman
@spencern
Feb 26 2016 19:41
interesting
Aaron Judd
@aaronjudd
Feb 26 2016 19:44
and of course, you need that matching layout in Shops.layout -> the concept here was that package registry contains the layout fixtures.. but each shop can customize from the defaults.. however.. I think maybe this is overly complicated and we could pull this and leave it all in the registry. Thought the separation would be good, because if you break something it would be nice to reset to the package default (I’ll think more about this, I have an issue to auto insert the layout into shops)
Spencer Norman
@spencern
Feb 26 2016 19:45
made everything work
I can send a PR if helpful, but I’m still not certain if this is how it was intended to work or just a workaround
Aaron Judd
@aaronjudd
Feb 26 2016 19:48
a pr would be good, this was the intended. although not sure if all of this was necessary, or just one magic piece in the schema..
Spencer Norman
@spencern
Feb 26 2016 19:48
:+1:
Aaron Judd
@aaronjudd
Feb 26 2016 19:49
one thing I had been thinking on this, was that you could pass “options” and define the object elsewhere rather than bloating the registry (for more complex ones like this).. wired it up, but didn’t test it yet, wasn’t sure if that was a worthwhile feature or not
Spencer Norman
@spencern
Feb 26 2016 19:51
I think it would be useful. I think the main point of confusion that stumped me was that it didn’t seem to matter what layout I defined in the layout: [] part of the registry, it would always default to coreLayout in my case, which is what sent me looking for other ways to define the layout for a route.
Aaron Judd
@aaronjudd
Feb 26 2016 19:52
yeah, I can see that, thanks for the quick debug on this
Spencer Norman
@spencern
Feb 26 2016 19:52
thank you for helping me get it figured out
Aaron Judd
@aaronjudd
Feb 26 2016 19:53
:thumbsup: pr it, I’ll merge
Owen Hoskins
@owenhoskins
Feb 26 2016 20:30
Good afternoon all.
I am catching up with the developments on Inventory package. Got a few questions. Especially related to the observation that the Product Variant schemas "inventoryQuantity" doesn't seem to get updated after completing the order.
20:21:16.655Z INFO core: after cart update, call inventory/addReserve 20:21:16.664Z INFO inventory: totalRequiredQty 1 20:21:16.665Z INFO inventory: availableInventoryQty 0 20:21:16.665Z INFO inventory: no inventory found, create 1 backorder 20:21:16.690Z INFO inventory: finished creating 1 new reserved reservations
Owen Hoskins
@owenhoskins
Feb 26 2016 20:36
Looks like a backorder is being created -- although my product variant has a inventoryQuantity of 1. Is the backorder logic WIP? Curious where we are on this atm?