These are chat archives for reactioncommerce/reaction

7th
Apr 2016
Brent Hoover
@zenweasel
Apr 07 2016 00:00
Yes, except for launchdock those are all payment packages
xiaoc li
@brianxcli
Apr 07 2016 00:00
Oh, I know, thanks.
Brent Hoover
@zenweasel
Apr 07 2016 00:01
At one point almost all packages were external but it got to be too much and they were all moved into the main repo
xiaoc li
@brianxcli
Apr 07 2016 00:42
I got problem of adding external packages into version control, it doesn't recognize new packages, all have to be done, modifying ignore file is not working
blob
Anyone had this issue?
Brent Hoover
@zenweasel
Apr 07 2016 05:35
I think we have all run into this
You need to add a unignore line for your package like the ones in the packages directory
Can’t tell from your screenshot if that’s what you have done already
xiaoc li
@brianxcli
Apr 07 2016 05:39
Yes I did so. But only the first packaged root folders are added into version control, not the sub folders
package root folders
Brent Hoover
@zenweasel
Apr 07 2016 05:42
Yeah, I think that affects the way all the packages work. If you add a file to a subfolder in something like reaction-core it also doesn’t see it
I think we end up having to force add those files
not sure if this got fixed in the latest git that was released
you can also explicity add unignore lines for the folders, but that’s a messy solution
xiaoc li
@brianxcli
Apr 07 2016 05:47
But why other packages don't have this problem
Brent Hoover
@zenweasel
Apr 07 2016 05:47
all packages have this problem. I just tested it now
files in the root of the package dir will be visible, but files in subfolders will not show up with a git status
xiaoc li
@brianxcli
Apr 07 2016 07:28
Solved. Download the external packages somewhere else, delete .git folders; delete packages/gitignore or replace it with the root .gitignore file. Then just copy those external packages into the project
The external packages also has version control tracking files, they conflict with the current project
Brent Hoover
@zenweasel
Apr 07 2016 07:30
Yeah, we intentionally kept the .git folders to keep the history for each package
but good to know that’s what’s causing the issue
xiaoc li
@brianxcli
Apr 07 2016 07:34
the ignore file doesn't work for package sub folders, "!package/*" cannot let the sub folders go