Just a heads-up that Meteor 1.3 support has dropped into
development.
Make sure you do a
./reaction pull as you need to get changes into external packages if you have them
any breaking changes?
Not that I know of. The only thing we have seen is that tests are not running in CI
yeah, i’ve had trouble with CI for the last few releases
but tests are running locally?
Yep
great! Nice work on getting 1.3 compatability out so fast!
All credit goes to @aaronjudd (as usual)
He’s a machine
Indeed
it looks like the driver packages for jasmine is out as well
so I am trying to get the current tests running with the meteor native test runner
fantastic, i’ll follow that closesly
do you have a branch?
Nope. Nothing work looking at yet. Trying to get the runner to pick up the tests. I just get
Server tests ran successfully undefined
:unamused:
Running
meteor test --full-app --driver-package=sanjo:jasmine
@spencern thanks, lol. more like thanks @mikemurray for roadblock clearing. in any case, I'd call this the compatibility phase.. we can ease into modules from here... @zenweasel did you see this: https://github.com/xolvio/meteor-jasmine/commit/9ab1ecb650e03997ed7edc81ff2fcbfb3f74f012#diff-04c6e90faac2675aa89e2176d2eec7d8L14
Yep. Still not working for me.
What I see are
“Running tests…” and then Server tests ran successfully undefined
Now I am also seeing
ClientServerReporter.coffee:21 ClientServerReporter.constructor: Missing reporter to run tests. Use MochaRunner.setReporter(reporter) to set one.
so you know, that’s confusing
@spencern If you upgrade, also recommend removing the
.meteor directory. There was a ton of stuff in there that was no longer needed.
The time to redownload is worth it
woah
sanjo:jasmine
velocity:console-reporter
velocity:html-reporter
@zenweasel you have all those..
Yep
velocity:console-reporter@0.2.1
velocity:html-reporter@0.10.0
sanjo:jasmine@1.0.0
:thumbsup: on .meteor, I
rm -rf’ed my whole meteor install, and reinstalled.. 17+GB, took about 30 minutes to delete on the SSD
rumroof’d it
lol - was wondering how to say that
now you know
somehow I do feel smarter now.
I get this message in the server console:
MochaRunner.runServerTests: Starting server side tests with run id sAXpujiEPtAB7xAcL
MochaRunner.runServerTests: failures: 0
I have a dummy test with the proper naming just for sanity sake
haven’t got that far yet, nothing is breaking but I have no test results other than that console error. looking at a npm peer dependency issue
react and react-dom for reaction-ui?
yup
Yeah, saw that too
Apparently anything in a
tests directory is ignored. Cuz that makes sense
well I was assuming we’d just have to move and rename all the files, but, huh?
Sanjo said "Also note that tests that are in a /tests/ folder will not get picked up.” but I had assumed he meant “won’t get picked up unless you rename them"
Hi, any ideas why I see this:
Uncaught Error: Cannot find module 'util'
reactioncommerce_reaction-collections.js:31 Uncaught TypeError: Cannot read property 'bunyan' of undefined
reactioncommerce_reaction-email-templates.js:10 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined
reactioncommerce_core.js:35 Uncaught TypeError: Cannot read property 'bunyan' of undefined
reactioncommerce_reaction-catalog.js:24 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
tmeasday_check-npm-versions.js:65 Uncaught Error: Cannot find module 'react/package.json'
reactioncommerce_reaction-ui.js:29 Uncaught TypeError: Cannot read property 'ReactionCore' of undefined
reactioncommerce_reaction-layout.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-accounts.js:33 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-router.js:22 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined
meteor.js:913 Error logging in with token: Error: You've been logged out by the server. Please log in again. [403]
reactioncommerce_reaction-i18n.js:29 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined
reactioncommerce_reaction-product-variant.js:31 Uncaught TypeError: Cannot read property 'ReactionRouter' of undefined
reactioncommerce_reaction-dashboard.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-orders.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-analytics.js:28 Uncaught TypeError: Cannot read property 'ReactionRouter' of undefined
reactioncommerce_reaction-inventory.js:27 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-checkout.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-shipping.js:30 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-social.js:29 Uncaught TypeError: Cannot read property 'currentProduct' of undefined
reactioncommerce_reaction-ui-navbar.js:30 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-ui-tagnav.js:31 Uncaught TypeError: Cannot read property 'TextField' of undefined
reactioncommerce_reaction-paymentmethod.js:31 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-stripe.js:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-auth-net.js:31 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-braintree.js:31 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
reactioncommerce_reaction-sample-data.js:8 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
global-imports.js:8 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined
app.js:1 Uncaught ReferenceError: meteorInstall is not defined
meteorhacks_fast-render.js:232 Uncaught Error: seems like cookie tossing is happening. visit here: http://git.io/q4IRHQ
@newsiberian did you do
npm install (or use reaction pull I added it there as well) ?
util is installed by meteor-node-stubs from the app package.json
after
npm install I so another error. Maybe this is because I' working in fork and something was merged with errors...check-npm-versions.js:21 Uncaught Error: Cannot find module 'bunyan-format/package.json'require @ modules-runtime.js?hash=939c79d…:95compatibleVersionIsInstalled @ check-npm-versions.js:10(anonymous function) @ check-npm-versions.js:29_.each._.forEach @ underscore.js?hash=8de51f9…:147checkNpmVersions @ check-npm-versions.js:28meteorInstall.node_modules.meteor.reactioncommerce:reaction-logger.client.main.js @ main.js:3fileEvaluate @ modules-runtime.js?hash=939c79d…:158require @ modules-runtime.js?hash=939c79d…:92(anonymous function) @ reactioncommerce_reaction-logger.js?hash=7010811…:2618(anonymous function) @ reactioncommerce_reaction-logger.js?hash=7010811…:2629
reactioncommerce_reaction-collections.js?hash=12901a7…:31Uncaught TypeError: Cannot read property 'bunyan' of undefined(anonymous function) @ reactioncommerce_reaction-collections.js?hash=12901a7…:31(anonymous function) @ reactioncommerce_reaction-collections.js?hash=12901a7…:549
reactioncommerce_reaction-email-templates.js?hash=cd84da2…:10 Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined(anonymous function) @ reactioncommerce_reaction-email-templates.js?hash=cd84da2…:10(anonymous function) @ reactioncommerce_reaction-email-templates.js?hash=cd84da2…:47
reactioncommerce_core.js?hash=2672883…:35Uncaught TypeError: Cannot read property 'bunyan' of undefined(anonymous function) @ reactioncommerce_core.js?hash=2672883…:35(anonymous function) @ reactioncommerce_core.js?hash=2672883…:1820
reactioncommerce_reaction-catalog.js?hash=6527cf7…:24 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-catalog.js?hash=6527cf7…:24(anonymous function) @ reactioncommerce_reaction-catalog.js?hash=6527cf7…:349
reactioncommerce_reaction-ui.js?hash=35aeb72…:29Uncaught TypeError: Cannot read property 'ReactionCore' of undefined(anonymous function) @ reactioncommerce_reaction-ui.js?hash=35aeb72…:29(anonymous function) @ reactioncommerce_reaction-ui.js?hash=35aeb72…:43353
reactioncommerce_reaction-layout.js?hash=063415e…:32 Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-layout.js?hash=063415e…:32(anonymous function) @ reactioncommerce_reaction-layout.js?hash=063415e…:1398
reactioncommerce_reaction-accounts.js?hash=d74aa71…:33Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-accounts.js?hash=d74aa71…:33(anonymous function) @ reactioncommerce_reaction-accounts.js?hash=d74aa71…:4371
reactioncommerce_reaction-router.js?hash=65ec805…:22Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined(anonymous function) @ reactioncommerce_reaction-router.js?hash=65ec805…:22(anonymous function) @ reactioncommerce_reaction-router.js?hash=65ec805…:589
reactioncommerce_reaction-i18n.js?hash=8ba3307…:29Uncaught TypeError: Cannot read property 'ReactionSubscriptions' of undefined(anonymous function) @ reactioncommerce_reaction-i18n.js?hash=8ba3307…:29(anonymous function) @ reactioncommerce_reaction-i18n.js?hash=8ba3307…:3865
reactioncommerce_reaction-product-variant.js?hash=83139bc…:31Uncaught TypeError: Cannot read property 'ReactionRouter' of undefined(anonymous function) @ reactioncommerce_reaction-product-variant.js?hash=83139bc…:31(anonymous function) @ reactioncommerce_reaction-product-variant.js?hash=83139bc…:34286
reactioncommerce_reaction-dashboard.js?hash=17f984c…:32Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-dashboard.js?hash=17f984c…:32(anonymous function) @ reactioncommerce_reaction-dashboard.js?hash=17f984c…:1598
reactioncommerce_reaction-orders.js?hash=d19fe3d…:32Uncaught TypeError: Cannot read property 'ReactionImport' of undefined(anonymous function) @ reactioncommerce_reaction-orders.js?hash=d19fe3d…:32(anonymous function) @ reactioncommif you have a forked version, the logging directory renamed to packages/reaction-logger instead of packages/reaction-logging. could be a mixup there? if not though, this looks like a build error, maybe run (from project root)
find . -name bower -exec rm -rf {} \;
find . -name node_modules -exec rm -rf {} \;to clear out any existing installed node_modules, and rerun - (one of several tricks I have had to do to reset)
Thanks, I already remove old
reaction-logging folder...
also, I've just download clean
reaction and it shows me:sohaam@debian:~/devel/reaction-src/reaction$ meteor
[[[[[ ~/devel/reaction-src/reaction ]]]]]
=> Started proxy.
=> Errors prevented startup:
While selecting package versions:
error: Potentially incompatible change required to top-level dependency: reactioncommerce:launchdock-connect 0.2.1, was 0.2.2.
Constraints on package "reactioncommerce:launchdock-connect":
Potentially incompatible change required to top-level dependency: reactioncommerce:reaction-paypal 1.3.0, was 1.4.0.
Constraints on package "reactioncommerce:reaction-paypal":
To allow potentially incompatible changes to top-level dependencies, you must pass --allow-incompatible-update on the command line.
=> Your application has errors. Waiting for file change.
=> Started MongoDB.
Hmmm, @aaronjudd do I need to publish those packages?
reaction pull will bring those down into the fresh install, otherwise it’s hitting the older packages in atmosphere
@zenweasel we can, should be safe because they’re requiring Meteor 1.3
ok
Shouldn’t break anything backwards compatability-wise
Ah, ok
although we probably should have bumped connect to 0.3.0. sigh but nothing changed but the packages.js
I published those packages, will double-check that a fresh clone still works
:+1:
I removed the
practicalmeteor packages and now I am gettingI20160412-14:03:19.321(8)? jasmine-server: 1 tests passed (1ms)
I20160412-14:03:19.709(8)? jasmine-client: 1 tests passed (3ms)
nice!
only 150+ more to go, lol.
lol, yep
@newsiberian did you get it running?
published
launchdock-connect and now a fresh clone will work OOTB
@aaronjudd, sorry, I was afk. I'll try again little bit later
With clean
reaction, second time rmed .meteor and reaction pull && bin/reset && npm install && meteor still so the same list of errors. Pretty strange)
Do you mean the dependency version errors?
I mean this errors
Have you checked whether you have bunyan package?
Any explanation of what is workflow in routing?
all starting to work after I commit some lines:
Npm.depends({
// "bunyan": "1.8.0",
// "bunyan-format": "0.2.1",
// "bunyan-loggly": "0.0.5"
});I'm looking into that reaction-logger and it scares me. Why so much overhead with deps? why we getting the same packages from meteor internal system Npm.depends then, via package.json, and what happens inside client/main.js?
And why we are fetching this
bunyan packages again from the top-level?
I ran from a clean install and did not encounter any errors, even after deleting my global
.meteor directory
when you say you did a
npm install do you mean meteor npm install?
I tried both. maybe the problem is in npm version. I have globally installed: 2.15.0
Hmmm, with
meteor npm install I don’t think it should matter since it’s using it’s own version of npm right?
@newsiberian you can build a package of reaction, and see what is included in it. The inclusion of npm packages is only for development purpose and will not be packaged during building.
It will get bunyan from runtime environment, not bunyan js code from the package.
@brianxcli, thanks
@newsiberian take a look at the bundle structure, you can understand how meteor packages will be dealt with.
What is "bundle structure"?
bundle is the folder name when you extract the build package
@aaronjudd This is how it works with JS:
const media = ReactionCore.Collections.Media.findOne({
"metadata.productId": product._id,
"metadata.priority": 0,
"metadata.toGrid": 1
}, { sort: { uploadedAt: 1 } });
return media.url({store: "thumbnail"})
@ScyDev nice, we should add to docs, that’s useful.
@newsiberian when we were talking removing the meteor dir, I did mean
/.meteor (install dir), and I did have some weird build errors until I started from scratch.. have no real logical explanation though..
and yes, you no longer need to have npm installed, meteor now includes as
meteor npm
@aaronjudd, good morning, I don't understand why we have two ways to get npm's in one package. What is the point to use
Npm.depents() and package.json together to fetch similar packages?
in the package, package.json does not yet do anything.. so you still need Npm.depends. it’s just a transition period. however in the app, package.json does work for now. if we moved to modules (the next step) then we could use package.json there as well, but not right now for atmosphere/meteor packages.
re: bunyan, maybe that’s wrong.. not 100% but the way it seems to be working is that if you want a global, it needs to be in the app package.json
and the “checkNpmVersions” is added simply to tell the end user that they have to manually run
npm install after the atmosphere package has been installed.
do I agree and like it? no…… but 1.3 is fast moving transition, so maybe 1.3.2 fixes some of this crap
I may have added package.json to a few of the packages themselves, but they don’t do anything at this moment, only the package.js
because Meteor takes the package.js and creates a package.json during the build
ok, one more small question. How do you decide to use
require or import. I look at this file and it is not clear thats going on in line 10. As I understand require is used inside file in some statements like if. and it not always mean we will load this file. Import are always load file.
I think there, you could do
const bunyan = require(“bunyan”) however… I couldn’t because you can only have one require per package… so I required on server, and imported on client.
Also, we have
react dep at lop-level. Is that necessary? Why not to load it from package? I'm asking because I'm still on 0.14.8
you can pin to 0.14.8 there and you should be ok, I was testing with that right up until 15.0 , I think we need react to be a global, and that’s why it’s there, and I think it’s mentioned in a checkNpmVersion in reaction-ui as well
thanks. Any idea how I could load images from
package-name/public? for now I only able to load from /public
you need to reference the package assets path from the built structure, starting I think with
packages/ I think. I can’t remember exactly the path structure but you’ll see the assets in reaction/.meteor/local/build/programs/web.browser/packages
thanks. I've remember this
yeah, similar but if you use
api.addAssets, there should just be an “assets” dir
@aaronjudd Yes, thanks. The path actually looks like this "/packages/scydev_snaxter-template/client/templates/snaxterLayout/assets/images/pasta-527286-1920-1920x1212-47.jpg".
that’s it.. from an earlier thread here in gitter
:+1:
re import/vs require and bunyan - I may have that backwards.. perhaps the import should have been on the server and the require on the client. I think the meteor recommendation is for
import, and require on clients, I’ll test more.. (but it does work now)
also 1.3.2 should bring CSS loads from the packages.. we have a couple issues pending that (we worked around, but you’ll probably see the leftovers)
I'm using
imports on the server and on the client and all works fine.
In fact I'm not using require at all. Only in a few copy/pasted places
:thumbsup: I’ll take another look - it was a LOT of trial and error. ;-)
I'm not sure, but maybe this will give you some ideas... Also, did you test current changes on linux?
I didn’t specifically test on linux, but our tests run on linux. we can try a specific version if you’re still having issues. re: comments-core, :thumbsup: yes that’s the structure we’ll gradually move towards
Is there a way to require an email address for a guest checkout right now?
not just disabled guest checkout? then it’s required to create an account, or you could add your step to get the email form in the login before creating the order (but not a simple checkbox setting somewhere, although it’d be easy enough to do)
so if you disabled guest checkout, modify “create an account” to allow a third option of creating an account without a password…
Essentially we’d like for customers to be able to checkout without an account, but if they checkout without an account we still need an email address
I guess that’s me misunderstanding how accounts work
because it seems like every session is an account of some kind
and once an email address is added, then it’s associated with an account?
yes, every session is an account.. and yes…. currently the email can be added after the order is completed, you’d just want to require that step at an earlier stage
:+1:
the email that is used after the order just updates the order though, not sure if it ties to session account.. (but you can do that super easy, passwords aren’t required to create accounts).
you might say why not do that when updating email order?… well then it’s not an
anonymous account ;-)
right ;)
if we do that, is there a straightforward way to allow that customer to create a password/verify their email address in the future?
the password reset / forgot password flow...
that works..
perfect
I'm trying to use the package ramusus:reaction-flat-pages https://github.com/ramusus/reaction-flat-pages/ does anyone is using it? I follow the instructions to add it but I'm getting this error when I try to create a page
Failed to render layout coreLayout corePageWorkflow
Does anyone knows how to solve it?
Failed to render layout coreLayout corePageWorkflow
Does anyone knows how to solve it?
@ramusus
Is this issue known or already fixed?
Tags with attributes like data-i18n="productDetail.makeInactive"are not translated to the correct language if they are reactively re-rendered. Instead the default text is used.
Using the i18n helper works find though: {{i18n 'productDetail.makeInactive' 'Deactivate'}}
(I'm working on an old 0.12 fork)
@ScyDev I think should have been fixed, but I’ll look again because we’re seeing some new oddities with 0.13
@erendira @ramusus I’ve not looked that the package lately, but sounds like it needs a new layout structure added to
Shops.layout (see other’s existing as an example). That should be loaded by the package on start though, if the structure is declared in the register.js
it’s on my short list to look at this with for 0.13 compatibility though, probably later this week
Ok so I've gotten an install of reaction up before but I think in my server setup I missed or messed up something.... the site is blank but it did pull up the icon file on the tab. This is a new install and idk where I went wrong. Any help?
I have some suspicion it could be fixed with chmod because rn most files need admin rights to mess with but I am unsure
Normally you shouldn’t need admin rights on anything, and you don’t want to be running the site as an admin as it’s a security risk
Can you give me a few more details like what OS you are trying to install to and what you have done so far?
it is a debian VPS
and I installed nodejs from source and mongo and of course meteor finally Reaction
when attempting to run ./reaction it kept giving me errors about file creation so I tried with 'sudo' and it seamed to start working but it resulted in the blank page
You don’t want to be running it with sudo. The app has access to the file system so you don’t want it to have root level access
You need to back up and fix any permissions issues you have. Once you run it with sudo, you sort of need to back up and start over.
Error: EACCES, mkdir '/home/{me}/reaction/.meteor/local'
that is the error that I was trying to subvert unwittingly
Yeah, that’s really weird. You should obviously have write access to your home directory
did you run any of the other commands with sudo?
so would a chmod help? or would there be something recursive necessary?
I installed everything apt-get etc with sudo
yeah, that should be fine as it’s not installing anything to your home directory
and curl
did you do the meteor install with sudo?
yeah I believe so
yeah, there should be no reason to do that
I just checked and I don't think so now after checking it out
basically nothing besides the
apt-get should be run with sudo. Once you run one thing with sudo you sort of stuck with running everything with sudo and that’s a dead end
anyway to reverse it?
You should just be able to run it again without it (talking about the curl) and go from there
ok I think it is working will the reaction commerce have like a brand new install?
pardon?
I would delete the reaction directory and reclone
I already ran curl a second time for meteor and I am now attempting to run reaction but it is looking like a fresh install
did you follow the instructions from here: https://github.com/reactioncommerce/reaction
you are better off just deleting and recloning
how would I go about deleting it all?
just
rm -rf that directory