These are chat archives for reactioncommerce/reaction

20th
Apr 2016
xiaoc li
@brianxcli
Apr 20 2016 00:12
Dashboard issue, the title of admin control panel concatenates all the option titles.
This message was deleted
all the options titles that have just been browsed.
Brent Hoover
@zenweasel
Apr 20 2016 00:44
@brianxcli Do you have a screenshot you can show me?
@brianxcli Unrelated, but didn't you come up with a solution to the issue of having to force add files in git in the packages dir?
xiaoc li
@brianxcli
Apr 20 2016 03:43
屏幕快照 2016-04-20 下午3.42.35.png
@zenweasel
@zenweasel Yes, I have a solution:
1) delete .gitignore file under packages, it will ignore all newly added files;
2) pulling those packages as usual;
3) copy those downloaded packages to somewhere else, and delete .git folder;
4) delete the project, and clone the project again, and copy those packages into the project
xiaoc li
@brianxcli
Apr 20 2016 03:54
For a custom package, deleting .gitignore just works.
For packages like payment-method, launchdock-connect, auth-net, must follow the four steps above.
Brent Hoover
@zenweasel
Apr 20 2016 03:57
Thanks, I will give that a try
Brent Hoover
@zenweasel
Apr 20 2016 05:34
@brianxcli Trying to replicate your issue with the dashboard and I am seeing something a little different. I only see the titles concatenated when moving from any package to Example Payment Provider, but not something like Localization to Shop Settings. Do you see that when moving from any module/card to any other one? Are you on the current development?
xiaoc li
@brianxcli
Apr 20 2016 05:48
@zenweasel I am working on development branch updated last week. I don't know if it is still the current one.
Brent Hoover
@zenweasel
Apr 20 2016 05:49
Close enough. No significant changes I believe
xiaoc li
@brianxcli
Apr 20 2016 05:49
try in this order: Braintree -> Example payment provider -> i18n -> connect
Brent Hoover
@zenweasel
Apr 20 2016 05:50
I see it from anything to Example Payment Provider, or anything to Connect
Brent Hoover
@zenweasel
Apr 20 2016 05:58
Issue created: reactioncommerce/reaction#978
xiaoc li
@brianxcli
Apr 20 2016 06:00
thanks
Brent Hoover
@zenweasel
Apr 20 2016 06:02
Everybody is pretty heads-down on 1.3-related stuff, but we should be cleaning up most of these minor bugs before v0.13
xiaoc li
@brianxcli
Apr 20 2016 07:01
This message was deleted
What's the plan?
Brent Hoover
@zenweasel
Apr 20 2016 07:01
pardon?
xiaoc li
@brianxcli
Apr 20 2016 07:01
What's the plan for v0.13?
Brent Hoover
@zenweasel
Apr 20 2016 07:02
It’s a bug-fix release + full upgrade to 1.3
No new features except the upgrade to 1.3, but hopefully closing all significant bugs
xiaoc li
@brianxcli
Apr 20 2016 07:03
Yeah
Brent Hoover
@zenweasel
Apr 20 2016 07:04
Does that answer your question?
xiaoc li
@brianxcli
Apr 20 2016 07:05
Yes, it does. Thanks.
Maged Eladawy
@meladawy
Apr 20 2016 14:46
I have a questions plz
there is not slug field for shop collection
what if i want to display the shop name in a custom route
like shop/:slug
any suggestion ?
icarus
@icarusbro
Apr 20 2016 15:11

Somebody have problems to update meteor? When i run the command "meteor update", show me an:

error While building package reactioncommerce:core:
error: Bower dependencies list must be a dictionary in lib/bower/classie/bower.json

Spencer Norman
@spencern
Apr 20 2016 17:02
@aaronjudd just noticed that inventoryAdjust is commented out. (apparently has been for a while) Is it removed for another method or just for testing? https://github.com/reactioncommerce/reaction/blob/development/packages/reaction-core/server/methods/cart.js#L600
Aaron Judd
@aaronjudd
Apr 20 2016 17:03
the adjust is being done with hooks, so not needed there
Spencer Norman
@spencern
Apr 20 2016 17:04
is it still done with the inventoryAdjust method? We were previously hooking into the inventoryAdjust method, so will need to update our hooks
Aaron Judd
@aaronjudd
Apr 20 2016 17:04
@icarusbro meteor update could produces some issues right now, as meteor is pushing out 1.3.x releases… and the atmosphere repo’s are already a bit of a mess as well
@spencern we should just add a regular reaction hook there then…
or you can look at how the hooks are in the inventory package and do like them...
(recommended)
Spencer Norman
@spencern
Apr 20 2016 17:05
ok, it’s all contained in the inventory pkg?
icarus
@icarusbro
Apr 20 2016 17:24
@aaronjudd Thank aaron we walk ;)
Mateo
@matzero
Apr 20 2016 17:25
Throwing a question out there: Does reaction support EDI integration out of the box or is that something that needs to be built outside of it?
Aaron Judd
@aaronjudd
Apr 20 2016 17:27
@spencern yes, the idea was to complete remove any kind of inventory dependency from the product / core..
so that the hooks are completely based on collection updates
but we can add “reaction hooks” as well, and I’d like to add more of these for use cases where you don’t want to depend on an update
Aaron Judd
@aaronjudd
Apr 20 2016 17:35
@matzero there isn’t a specific EDI integration, but looks like something like this https://www.npmjs.com/package/edi (didn’t really search a lot) could work. you really just need a way to communicate with some EDI endpoints, right?
Spencer Norman
@spencern
Apr 20 2016 17:39
I saw that inventory/adjust is called on Product.update, and looking through the inventory package now. When an order is put through, what method is currently adjusting inventory? That is to say, what method reduces the quantity available of a given product once it’s been attached to a given order
Mike Murray
@mikemurray
Apr 20 2016 17:39
@meladawy at the moment the shop name is the slug. Dashboard > Core (settings gear) > Name
Mateo
@matzero
Apr 20 2016 17:45
@aaronjudd yes I did look at that. thanks. and yes I do need to integrate with EDI for the fullfilment part of it
@aaronjudd is there a specific "hook" where this logic would be assuming someone completes a purchase
Maged Eladawy
@meladawy
Apr 20 2016 17:47
@mikemurray yea but its not URL friendly, it could contain spaces, or what ever..
Aaron Judd
@aaronjudd
Apr 20 2016 17:48
@meladawy we’ve got an issue to add slugs for the shop name.. will fix before 0.13 is released
@matzero you can hook into any collection, or method update, so for instance you could hook to orders/shipmentShipped
not exactly sure when you need to hook, but hooks can always be used before/after any method or collection update. we also have custom reaction hooks that we can add to non meteor functions, or within for additional control within an existing method
Mateo
@matzero
Apr 20 2016 17:51
@aaronjudd one last question if I may. Is Reaction based on pure Flux, Redux?
Mike Murray
@mikemurray
Apr 20 2016 17:52
@matzero not at the moment
Mateo
@matzero
Apr 20 2016 17:53
@mikemurray React JS served via node?
@mikemurray are you using Meteor?
Aaron Judd
@aaronjudd
Apr 20 2016 17:53
@matzero Meteor is moving to use a Redux based db client with http://www.apollostack.com/
Mike Murray
@mikemurray
Apr 20 2016 17:54
@matzero using meteor. v0.13 will be loading react from npm. And you can always use redux in your own modules as well.
I've done so in some tests, and it works well with meteor
Mateo
@matzero
Apr 20 2016 17:55
@aaronjudd That's good news. I've been using Redux with great results over the past year.
@mikemurray that sounds good. I was trying to avoid learning a new framework like Meteor.
Aaron Judd
@aaronjudd
Apr 20 2016 17:57
@matzero we (and Meteor) are in a transition right now from the old “meteor universe” into Npm, modules, react, redux, etc.. all the tools should work now, but the cleanup of the old ways is in progress..
Mateo
@matzero
Apr 20 2016 18:00
@aaronjudd oh i see, this is happening now now. When do you expect a stable version with the new architecture (npm, redux, etc)? 1 month 6 months?
Spencer Norman
@spencern
Apr 20 2016 18:30
So with current inventory model, an item is never “un-reserved” when the checkout is placed, which decreases availability because items are only available if they are status new?
Maged Eladawy
@meladawy
Apr 20 2016 18:45
@aaronjudd thank you...one more question...is there any API functions that i can use to retrieve the shops the current user is owner of
Mateo
@matzero
Apr 20 2016 18:51
@meladawy they are taking an LA siesta...
Maged Eladawy
@meladawy
Apr 20 2016 18:52
@matzero yea seems to be :D
hrath2015
@hrath2015
Apr 20 2016 19:36
will meteor --settings settings/dev.json work post 1.3 migration on dev branch? It is almost 30 mins and still downloads going on. is it normal?
Jeremy Shimko
@jshimko
Apr 20 2016 19:46
@hrath2015 yes, settings should work the same way. What do you mean by downloads still going?
Aaron Judd
@aaronjudd
Apr 20 2016 19:47
@hrath2015 the meteor packages do seem to take a ridiculous amount of time for a lot of users. not sure where your location is, but does seem like Meteor doesn’t use CDN,etc...
should note that I’m never seeing a fresh install take more than 3-5 minutes from clone to running...
Aaron Judd
@aaronjudd
Apr 20 2016 20:08
@spencern yes, I think that's correct
vkmrishad
@vkmrishad
Apr 20 2016 20:09
./reaction not working in windows
Aaron Judd
@aaronjudd
Apr 20 2016 20:12
@matzero 1 month.. (or less) for the NPM side, you can use redux,etc now though, we're just going to be doing some swapping from meteor packages to ES2015 modules over the next few weeks. as far as the Apollo stack (GraphQL/redux), that's all about the Meteor team, but they've made really strong progress just over the last week, so I'd guessing/expecting to see that in Meteor 1.4
@meladawy not a siesta, but there were tacos...
@vkmrishad that's not enough information for me to help you. sorry. (logs,errors?)
hrath2015
@hrath2015
Apr 20 2016 20:15
@aaronjudd and @jshimko thanks for reply. I will do a restart and see if any luck. it got stuck in step as in screenshot
vkmrishad
@vkmrishad
Apr 20 2016 20:19
@aaronjudd I mean , ./reaction cmd is not working in win 8.1 .But meteor works.Is there any specific cmd to run reactioncommerce in windows.
hrath2015
@hrath2015
Apr 20 2016 20:29
blob
Aaron Judd
@aaronjudd
Apr 20 2016 20:30
@vkmrishad you can use just meteor, the reaction commands are helpful though. Did you see the shell script instructions here: https://docs.reactioncommerce.com/reaction-docs/development/requirements ? We’re not (typically) windows users, but I don’t think anything has changed recently in the CLI that would have stopped working.
hrath2015
@hrath2015
Apr 20 2016 21:34
Not able to progress. Now different set of messages.

=> Your application has errors. Waiting for file change.

=> Meteor 1.3.2.3: Improvements to deploying binary npm packages,
importing stylesheets from node_modules, and more:
https://github.com/meteor/meteor/blob/master/History.md#v1323

This release is being downloaded in the background. Update your app to
Meteor 1.3.2.3 by running 'meteor update'.

Aaron Judd
@aaronjudd
Apr 20 2016 22:22
if you are trying to update to Meteor 1.3.2.3, we’re working on that update…. more refactoring on it’s way… in the mean time, stick to METEOR@1.3.1
Spencer Norman
@spencern
Apr 20 2016 22:22
:+1:
Aaron Judd
@aaronjudd
Apr 20 2016 22:23
surprise, surprise these aren’t little minor semver updates...
Brent Hoover
@zenweasel
Apr 20 2016 22:23
:-1:
Spencer Norman
@spencern
Apr 20 2016 22:23
I learned a long time ago to never update anything
Aaron Judd
@aaronjudd
Apr 20 2016 22:24
lol, with Meteor.. I agree. wait for us to wade through that crap
Brent Hoover
@zenweasel
Apr 20 2016 22:24
well, at least it’s easy to downgrade
it’s not a oneway upgrade path
Spencer Norman
@spencern
Apr 20 2016 22:25
agreed, it’s not as bad as I make it sound and I’m mostly kidding. Sure is nice having you guys around to test things for us ;)